Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing valid --target_os and --target_arch to tests causes failure #19906

Closed
wknapik opened this issue Dec 3, 2021 · 3 comments · Fixed by brave/brave-core#11436
Closed

Comments

@wknapik
Copy link
Contributor

wknapik commented Dec 3, 2021

In my PR, I'm switching to always passing --target_os and --target_arch when running unit/browser tests in CI. Apparently this can cause trouble. In a Linux x64 ASAN build, this is the difference between a successful:

ninja: Entering directory `/home/ubuntu/workspace/brave-browser-build-linux-x64-asan-nightly/src/out/Release' 

and an unsuccessful:

ninja: Entering directory `/home/ubuntu/workspace/brave-browser-build-linux-x64-asan-wknapik-nightly/src/out/linux_Release'
ninja: fatal: chdir to '/home/ubuntu/workspace/brave-browser-build-linux-x64-asan-wknapik-nightly/src/out/linux_Release' - No such file or directory

Seems like a bug.

@mihaiplesa
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants