Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

output dir fix (uplift to 1.33.x) #11529

Merged
merged 1 commit into from
Dec 9, 2021
Merged

output dir fix (uplift to 1.33.x) #11529

merged 1 commit into from
Dec 9, 2021

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Dec 9, 2021 •
edited by kjozwiak
Loading

Uplift of #11436
Resolves brave/brave-browser#19906

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team December 9, 2021 15:54
@brave-builds brave-builds self-assigned this Dec 9, 2021
@brave-builds brave-builds added this to the 1.33.x - Release milestone Dec 9, 2021
@mihaiplesa mihaiplesa added the CI/skip Do not run CI builds (except noplatform) label Dec 9, 2021
kjozwiak
kjozwiak approved these changes Dec 9, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.33.x approved after deliberating with @brave/uplift-approvers.

@kjozwiak kjozwiak merged commit 111a345 into 1.33.x Dec 9, 2021
@kjozwiak kjozwiak deleted the pr11436_mplesa-output-dir-fix_1.33.x branch December 9, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@bridiver bridiver Awaiting requested review from bridiver bridiver is a code owner

Assignees

@brave-builds brave-builds

Labels
CI/skip Do not run CI builds (except noplatform)
Projects
None yet
Milestone
1.33.x - Release
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @kjozwiak @mihaiplesa @brave-browser-releases