Custom background image from brave://new-tab-page doesn't work

[simonhong]

Description

Upstream custom background image feature is broken

Steps to Reproduce

1. Load brave://new-tab-page
2. Go to customize page via bottom right button
3. Upload any image via Upload from device button

Actual result:

Uploaded image is not displayed as a bg

Expected result:

Uploaded image should be used for bg

Reproduces how often:

Easily

Brave version (brave://version info)

Version/Channel Information:

• Can you reproduce this issue with the current release? yes
• Can you reproduce this issue with the beta channel? yes
• Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

[stephendonner]

Hi @simonhong - I'm not seeing this custom-background image UI exposed, using

Brave	1.35.72 Chromium: 97.0.4692.56 (Official Build) beta (64-bit)
Revision	04da6c66398ca50e603cc236a07dc7dfd3bbc750-refs/branch-heads/4692@{#990}
OS	Windows 10 Version 20H2 (Build 19042.1415)

I also looked in brave://flags for it; are we awaiting a merge of cr98 or something, first?

cc @brave/legacy_qa

[simonhong]

@stephendonner This issue is only for brave://new-tab-page. Can't see uploaded image at this page?
I confirmed that this page shows custom image with current beta(macOS).

[stephendonner]

1. brave://new-tab-page

I see it now, sorry; didn't realize there was an actual page at that address! I was just opening a new-tab page, not loading that URL.

[stephendonner]

Verified PASSED using

Brave	1.35.72 Chromium: 97.0.4692.56 (Official Build) beta (x86_64)
Revision	04da6c66398ca50e603cc236a07dc7dfd3bbc750-refs/branch-heads/4692@{#990}
OS	macOS Version 11.6.1 (Build 20G224)

Steps:

1. new profile
2. launched Brave
3. loaded brave://new-tab-page
4. clicked on Customize Brave at the bottom-right corner
5. clicked on Upload from device at the next screen
6. uploaded my custom image
7. clicked Done

Confirmed my custom image replaced the default white background 👍

example	example	example

[stephendonner]

Verified PASSED using

Brave	1.35.78 Chromium: 97.0.4692.71 (Official Build) beta (64-bit)
Revision	adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS	Linux

Steps:

1. new profile
2. launched Brave
3. loaded brave://new-tab-page
4. clicked on Customize Brave at the bottom-right corner
5. clicked on Upload from device at the next screen
6. uploaded my custom image
7. clicked Done

Confirmed my custom image replaced the default white background

example	example	example

[stephendonner]

Verified PASSED using

Brave	1.35.77 Chromium: 97.0.4692.71 (Official Build) beta (64-bit)
Revision	adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS	Windows 10 Version 20H2 (Build 19042.1415)

Steps:

1. new profile
2. launched Brave
3. loaded brave://new-tab-page
4. clicked on Customize Brave at the bottom-right corner
5. clicked on Upload from device at the next screen
6. uploaded my custom image
7. clicked Done

Confirmed my custom image replaced the default white background

example	example	example