-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ads and trackers not displayed on MarketWatch - follow up to 1874 #1998
Comments
Safe to close? (Just need to adjust filters to Aggressive on |
@ryanbr here's what I see with the various shield settings. If you can confirm the below images are expected then I think this is ok to close.
|
Yeah, the non-collapse cosmetic elements seems to be related to first-party. @antonok-edm could confirm ? |
Correct, looks like those are currently falling under first-party classification. |
I've got a solution to this and will put together a PR tomorrow, but the issue is there is some weird non-transitivy with innerText that i didn't account for. Usually innerText gives you the text of the subtree, w/o the text of script nodes. but, innerText on a script node gives you… the text of the script node. I'll fix in a PR asap |
For release notes: "Improve heuristic for determining first/third-party-ness of ads for default cosmetic filtering" |
Verification passed on LG Nexus 5 with Android 5.1 running 1.18.67 Bravearm.apk
Verification passed on
Verification passed on
|
Description
Follow up to #1874
If you navigate to marketwatch.com the site hack (not showing the eternally loading banners) works, however if you enable Ads/Tracking, the ads never show. Seems as though the cosmetic filters are not being taken into consideration.
This also happened with browser-laptop.
Steps to Reproduce
Actual result:
Ads do not display on the page
Expected result:
Ads should display.
Reproduces how often:
easily
Brave version (brave://version info)
Reproducible on current release:
Website problems only:
Additional Information
The text was updated successfully, but these errors were encountered: