Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlock using Trezor fails on loopring.io #20078

Open
abjugard opened this issue Dec 13, 2021 · 7 comments
Open

Unlock using Trezor fails on loopring.io #20078

abjugard opened this issue Dec 13, 2021 · 7 comments
Labels
feature/web3/wallet/core feature/web3/wallet/hardwaresupport feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. webcompat/not-shields-related Sites are breaking because of something other than Shields.

Comments

@abjugard
Copy link

Description

Unlock using Trezor fails on loopring.io

Steps to Reproduce

  1. Connect Trezor
  2. Visit loopring.io and try to unlock account using Trezor via Brave wallet
  3. Waiting on signature never stops, and in console the message "Invalid signature length" appears
    image

Actual result:

Unlock using Trezor fails on loopring.io

Expected result:

Should be able to unlock using Trezor via Brave wallet

Reproduces how often:

Easy

Brave version (brave://version info)

Brave: 1.32.115 Chromium: 96.0.4664.93 (Official Build) (64-bit)
Revision: 17531e0a70b4f8108f2418e8b5117f465077710b-refs/branch-heads/4664@{#1229}
OS: Windows 11 Version 21H2 (Build 22000.348)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Not tested
  • Can you reproduce this issue with the nightly channel? Yes (tested 2021-12-13 21:14, CET)

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? No, with Metamask

Miscellaneous Information:

The signature received by the Loopring Web3 code is 130 characters long, but the code expects it to be 65 characters long.

@Saotao1
Copy link

Saotao1 commented Dec 21, 2021

Have the same problem with Loopring wallet in OS

@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 3, 2022
@srirambv srirambv added the feature/web3/wallet Integrating Ethereum+ wallet support label Mar 3, 2022
@bbondy bbondy added priority/P2 A bad problem. We might uplift this to the next planned release. feature/web3/wallet/core and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Mar 16, 2022
@abjugard
Copy link
Author

abjugard commented Feb 18, 2023

I've just verified this is indeed still an issue on latest Brave. Highlight me if you need any more information.

@abjugard
Copy link
Author

abjugard commented Jun 2, 2023

@bbondy Any progress on this internally?

@nvonpentz
Copy link
Member

@srirambv are you able to reproduce this issue?

@yrliou yrliou added webcompat/not-shields-related Sites are breaking because of something other than Shields. priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Nov 9, 2023
@abjugard
Copy link
Author

abjugard commented Nov 9, 2023

Hmm, unlock account seems to work now!

Unfortunately sending between L2 accounts just gets stuck in a loop of verifying the signing address. The following approval appears in Brave wallet before the prompt on my Trezor T to verify the signing address:

Domain:
{"chainId":1,"name":"Loopring Protocol","verifyingContract":"0x0BABA1Ad5bE3a5C0a66E7ac838a129Bf948f1eA4","version":"3.6.0"}
Message:
{"amount":"6000000000000000","feeTokenID":1,"from":"0xMyL2Account","maxFee":"385000000000000000","storageID":1,"to":"0xAnotherL2Account","tokenID":0,"validUntil":1702146201}

@nvonpentz
Copy link
Member

@abjugard By L2 account, do you mean that this transaction is happening on an L2, i.e. not Ethereum mainnet? If so, could you take a look at #23448 (comment) and let me know if that solves the issue.

@abjugard
Copy link
Author

abjugard commented Nov 9, 2023

@nvonpentz It does not. Yes, I am trying to sign a transaction on loopring.io moving funds between two Loopring L2 wallets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet/core feature/web3/wallet/hardwaresupport feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. webcompat/not-shields-related Sites are breaking because of something other than Shields.
Projects
Status: Backlog
Development

No branches or pull requests

7 participants