Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fit Torrent media to window size #1229

Closed
btlechowski opened this issue Sep 21, 2018 · 1 comment · Fixed by brave/brave-core#3005
Closed

Fit Torrent media to window size #1229

btlechowski opened this issue Sep 21, 2018 · 1 comment · Fixed by brave/brave-core#3005
Assignees
@feross
Labels
bug feature/webtorrent Label for webtorrent related issues priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
0.69.x - Release

Comments

@btlechowski
Copy link

Steps to Reproduce

  1. Go to https://webtorrent.io/free-torrents
  2. Download Big Buck Bunny magnet link
  3. Download the torrent content
  4. Click on Big Buck Bunny.mp4 to open it in the browser
  5. Click on poster.jpg to open it in the browser

Actual result:

The Big Buck Bunny.mp4 movie is cropped
image

poster.jpg is too small
image

Expected result:

The media fits the window viewport.

Reproduces how often:

always

Brave version (chrome://version info)

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows 7

Resolution: 1366x768

cc @yrliou

Related issues: #289 #855
@btlechowski btlechowski added the feature/webtorrent Label for webtorrent related issues label Sep 21, 2018
@btlechowski btlechowski mentioned this issue Sep 21, 2018
Closed
@bbondy bbondy added this to the 1.x Backlog milestone Sep 21, 2018
@srirambv srirambv added the bug label Sep 21, 2018
@rebron rebron added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Jan 29, 2019
@rebron rebron removed this from the 1.x Backlog milestone Feb 7, 2019
@feross feross self-assigned this Jul 23, 2019
feross added a commit to brave/brave-core that referenced this issue Jul 25, 2019
@feross
WebTorrent: Fit video/audio media to window size
8c37d40 
Fixes: brave/brave-browser#1229

Supercedes and closes: #2261
@feross feross mentioned this issue Jul 25, 2019
Merged
32 tasks
@kjozwiak kjozwiak added this to the 0.70.x - Nightly milestone Jul 25, 2019
@btlechowski
Copy link
Author

btlechowski commented Sep 18, 2019 •
edited by GeetaSarvadnya
Loading

Awesome work!

Verification passed on

Brave 0.70.96 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Ubuntu 18.04 LTS

MP4
image
jpg
image
MP3
image

Verification PASSED on macOS 10.14.6 x64 using the following build:

Brave 0.69.126 Chromium: 77.0.3865.65 (Official Build) (64-bit)
Revision 87a331a3169cab563505fb44011058b904011ba1-refs/branch-heads/3865@{#726}
OS macOS Version 10.14.6 (Build 18G95)

Screen Shot 2019-09-18 at 12 58 08 AM

Screen Shot 2019-09-18 at 12 57 57 AM

Screen Shot 2019-09-18 at 1 04 14 AM

Verification passed on

Brave 0.70.97 Chromium: 77.0.3865.65 (Official Build) beta (64-bit)
Revision 87a331a3169cab563505fb44011058b904011ba1-refs/branch-heads/3865@{#726}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Big Buck Bunny.mp4:

image

poster.jpg:

image

MP 3:
image

@btlechowski btlechowski mentioned this issue Oct 15, 2020
Closed
@ZOASR ZOASR mentioned this issue Oct 16, 2020
Closed
@cyjambo cyjambo mentioned this issue Oct 17, 2020
Closed
@JenuelDev JenuelDev mentioned this issue Oct 18, 2020
Closed
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Oct 19, 2020
Closed
@mcmxcdev mcmxcdev mentioned this issue Oct 19, 2020
Closed
@btlechowski btlechowski mentioned this issue Oct 19, 2020
Closed
@saberistic saberistic mentioned this issue Oct 19, 2020
Closed
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Oct 20, 2020
Closed
@bwims bwims mentioned this issue Oct 20, 2020
Closed
@jonathansampson jonathansampson mentioned this issue Oct 20, 2020
Closed
@ibLeDy ibLeDy mentioned this issue Oct 20, 2020
Closed
This was referenced Oct 20, 2020
Closed
Closed
Closed
@phoogm phoogm mentioned this issue Oct 21, 2020
Closed
This was referenced Oct 21, 2020
Closed
Closed
@LaurenWags LaurenWags mentioned this issue Oct 21, 2020
Closed
@srirambv srirambv mentioned this issue Oct 22, 2020
Closed
22 tasks
@btlechowski btlechowski mentioned this issue Oct 22, 2020
Closed
@cowwoc cowwoc mentioned this issue Dec 9, 2021
Open
This was referenced Dec 9, 2021
Closed
Closed
@pilsnerbeer pilsnerbeer mentioned this issue Dec 10, 2021
Closed
@nlpsuge nlpsuge mentioned this issue Dec 11, 2021
Open
@iam-cult iam-cult mentioned this issue Dec 11, 2021
Open
@lglista lglista mentioned this issue Dec 12, 2021
Open
@GabeVilela GabeVilela mentioned this issue Dec 13, 2021
Open
@abjugard abjugard mentioned this issue Dec 13, 2021
Open
@freezingDaniel freezingDaniel mentioned this issue Dec 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@feross feross

Labels
bug feature/webtorrent Label for webtorrent related issues priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.69.x - Release
Development

Successfully merging a pull request may close this issue.

WebTorrent: Fit video/audio media to window size brave/brave-core
8 participants
@feross @bbondy @kjozwiak @rebron @srirambv @LaurenWags @btlechowski @GeetaSarvadnya