When balance cannot be fetched from custodian or user is in Logged out state, use unavailable text or "- -" for the Rewards balance

[Miyayes]

Description

When a user is in a logged out state and can't query their balance from their custodian, their balance will usually show 0.0 BAT (since all vBAT has already been userdrained to the custodian).

• Rewards panel
• Rewards settings page
• Rewards NTP widget

Update: This will also happen when custodian has downtime and the balance cannot be fetched. So, might be more general than when user is in a logged out state.

Solution

Use "N/A" (or some other string), which may be less alarming to users than seeing a declaration of 0.0 BAT.

[Miyayes]

Even if user is in a logged out state and receives some vBAT (an edgier case), I still think it's more beneficial to show N/A. The user can either disconnect from their custodian completely to get rid of N/A and see their vBAT there, or they can connect again and then the vBAT will be instantly userdrained to their custodial account.

[zenparsing]

Related questions:

• What happens on the tipping banner when the user is in this state? Do we disallow tipping (even if they have vBAT from an Ad grant)?
• If we are displaying "N/A" and the user has vBAT, do we allow AC or monthly tips?

[Miyayes]

This will help enforce correct vBAT vs. BAT balance states: #21588

[Miyayes]

Using dashes instead of N/A, plus a little (i) tooltip.

See screenshots in the PR.

[GeetaSarvadnya]

Verification PASSED on

Brave | 1.41.77 Chromium: 103.0.5060.53 (Official Build) beta (64-bit)
-- | --
Revision | a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853}
OS | Windows 10 Version 21H2 (Build 19044.1766)

• Verified the test plan from Show unavailable message if user is in disconnected state brave-core#12839

Uphold_PASSED

• Clean profile
• Enable rewards
• Link uphold account
• Trigger Logged out-state via uphold->go to settings->application->authorization->remove brave
• Confirmed that user can reconnect the Uphold accounts and see the account balance by clicking on the Log in to Gemini to see your balance via BR panel/settings page/NTP widget

Uphold	Settings page	BR panel	NTP widget

Gemini_PASSED

• Clean profile
• Enable rewards
• Link uphold account
• Trigger Logged out-state via Gemini Account->"Account"->Settings->Applications->You'll see Brave Browser listed. Hover over 3 dots menu and select "Revoke Access"
• Confirmed that user can reconnect the Gemini accounts and see the account balance by clicking on the Log in to Gemini to see your balance via BR panel/settings page/NTP widget

Gemini	Settings page	BR panel	NTP widget

bitFlyer_PASSED

• Clean profile
• Enable rewards
• Link uphold account
• Trigger Logged out-state
• Confirmed that the user can reconnect the bitFlyer account and see the account balance by clicking on the Log in to Gemini to see your balance via BR panel/settings page/NTP widget

bitFlyer	Settings page	BR panel	NTP widget