Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show unavailable message if user is in disconnected state #12839

Merged
merged 1 commit into from
May 20, 2022

Conversation

zenparsing
Copy link
Collaborator

@zenparsing zenparsing commented Mar 30, 2022

Resolves brave/brave-browser#20991

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Screenshots

Screen Shot 2022-05-17 at 5 11 29 PM

Screen Shot 2022-05-17 at 5 24 58 PM

Screen Shot 2022-05-17 at 5 25 10 PM

Screen Shot 2022-05-17 at 5 25 25 PM

Test Plan

  • Open browser with a fresh profile.
  • Enable Rewards and verify with an external wallet provider.
  • Invalidate the authentication tokens for the wallet provider.
    • For Uphold, this can be accomplished by visiting your account page, clicking the "3 dots" more menu, and selecting "Integrations". The integration for "Brave Browser" can then be removed.
  • Visit the NPT and verify that "login" messaging appears.
  • Open the Rewards panel and verify that "login" messaging appears.
  • Visit the Rewards page and verify that "login" messaging appears.
  • Verify that clicking on the login messaging box will take the user to the wallet provider authorization page.

@zenparsing zenparsing requested a review from a team as a code owner March 30, 2022 15:29
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Mar 30, 2022
@szilardszaloki
Copy link
Collaborator

@zenparsing Do we want to handle the case where fetch balance returns with an error?

@zenparsing
Copy link
Collaborator Author

@szilardszaloki We do, I'll mark this as a draft until that's been added.

@zenparsing zenparsing marked this pull request as draft March 30, 2022 16:36
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@zenparsing zenparsing force-pushed the ksmith-balance-unavailable branch 6 times, most recently from c9e48c3 to c96b4cd Compare May 11, 2022 16:13
@zenparsing zenparsing marked this pull request as ready for review May 11, 2022 16:13
@github-actions github-actions bot added rebase and removed rebase labels May 11, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@zenparsing zenparsing force-pushed the ksmith-balance-unavailable branch 2 times, most recently from 9a9bd23 to f31b3e2 Compare May 17, 2022 21:26
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Collaborator

@szilardszaloki szilardszaloki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zenparsing zenparsing requested a review from aguscruiz May 19, 2022 19:40
Copy link
Collaborator

@aguscruiz aguscruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great!

@zenparsing zenparsing added this to the 1.41.x - Nightly milestone May 20, 2022
@zenparsing zenparsing merged commit 95be25f into master May 20, 2022
@zenparsing zenparsing deleted the ksmith-balance-unavailable branch May 20, 2022 12:50
@bsclifton
Copy link
Member

bsclifton commented May 23, 2022

Tested - my account might be different (since it's older? or maybe Uphold changed the UI) but integrations showed for me in a weird "shapes" menu (instead of 3 dot menu):
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
5 participants