Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add native API to access the Ratios server's markets coingecko proxy endpoint for frontend use #21455

Closed
nvonpentz opened this issue Mar 3, 2022 · 1 comment · Fixed by brave/brave-core#12510
Closed

Add native API to access the Ratios server's markets coingecko proxy endpoint for frontend use #21455

nvonpentz opened this issue Mar 3, 2022 · 1 comment · Fixed by brave/brave-core#12510
Assignees
@nvonpentz
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.44.x - Release

Comments

@nvonpentz
Copy link
Member

Description

The overall goal is to give the frontend access to the coingecko endpoint for returning top currencies. We proxy calls to coingecko, through the ratios server here brave-intl/bat-go#1234. So we need to expose an API in C++ for the frontend code to use that hits the new ratios endpoint.

Add to AssetRatioService from components/brave_wallet/common/brave_wallet.mojom.
@nvonpentz nvonpentz added feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop labels Mar 3, 2022
@nvonpentz nvonpentz self-assigned this Mar 3, 2022
@nvonpentz nvonpentz mentioned this issue Mar 7, 2022
Merged
25 tasks
@bbondy bbondy added feature/web3/wallet/core priority/P3 The next thing for us to work on. It'll ride the trains. labels Mar 17, 2022
@brave-builds brave-builds added this to the 1.44.x - Nightly milestone Aug 19, 2022
@srirambv
Copy link
Contributor

Verified as part of #20674 (comment)

@kjozwiak kjozwiak mentioned this issue Sep 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nvonpentz nvonpentz

Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.44.x - Release
Development

Successfully merging a pull request may close this issue.

Add Ratios API for coingecko coin markets data brave/brave-core
5 participants
@bbondy @nvonpentz @srirambv @brave-builds @muliswilliam