Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Market Data Feature #20674

Closed
muliswilliam opened this issue Jan 25, 2022 · 3 comments · Fixed by brave/brave-core#12635 or brave/brave-core#12510
Closed

Market Data Feature #20674

muliswilliam opened this issue Jan 25, 2022 · 3 comments · Fixed by brave/brave-core#12635 or brave/brave-core#12510
Assignees
@muliswilliam
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include

Comments

@muliswilliam
Copy link

muliswilliam commented Jan 25, 2022 •
edited
Loading

Add a new tab to display coin markets data from CoinGecko.
Figma Link: https://www.figma.com/file/jZrVG7dsi5npXFTDC6LDGn/Crypto?node-id=95%3A9890
@muliswilliam muliswilliam added OS/Android Fixes related to Android browser functionality OS/Desktop labels Jan 25, 2022
@muliswilliam muliswilliam changed the title Asset Price Listing Market Data Feature Jan 26, 2022
@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 3, 2022
@srirambv srirambv added the feature/web3/wallet Integrating Ethereum+ wallet support label Mar 3, 2022
@muliswilliam muliswilliam added this to the 1.38.x - Nightly milestone Mar 16, 2022
This was referenced Mar 16, 2022
Closed
Merged
@bbondy bbondy added the front-end-change This task is a front end task and doesn't need any C++ changes label Mar 17, 2022
@kjozwiak
Copy link
Member

kjozwiak commented Mar 23, 2022 •
edited
Loading

Removing from the 1.38.x milestone as this isn't labelled as release/blocking. PR is also in draft as per brave/brave-core#12635. If this is something that needs uplifted, please create uplifts for the appropriate channels once it lands in master. Please see https://github.com/brave/brave-browser/wiki/Triage-Guidelines.

@kjozwiak kjozwiak removed this from the 1.38.x - Beta milestone Mar 23, 2022
@muliswilliam muliswilliam mentioned this issue Mar 24, 2022
Closed
23 tasks
@nvonpentz nvonpentz mentioned this issue Mar 31, 2022
Merged
25 tasks
@srirambv
Copy link
Contributor

Fixed by brave/brave-core#12510

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.44.97 Chromium: 106.0.5249.40 (Official Build) (64-bit)
Revision fab1d91915d2722d6339aaa7f4e9ce44f1e9b103-refs/branch-heads/5249@{#442}
OS Linux
  • Verified steps from brave/brave-core#12510
  • Verified Market tab is shown on new wallet or upgrade in between Portfolio and Account
  • Verified market tab lists all tokens with Price, 24hr change, Mkt. Cap & Volume
  • Verified able to list All tokens or only the Tradable tokens
  • Verified able to sort tokens based on Price, 24hr change, Mkt. Cap & Volume
  • Verified able to search a token in the search box
  • Verified clicking on a token from Market tab loads the token details with graph. Adds Information below about Market Rank/24hr Volume/Market Cap
  • Encountered #25546, #25547 & #25548
20674.mp4

Verification passed on

Brave 1.44.97 Chromium: 106.0.5249.40 (Official Build) (64-bit)
Revision fab1d91915d2722d6339aaa7f4e9ce44f1e9b103-refs/branch-heads/5249@{#442}
OS Windows 11 Version 21H2 (Build 22000.978)
  • Verified steps from brave/brave-core#12510
  • Verified Market tab is shown on new wallet or upgrade in between Portfolio and Account
  • Verified market tab lists all tokens with Price, 24hr change, Mkt. Cap & Volume
  • Verified able to list All tokens or only the Tradable tokens
  • Verified able to sort tokens based on Price, 24hr change, Mkt. Cap & Volume
  • Verified able to search a token in the search box
  • Verified clicking on a token from Market tab loads the token details with graph. Adds Information below about Market Rank/24hr Volume/Market Cap
  • Encountered #25546, #25547 & #25548
20674.mp4

Verification passed on

Brave 1.44.97 Chromium: 106.0.5249.40 (Official Build) (arm64)
Revision fab1d91915d2722d6339aaa7f4e9ce44f1e9b103-refs/branch-heads/5249@{#442}
OS macOS Version 12.4 (Build 21F79)
  • Verified steps from brave/brave-core#12510
  • Verified Market tab is shown on new wallet or upgrade in between Portfolio and Account
  • Verified market tab lists all tokens with Price, 24hr change, Mkt. Cap & Volume
  • Verified able to list All tokens or only the Tradable tokens
  • Verified able to sort tokens based on Price, 24hr change, Mkt. Cap & Volume
  • Verified able to search a token in the search box
  • Verified clicking on a token from Market tab loads the token details with graph. Adds Information below about Market Rank/24hr Volume/Market Cap
  • Encountered #25546, #25547 & #25548
20674.mov

@srirambv srirambv mentioned this issue Sep 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muliswilliam muliswilliam

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
No milestone
4 participants
@bbondy @kjozwiak @srirambv @muliswilliam