Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brave News will allow website URLs to be entered to the "Add Source" text input, and will search for feeds linked from the html (Desktop) #21768

Closed
mattmcalister opened this issue Mar 18, 2022 · 3 comments · Fixed by brave/brave-core#12559
Closed

Brave News will allow website URLs to be entered to the "Add Source" text input, and will search for feeds linked from the html (Desktop) #21768

mattmcalister opened this issue Mar 18, 2022 · 3 comments · Fixed by brave/brave-core#12559
Assignees
@petemill
Labels
feature/brave-news formerly brave-today OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA/Yes release-notes/include
Milestone
1.39.x - Release

Comments

@mattmcalister
Copy link

mattmcalister commented Mar 18, 2022 •
edited by petemill
Loading

Brave News allows users to add RSS feeds by feed URL. Users should be able to add a domain which then triggers a search for any autodiscovery feed URLs at that domain.

Test plan is on brave/brave-core#12559
@mattmcalister mattmcalister added priority/P2 A bad problem. We might uplift this to the next planned release. OS/Android Fixes related to Android browser functionality OS/Desktop feature/brave-news formerly brave-today labels Mar 18, 2022
@petemill petemill mentioned this issue Apr 6, 2022
Merged
25 tasks
@petemill petemill removed the OS/Android Fixes related to Android browser functionality label Apr 14, 2022
@petemill petemill changed the title Search domains for RSS feeds to add in Your Sources Search domains for RSS feeds to add in Your Sources (Desktop) Apr 14, 2022
@petemill petemill changed the title Search domains for RSS feeds to add in Your Sources (Desktop) Brave News will allow website URLs to be entered to the "Add Source" text input, and will search for feeds linked from the html (Desktop) Apr 14, 2022
@petemill petemill added this to the 1.39.x - Nightly milestone Apr 14, 2022
@stephendonner
Copy link

Took a stab at this, but marking QA/Blocked until we've got a few more working multple-feed sources for autodiscovery (https://news.com example from test plan isn't working).

Asked in https://bravesoftware.slack.com/archives/CU56GUJ1H/p1651081419613779

@stephendonner
Copy link

Took a stab at this, but marking QA/Blocked until we've got a few more working multple-feed sources for autodiscovery (https://news.com example from test plan isn't working).

Asked in https://bravesoftware.slack.com/archives/CU56GUJ1H/p1651081419613779

@timchilds gave me a couple multiple-feed sources to check out; no longer blocked:

https://www.fightmag.com.au/
https://talksport.com/sport/boxing/

@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Apr 28, 2022
@stephendonner
Copy link

stephendonner commented Apr 28, 2022 •
edited
Loading

Verification PASSED using

Brave 1.39.83 Chromium: 101.0.4951.41 (Official Build) beta (x86_64)
Revision 93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}
OS macOS Version 12.4 (Build 21F5063e)

Shared steps:

  1. install 1.39.83
  2. launch Brave
  3. open a new-tab page
  4. scroll down
  5. click on Show Brave News
  6. click on Customize
  7. enter feed URL
  8. click on Add source
  9. click on individual + icons for each feed

Confirmed for each:

  • auto-discovery worked
  • presenting multiple feeds worked
  • adding and removing feeds worked
  • scheme fix-up for URIs missing HTTPS worked: kinsta.com/feed -> https://kinsta.com/feed
  • we do NOT try to "fix" HTTP -> HTTPS URLs, which is good and expected 👍
URL auto-discovery results added in Brave News
fightmag.com Screen Shot 2022-04-27 at 5 41 23 PM Screen Shot 2022-04-27 at 5 42 18 PM Screen Shot 2022-04-27 at 5 42 58 PM
https://talksport.com/sport/motorsport Screen Shot 2022-04-27 at 5 52 12 PM Screen Shot 2022-04-27 at 5 52 19 PM Screen Shot 2022-04-27 at 5 52 59 PM
theisleofthanetnews.com Screen Shot 2022-04-27 at 5 48 32 PM Screen Shot 2022-04-27 at 5 48 37 PM Screen Shot 2022-04-27 at 5 49 50 PM
stephendonner.wordpress.com Screen Shot 2022-04-27 at 5 31 48 PM Screen Shot 2022-04-27 at 5 32 12 PM Screen Shot 2022-04-27 at 5 35 43 PM

NOTE: Filed: #22583 and #22593; more issues to come, as discovered, but the core feature is verified.

@stephendonner stephendonner added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 28, 2022
@LaurenWags LaurenWags mentioned this issue May 23, 2022
Closed
avinassh pushed a commit to avinassh/brave-browser-hardening that referenced this issue May 29, 2022
Brave Browser 1.39.111
6b60f4b 
 - Added Solana support for account creation, sending SOL and sending SPL tokens with Brave Wallet. ([#22348](brave/brave-browser#22348))
 - Added the ability to buy with Ramp using Brave Wallet. ([#21639](brave/brave-browser#21639))
 - Added JSONSanitizer to API helper requests for Brave Wallet. ([#21831](brave/brave-browser#21831))
 - Added Dapp UI for requesting a public key and for decrypting ciphers using Brave Wallet. ([#21177](brave/brave-browser#21177))
 - Added web3_clientVersion support for Brave Wallet. ([#19278](brave/brave-browser#19278))
 - Added the ability to allow users to search sites for RSS feeds for Brave News. ([#21768](brave/brave-browser#21768))
 - Added support for blob partitioning. ([#21746](brave/brave-browser#21746))
 - Added minimum macOS version for Sparkle update process. ([#22918](brave/brave-browser#22918))
 - [Security] Blocked "window.ethereum" completely in third party iframes. ([#22686](brave/brave-browser#22686))
 - [Security] Updated Brave Wallet panel to prominently display eTLD+1 as reported on HackerOne by renekroka. ([#21787](brave/brave-browser#21787))
 - [Security] Fixed incorrect origin being displayed in Brave Wallet when a spend approval is pending. ([#19557](brave/brave-browser#19557))
 - Implemented eth_getEncryptionPublicKey for Brave Wallet. ([#19276](brave/brave-browser#19276))
 - Implemented account discovery when restoring Brave Wallet. ([#18104](brave/brave-browser#18104))
 - Updated Omaha installer version for Windows to v1.3.36.113. ([#22060](brave/brave-browser#22060))
 - Updated default IPFS configuration values. ([#22068](brave/brave-browser#22068))
 - Updated Gas Limit validation and error messaging for unapproved transactions with Brave Wallet. ([#21714](brave/brave-browser#21714))
 - Updated Brave Wallet to automatically add swap taker asset to the visible asset list. ([#21428](brave/brave-browser#21428))
 - Updated Brave Wallet portfolio network filter for multichain support. ([#20780](brave/brave-browser#20780))
 - Reduced adblock filter memory usage by optimizing unused regex rules. ([#21970](brave/brave-browser#21970))
 - Removed known Dialog Insight user tracking parameters from URLs. ([#22082](brave/brave-browser#22082))
 - Removed ability to swap ERC721 tokens with Brave Wallet. ([#21550](brave/brave-browser#21550))
 - Fixed crash which occurred when opening Brave Shields while using Google Meet. ([#22814](brave/brave-browser#22814))
 - Fixed inability to rename Solana account in Brave Wallet after it has been created. ([#22958](brave/brave-browser#22958))
 - Fixed incorrectly computed insufficient funds errors in Brave Wallet. ([#22877](brave/brave-browser#22877))
 - Fixed ERC20 and ERC721 transfers being incorrectly displayed as ETH transfers in the Brave Wallet transactions panel. ([#22044](brave/brave-browser#22044))
 - Fixed text alignment issues under the Brave Wallet "Recent transactions" panel when using long account names. ([#21216](brave/brave-browser#21216))
 - Fixed breakage in webpack build caused by OpenSSL 3.0. ([#22305](brave/brave-browser#22305))
 - Fixed two windows being opened on launch when the browser was installed without administrator privileges on Windows. ([#22179](brave/brave-browser#22179))
 - Upgraded Chromium to 102.0.5005.61. ([#22923](brave/brave-browser#22923)) ([Changelog for 102.0.5005.61](https://chromium.googlesource.com/chromium/src/+log/101.0.4951.67..102.0.5005.61?pretty=fuller&n=1000))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petemill petemill

Labels
feature/brave-news formerly brave-today OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA/Yes release-notes/include
Projects
None yet
Milestone
1.39.x - Release
Development

Successfully merging a pull request may close this issue.

Brave News allow user to search sites for RSS feeds brave/brave-core
3 participants
@mattmcalister @stephendonner @petemill