Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wire NFT Details Page to Backend #22623

Closed
muliswilliam opened this issue Apr 29, 2022 · 2 comments · Fixed by brave/brave-core#13217 or brave/brave-core#13370
Closed

Wire NFT Details Page to Backend #22623

muliswilliam opened this issue Apr 29, 2022 · 2 comments · Fixed by brave/brave-core#13217 or brave/brave-core#13370
Assignees
@muliswilliam
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.44.x - Release

Comments

@muliswilliam
Copy link

Description

  • Show NFT tokens in Portfolio under NFTs list
  • Fetch NFT metadata when an NFT is selected

image

Expected result:

NFTs should be listed in portfolio and when selected should navigate the user to NFTs details page
@muliswilliam muliswilliam self-assigned this Apr 29, 2022
@muliswilliam muliswilliam added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include front-end-change This task is a front end task and doesn't need any C++ changes labels Apr 29, 2022
@muliswilliam muliswilliam added this to the 1.40.x - Nightly milestone Apr 29, 2022
@muliswilliam muliswilliam mentioned this issue Apr 29, 2022
Merged
25 tasks
@LaurenWags LaurenWags added the feature/web3/wallet Integrating Ethereum+ wallet support label May 17, 2022
@muliswilliam muliswilliam mentioned this issue May 18, 2022
Merged
25 tasks
@srirambv
Copy link
Contributor

Reopening the issue as this is now linked with brave/brave-core#13370 which is still open and was reverted brave/brave-core#13217 as confirmed by @muliswilliam.

We will have to uplift brave/brave-core#13370 once it's merged in case we want this to be part of 1.40.x

cc: @bbondy @kjozwiak @jamesmudgett

@srirambv srirambv reopened this May 31, 2022
@srirambv srirambv removed this from the 1.40.x - Beta milestone May 31, 2022
@brave-builds brave-builds added this to the 1.44.x - Nightly milestone Jul 28, 2022
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.44.97 Chromium: 106.0.5249.40 (Official Build) (64-bit)
Revision 4d5f098fca6ab7f4b6b7c240be3d9593c2357709-refs/branch-heads/5249@{#531}
OS Linux
  • Verified steps from brave/brave-core#13370
  • Verified able to add NFT as a custom asset lists NFT under NFT's section in portfolio
  • Verified able to add multiple NFT's and list
  • Verified clicking on an NFT loads the NFT details view
  • Verified NFT details view shows Chain details, Token Standard, Token ID, Description & owner address & any transactions done on the NFT
  • Verified NFT details view shows both image and video images
  • Verified able to filter NFT's on portfolio page
  • Verified able to filter NFT's based on network filter
  • Verified NFT is loaded in chrome-untrusted:// iframe
  • Encountered #25588 & #25590
chrome://untrusted iframe NFT details view NFT listing on all netowrk NFt listing by filter

Verification passed on

Brave 1.44.97 Chromium: 106.0.5249.40 (Official Build) (64-bit)
Revision 4d5f098fca6ab7f4b6b7c240be3d9593c2357709-refs/branch-heads/5249@{#531}
OS Windows 11 Version 21H2 (Build 22000.978)
  • Verified steps from brave/brave-core#13370
  • Verified able to add NFT as a custom asset lists NFT under NFT's section in portfolio
  • Verified able to add multiple NFT's and list
  • Verified clicking on an NFT loads the NFT details view
  • Verified NFT details view shows Chain details, Token Standard, Token ID, Description & owner address & any transactions done on the NFT
  • Verified NFT details view shows both image and video images
  • Verified able to filter NFT's on portfolio page
  • Verified able to filter NFT's based on network filter
  • Verified NFT is loaded in chrome-untrusted:// iframe
  • Encountered #25588 & #25590
chrome://untrusted iframe NFT details view NFT listing on all netowrk NFt listing by filter

Verification passed on

Brave 1.44.97 Chromium: 106.0.5249.40 (Official Build) (arm64)
Revision 4d5f098fca6ab7f4b6b7c240be3d9593c2357709-refs/branch-heads/5249@{#531}
OS macOS Version 12.4 (Build 21F79)
  • Verified steps from brave/brave-core#13370
  • Verified able to add NFT as a custom asset lists NFT under NFT's section in portfolio
  • Verified able to add multiple NFT's and list
  • Verified clicking on an NFT loads the NFT details view
  • Verified NFT details view shows Chain details, Token Standard, Token ID, Description & owner address & any transactions done on the NFT
  • Verified NFT details view shows both image and video images
  • Verified able to filter NFT's on portfolio page
  • Verified able to filter NFT's based on network filter
  • Verified NFT is loaded in chrome-untrusted:// iframe
  • Encountered #25588 & #25590
chrome://untrusted iframe NFT details view NFT listing on all netowrk NFt listing by filter
image image image image

@kjozwiak kjozwiak mentioned this issue Sep 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muliswilliam muliswilliam

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.44.x - Release
Development

Successfully merging a pull request may close this issue.

NFT Details Page brave/brave-core
NFT Details Screen brave/brave-core
4 participants
@srirambv @LaurenWags @brave-builds @muliswilliam