Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding NFT doesn't work the first time #25588

Closed
srirambv opened this issue Sep 23, 2022 · 1 comment
Closed

Adding NFT doesn't work the first time #25588

srirambv opened this issue Sep 23, 2022 · 1 comment
Assignees
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support intermittent-issue OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes

Comments

@srirambv
Copy link
Contributor

Description

Adding NFT doesn't work the first time

Steps to Reproduce

  1. Try adding a NFT
  2. Sometimes doesn't work the first time

Actual result:

Adding NFT doesn't work the first time. Couple of retry or giving it a few mins and trying again works

Expected result:

Should be able to add NFT's instantly (whether you own it or not)

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.44.97 Chromium: 106.0.5249.55 (Official Build) (64-bit)
Revision 4d5f098fca6ab7f4b6b7c240be3d9593c2357709-refs/branch-heads/5249@{#531}
OS All

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @muliswilliam @nvonpentz

@muliswilliam
Copy link

@srirambv I separated the NFT form from the general add custom asset form. I have tested the new implementation in latest master and it is okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support intermittent-issue OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes
Projects
Archived in project
Development

No branches or pull requests

2 participants