Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Show Sponsored Images' button displays wrong colour #22645

Closed
mrworldwide1 opened this issue May 2, 2022 · 4 comments
Closed

'Show Sponsored Images' button displays wrong colour #22645

mrworldwide1 opened this issue May 2, 2022 · 4 comments

Comments

@mrworldwide1
Copy link

mrworldwide1 commented May 2, 2022

Description

On the new tab page, when Background Images are disabled, the 'Show Sponsored Images' button changes to orange.

Steps to Reproduce

  1. Open a new tab
  2. On the bottom, click customize
  3. Go to the Background Image section
  4. Toggle Show Sponsored Images off

Actual result:

3

Expected result:

The colour of the toggle should be white instead of orange, similar to how it is when Show Background Images is enabled but Show Sponsored Images is disabled.

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.38.109 Chromium: 101.0.4951.41 (Official Build) (64-bit)
Revision 93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}
OS Windows 10 Version 21H2 (Build 19044.1682)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
    Yes

  • Can you reproduce this issue with the beta channel?
    Yes

  • Can you reproduce this issue with the nightly channel?
    Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
    No

  • Does the issue resolve itself when disabling Brave Rewards?
    No

  • Is the issue reproducible on the latest version of Chrome?
    N/A

Miscellaneous Information:

@chitangchin
Copy link

I will work on this in a few hours. Have you attempted any solutions so far that havent worked?

@rebron rebron added feature/new-tab priority/P5 Not scheduled. Don't anticipate work on this any time soon. good first issue bug labels May 19, 2022
@mrworldwide1
Copy link
Author

@chitangchin

I will work on this in a few hours. Have you attempted any solutions so far that havent worked?

Reinstalling Brave, installing on a different Windows and Ubuntu device haven't worked.

@MadhaviSeelam
Copy link

MadhaviSeelam commented Jun 8, 2022

Verification PASSED using

Brave | 1.41.47 Chromium: 102.0.5005.78 (Official Build) nightly (64-bit)
-- | --
Revision | df6dbb5a9fd82af3f567198af2eb5fb4876ef99c-refs/branch-heads/5005_59@{#3}
OS | Windows 11 Version 21H2 (Build 22000.675)
  • New profile
  • Launch Brave
  • Skip welcome tour
  • Click customize
  • Toggle Show Background Images OFF in the Background Image section

Confirmed Show Sponsored Images toggle is not displayed in yellow

image

@rebron
Copy link
Collaborator

rebron commented Jun 9, 2022

@wadehrarshpreet Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants