We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create_dist does not work
yarn run create_dist
$ yarn create_dist yarn run v1.6.0 $ node ./scripts/commands.js create_dist update branding... gn gen <redacted>/src/out/Release --args="root_extra_deps=[\"//brave\"] is_component_build=false proprietary_codecs=true ffmpeg_branding=\"Chrome\" enable_nacl=false enable_widevine=true target_cpu=\"x64\" is_official_build=true is_debug=false dcheck_always_on=false brave_channel=undefined brave_google_api_key=\"AIzaSyAQfxPJiounkhOjODEO5ZieffeBv6yft2Q\" brave_google_api_endpoint=\"https://www.googleapis.com/geolocation/v1/geolocate?key=\" brave_product_name=\"Brave\" brave_project_name=\"brave\" brave_version_major=\"1\" brave_version_minor=\"0\" brave_version_build=\"0\" mac_signing_identifier=\"\" cc_wrapper=\"<redacted>/src/brave/script/redirect-cc.py\" " ERROR at the command-line "--args":1:234: Undefined identifier root_extra_deps=["//brave"] is_component_build=false proprietary_codecs=true ffmpeg_branding="Chrome" enable_nacl=false enable_widevine=true target_cpu="x64" is_official_build=true is_debug=false dcheck_always_on=false brave_channel=undefined brave_google_api_key="AIzaSyAQfxPJiounkhOjODEO5ZieffeBv6yft2Q" brave_google_api_endpoint="https://www.googleapis.com/geolocation/v1/geolocate?key=" brave_product_name="Brave" brave_project_name="brave" brave_version_major="1" brave_version_minor="0" brave_version_build="0" mac_signing_identifier="" cc_wrapper="<redacted>/src/brave/script/redirect-cc.py" ^-------- null null error Command failed with exit code 1. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Always
current master branch
This is caused by the brave_channel=undefined in the gn gen command.
brave_channel=undefined
The text was updated successfully, but these errors were encountered:
Add channel param to create_dist
f6adb64
Fixes brave#227
e749917
No branches or pull requests
Description
create_dist does not work
Steps to Reproduce
yarn run create_dist
Actual result:
Reproduces how often:
Always
Brave version (about:brave info)
current master branch
Additional Information
This is caused by the
brave_channel=undefined
in the gn gen command.The text was updated successfully, but these errors were encountered: