Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Omaha (Brave's auto-updater on Windows) to 1.3.36.131 #23047

Closed
mherrmann opened this issue May 25, 2022 · 9 comments · Fixed by brave/brave-core#13461
Closed

Update Omaha (Brave's auto-updater on Windows) to 1.3.36.131 #23047

mherrmann opened this issue May 25, 2022 · 9 comments · Fixed by brave/brave-core#13461

Comments

@mherrmann
Copy link

mherrmann commented May 25, 2022

Description

Google released a new upstream version of this technology. We should update Brave to it as well to get the latest fixes.

Test plan

This change has the potential to break Brave's installers and entire update fleet on Windows. It is therefore very important to re-test these features once this issue is resolved. Please see brave/brave-core#11096 for a test plan.

Roll-out strategy

Please see brave/brave-core#11096

@MadhaviSeelam
Copy link

MadhaviSeelam commented Jun 22, 2022

Verification PASSED using

Brave | 1.41.74 Chromium: 103.0.5060.53 (Official Build) beta (64-bit)
-- | --
Revision | a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853}
OS | Windows 11 Version 21H2 (Build 22000.739)

Windows 11 x64

Pre-requisite steps (Please note these steps are described in the "Cleaning up after a test" in https://github.com/brave/brave-core/pull/11096 with additional details)
  1. Uninstall all the brave version (all channels Dev, Release, Beta and Nightly) via Control panel
  2. Remove all the local profile folders from %LOCALAPPDATA%\BraveSoftware
  3. Go to C:\Program Files (x86)\BraveSoftware\update path and observe that Update folder is still available and updater version 1.3.361.113 is still shown
  4. Open RegEdit and navigate to Computer\HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\BraveSoftware\Update and ensure Omaha updater version is 1.3.361.113
  5. Open command prompt with Admin privileges and run the command "C:\Program Files (x86)\BraveSoftware\Update\BraveUpdate.exe" /uninstall
  6. Go to C:\Program Files (x86)\BraveSoftware path and observe that the update folder is removed
  7. Open RegEdit and navigate to Computer\HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\BraveSoftware\Update and ensure Omaha updater version 1.3.361.113 is removed from the registry
  8. If the registry key isn't empty in steps 6 and 7 then kill all instances of BraveUpdate.exe, BraveCrashHandler.exe, BraveCrashHandler64.exe in the Task Manager
  9. Steps 6 and 7 indicate that the Omaha updater is completely uninstalled
registryscreenshotfor13361113

Test Case 1. Verify installers and auto-updater work on a clean profile

Case 1: Verify Omaha updater version when 1.41.x is installed with standalone installer with admin privileges_PASSED

StandaloneSetup.exe

Steps:

  1. Run the steps 1 to 7 from Pre-requisite steps
  2. Download BraveBrowserStandaloneBetaSetup.exe and install the standalone binary 1.41.x (1.41.72) with admin privileges and ensured that standalone installer installed successfully
  3. Confirmed that the new Omaha updater 1.3.36.131 is shown in the registry as expected
  4. Confirmed new Omaha updater version 1.3.36.131 is shown in C:\Program Files (x86)\BraveSoftware\Update
  5. Uninstall the 1.41.72 from control panel and remove the profile folder from the %LOCALAPPDATA%\BraveSoftware
  6. Install the 1.41.72 again and confirmed that the brave installed successfully
  7. Go to brave://settings/help and wait for the update and and click on the Relaunch
  8. Confirmed that brave is upgraded to latest public version 1.41.74
  9. Verified updater's pv value to be 1.3.361.131 in the registry at 'Computer\HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\BraveSoftware\Update\Clients{B131C935-9BE6-41DA-9599-1F776BEB8019}'
Step 4 Step 3 Step7 Step8 Step9 Ex1
image image image image image image
Case 2: Download and install stub installer binary 1.41.x with admin privileges_PASSED

Setup.exe

  1. Run steps 1 & 2 from above Pre-requisite steps section
  2. Install 1.41.74 stub installer BraveBrowserBetaSetup.exe with admin privileges and ensured that brave is installed successfully
  3. Go to brave://settings/help and verify public release version is shown
  4. Also verified latest updater '1.3.36.131` fetched from the Omaha server as expected
  5. Verified updater's pv value to be 1.3.361.131 in the registry at 'Computer\HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\BraveSoftware\Update\Clients{B131C935-9BE6-41DA-9599-1F776BEB8019}'
Step 3 Step 4 Step 5 Reg
image image image image
Case 3: Download and install standalone silent installer binary 1.41.x_PASSED

StandaloneSilentSetup.exe

  1. Run steps 1 & 2 from above Pre-requisite steps section
  2. Install 1.41.72 standalone silent installer BraveBrowserStandaloneSilentBetaSetup.exe
  3. Ensured that brave is installed in silent mode (Installer modal/UAC is NOT shown on the UI) and ensured that correct version details are shown brave://settings/help
  4. Verified updater's pv value to be 1.3.361.131 in the registry at Computer\HKEY_CURRENT_USER\Software\BraveSoftware\Update\Clients\{B131C935-9BE6-41DA-9599-1F776BEB8019}
  5. Go to brave://settings/help and wait for the update and and click on the Relaunch
  6. Confirmed that brave is upgraded to latest public version 1.41.74

Step3|Step 4|Step 6
---|---|---|---
image|image|image

Test Case 2. Verify installers and auto-updater works on an upgrade profile

Case 1:Verify the Omaha updater version in an upgraded profile (Install 1.39.96 ->upgrade to 1.41.x) This testcase verifies update from current updater (1.3.361.113) to latest version (1.3.361.133)

Steps:

  1. Run steps 1-7 from Pre-requisite steps to uninstall existing Omaha version
  2. Install the BraveBrowserStandaloneBetaSetup.exe build version1.39.96 (build before the Omaha updater change 1.3.361.131)
  3. Confirmed build is installed successfully, and version details are shown correctly in brave://settings/help
  4. Confirmed that the old Omaha updater 1.3.361.113 is shown in the registry as expected
  5. Confirmed old Omaha updater version 1.3.361.113 is shown in C:\Program Files (x86)\BraveSoftware\Update
  6. Go to brave://settings/help and wait for update and click on Relaunch and ensured brave is updated to the latest public beta version 1.41.74
  7. After upgrade, Omaha version still shows 1.3.361.113 as expected
Step2-Logs Step3 Step4 Step5 Step6 step7
image image image image image after upgrade - fiddler shows still 113

Updater Validation

Steps

  1. Connect to VPN to be able to access the staging update server.
  2. To test, open https://updates.brave.com/ and to view a 404 error, which means you have access.)
  3. Configure your machine to pull updates from staging by setting the registry string value Computer\HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\BraveSoftware\UpdateDev\url to https://updates.brave.com/service/update2.
  4. Kill all instances of BraveUpdate.exe, BraveCrashHandler.exe and BraveCrashHandler64.exe.
  5. Delete the registry value HKLM\Software\Wow6432Node\BraveSoftware\Update\LastChecked (or HKCU in case of a per-user installation) - if it exists.
  6. Run BraveSoftwareUpdateTaskMachineUA from the Windows Task Scheduler. Refresh with F5 until the task has ended.
  7. Confirmed updater got updated to latest version which is 1.3.133
Ex1 Ex2 Ex3
image image image
Case 2:Verify the Omaha updater version in an upgraded profile (Install 1.39.96 ->upgrade to 1.41.x) This test case has been verified after staging has been reverted from 1.3.361.133 to 1.3.361.131
  1. Follow same test steps as in Case 1
  2. Install the BraveBrowserStandaloneBetaSetup.exe build version1.39.96 and upgrade to 1.41.74
  3. Confirmed updater got updated to latest version which is 1.3.131
Ex1 Ex2 Ex3
image image image
Case 3:Verify the Omaha updater version in an upgraded profile (Install 1.39.96 ->upgrade to 1.41.x) for `standalone silent installer`

Have tested with 1.36.39 Nightly as well

  1. Run steps 1-7 from Pre-requisite steps to uninstall existing Omaha version
  2. Install the standalone silent installer - BraveBrowserStandaloneSilentBetaSetup.exe (1.39.96)
  3. Confirmed build is installed successfully, and version details are shown correctly in brave://settings/help
  4. Confirmed that the old Omaha updater 1.3.361.113is shown in the registry as expected
  5. Confirmed registry shows Brave version details `1.39.96'
  6. Go to brave://settings/help and wait for update and click on Relaunch and ensured brave is updated to the latest public beta version 1.41.82
  7. After upgrade, Omaha version still shows 1.3.361.113 as expected
  8. Configure your machine to pull updates from staging by setting the registry string value Computer\HKEY_LOCAL_MACHINE\Software\BraveSoftware\UpdateDev\url to https://updates.brave.com/service/update2
  9. Kill all instances of BraveUpdate.exe, BraveCrashHandler.exe and BraveCrashHandler64.exe
  10. Delete the registry value Computer\HKEY_CURRENT_USER\Software\BraveSoftware\Update\LastChecked if it exists.
  11. Run BraveSoftwareUpdateTaskUser from the Windows Task Scheduler.
  12. Confirmed updater got updated to latest version which is 1.3.131
Step 3 Step 4 Step5 Step 6 Step 6A Step 7 Step 8 Step 8
step1 step2 step2 step1 step1 step1 step1 step1
Case 4: Install standalone installer 1.40.x and upgrade the profile to 1.41.x_PASSED
  1. Install standalone beta installer 1.40.86
  2. Go to brave://settings/help and wait for the update and click on Relaunch
  3. Confirmed that brave is upgraded to 1.41.74 public released version
1.40.86 1.41.74
image image
Case 5: Install standalone installer 1.40.x and upgrade the profile to 1.41.x test channel_PASSED
  1. Install 1.40.86 standalone beta installer
  2. Confirmed brave 1.40.86 installed successfully
  3. Install the test channel BraveBrowserBetaSetup-64-be-test
  4. Go to brave://settings/help and wait for the update and click on Relaunch
  5. Confirmed that brave is upgraded to 1.41.79 test channel
1.40.86 1.41.79
image image
Case 6: Verify the Omaha updater version in an upgraded profile (Install 1.39.96 ->upgrade to 1.41.x)
  1. Run steps 1-7 from Pre-requisite steps to uninstall existing Omaha version
  2. Install 1.39.96 standalone installer
  3. Confirmed build is installed successfully, and version details are shown correctly in brave://version
  4. Close the browser
  5. Configured my machine to pull updates from staging by setting the registry string value Computer\HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\BraveSoftware\UpdateDev\url to https://updates.brave.com/service/update2.
  6. Killed all instances of BraveUpdate.exe, BraveCrashHandler.exe and BraveCrashHandler64.exe.
  7. Delete the registry value HKLM\Software\Wow6432Node\BraveSoftware\Update\LastChecked - if it exists.
  8. Run BraveSoftwareUpdateTaskMachineUA from the Windows Task Scheduler. Refresh with F5 until the task has ended.
  9. Confirmed updater got updated to latest version which is 1.3.131 in the registry
  10. Relaunch the browser and go to brave://settings/help
  11. Brave got updated to latest public release version 1.41.86
ex1 ex2 ex3 ex4
image image image image

Test Case 3. Verify installers and auto-updater work when the user declines the admin privileges in UAC

Case 1: Verify standalone installer can be installed without admin privileges and updater works_PASSED
  1. Install 1.41.72 beta standalone installer
  2. Decline the admin privileges in UAC while installing the setup
  3. Confirmed that Brave-Browser-Beta folder gets created under the registry path Computer\HKEY_CURRENT_USER\SOFTWARE\BraveSoftware\
  4. Confirmed 1.41.72 beta standalone installer is installed successfully
  5. Go to brave://settings/help and wait for the update and click on Relaunch
  6. Confirmed that the brave is upgraded to 1.41.74 beta public released version
  7. Fiddler logs show correct version
  8. Verified updater's pv value to be 1.3.361.131 in the registry at 'Computer\HKEY_CURRENT_USER\Software\BraveSoftware\Update\Clients{B131C935-9BE6-41DA-9599-1F776BEB8019}'
Step3 Step5 Step6 Step 7 Step8
image image image image image
Case 2: Verify stub installer can be installed without admin privileges_PASSED
  1. Install 1.41.72 beta stub installer
  2. Decline the admin privileges in UAC while installing the setup
  3. Confirmed 1.41.74 public released beta version is installed
  4. Verified updater's pv value to be 1.3.361.131 in the registry at 'Computer\HKEY_CURRENT_USER\Software\BraveSoftware\Update\Clients{B131C935-9BE6-41DA-9599-1F776BEB8019}'
Step 3 Step 4
image image

Test Case 4: Verify Install and re-install with old and new binaries

Case 1: Verify standalone installer can be installed and re-installed with the same version_PASSED * `StandaloneBetaSetup.exe`
  1. Install 1.41.74 standalone installer
  2. Re-install same version
  3. Ensured two brave windows are opened with the same version
  4. Go to brave://settings/help
  5. Confirmed correct version shown on both windows
  6. Fidler logs show correct omaha version: 1.3.361.131
First_Install Re_Install logs
image image image
Case 2: Verify stub installer can be installed and re-installed with newer and older versions_PASSED `SetupBeta.exe`
  1. Install 1.41.72 beta stub installer
  2. Re-install with older version 1.40.100 beta stub installer
  3. Go to brave://settings/help and confirmed that the 1.41.74 public release version is shown
  4. Go to brave://settings/help and confirmed that 1.41.74 public release version is shown
  5. Ensured two brave windows are opened with the same version

Step 3|Step 4|Step 5
---|---|---|---
image|image|image

Case 3: Verify standalone silent installer can be installed and reinstalled with older and newer versions_PASSED
  1. Install 1.40.99 standalone silent installer
  2. Go to brave://settings/help and wait for the update and click on Relaunch
  3. Confirmed that brave is updated to 1.41.x public release version
  4. Install 1.41.74 standalone silent installer
  5. Go to brave://settings/help and confirmed that the 1.41.74 public release version is shown
Step3 Step4 Step5
Step3 Step4 Step5

Test Case 5. Install quite older installers and check update works correctly

Case 1: Install 1.37.x and ensure upgrade works_PASSED
  1. Install 1.37.86 beta standalone installer
  2. Go to brave://settings/help and wait for update and click on Relaunch
  3. Confirmed 1.41.74 public released version is installed
1.37.86 1.41.74
Step3 Step3
Case 2: Install 1.34.x and ensure upgrade works_PASSED
  • Install 1.34.50 beta stub installer
  • Go to brave://settings/help and confirmed 1.41.74 public release version is shown

image

Case 3: Install 1.30.x and ensure upgrade works_PASSED
  • Install 1.30 .59 beta build
  • Go to brave://settings/help and wait for the update and click on Relaunch
  • Confirmed 1.41.74 public released version is installed
1.30.59 1.41.74
Step3 <Step3
Case 4: Install 1.22.x and ensure upgrade works_PASSED
  1. Install 1.22.55 beta build
  2. Go to brave://settings/help and wait for the update and click Relaunch
  3. Confirmed 1.41.74 public released version is installed
1.22.55 1.41.x
Step3 Step3

Test Case 6. Verify that install brave works when the Internet is disconnected

Case 1: Verify standalone installer can be installed when the network is disconnected_PASSED
  1. Install 1.41.74 beta standalone installer
  2. Confirmed standalone installer is installed successfully and version details are shown correctly
  3. Go to brave://settings/help and ensured update fails which is expected since network should be connected
    to pull the Omaha version
image
Case 2: Verify standalone silent installer can be installed when the network is disconnected_PASSED
  1. Install 1.41.74 beta standalone silent installer
  2. Confirmed standalone silent installer is installed successfully and version details are shown correctly
  3. Go to brave://settings/help and ensured update fails which is expected since network should be connected
    to pull the Omaha version
image
Case 3: Verify stub installer can't be installed when the network is disconnected_PASSED
  1. Download 1.41.72 beta stub installer
  2. disconnect network/wifi
  3. Deny UAC
  4. Unable to install the installer which is expected as to pull the Omaha version network needs to be connected
image

Test Case 7. Verify install and re-install different installers (e.g one is standalone and the other is stub/silent)

Case 1: Install standalone installer 1.40.x and upgrade it by 1.41.x stub installer_PASSED
  1. Clean profile 1.40.86 beta standalone installer
  2. Install standalone installer and confirmed 1.40.86 is installed successfully
  3. Upgrade the profile by 1.41.74 beta stub installer
  4. Confirmed that the 1.41.74 public releases version is installed successfully
1.40.86 1.41.74
image image
Case 2: Install standalone silent installer 1.40.x and upgrade it by 1.41.x stub installer without admin privileges_PASSED
  1. Clean profile 1.40.82 beta silent standalone installer
  2. Install the standalone silent installer and confirmed 1.40.x is installed successfully
  3. Upgrade the profile by 1.41.74 beta stub installer while installing decline the admin privileges
  4. Go to brave://settings/help and click on Relaunch
  5. Confirmed that the 1.41.74 beta public releases version is installed successfully
1.40.86 1.41.74
image image
Case 3: Install standalone silent installer 1.40.x and then auto upgrade_PASSED
  1. Clean profile 1.40.88 beta standalone silent installer
  2. Go to brave://settings/help and wait for the update and click on Relaunch
  3. Confirmed that the 1.41.74 beta public release version is installed successfully
1.40.x 1.41.74
image image

@MadhaviSeelam
Copy link

MadhaviSeelam commented Jun 27, 2022

@mherrmann Seeing couple of Updating the updater issues:

Issue 1: Updater is not updating to correct version (1.36.131) with Standalone silent installer

  1. Install standalone silent installer (1.39.96)
  2. Have followed the test steps from Case 1 Update Omaha (Brave's auto-updater on Windows) to 1.3.36.131 #23047 (comment)
  3. Run BraveSoftwareUpdateTaskMachineUA from the Windows Task Scheduler
  4. I am seeing an error `The system cannot find the file specified. (0x80070002)'
Ex1 Ex2
image image

NOTE: Standalone installer working as expected and I got the correct updater version 1.361.131 following Case 1 - #23047 (comment)

Issue 2: Update notifications
Brave is not updating to latest public release version and not seeing Brave Update button

  1. Uninstall existing Omaha version
  2. Install 1.39.96 standalone installer
  3. Confirmed build is installed successfully, and version details are shown correctly in brave://version
  4. Close the browser
  5. Configured my machine to pull updates from staging by setting the registry string value Computer\HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\BraveSoftware\UpdateDev\url to https://updates.brave.com/service/update2.
  6. Killed all instances of BraveUpdate.exe, BraveCrashHandler.exe and BraveCrashHandler64.exe.
  7. Delete the registry value HKLM\Software\Wow6432Node\BraveSoftware\Update\LastChecked - if it exists.
  8. Run BraveSoftwareUpdateTaskMachineUA from the Windows Task Scheduler. Refresh with F5 until the task has ended.
  9. Confirmed updater got updated to latest version which is 1.3.131 in the registry
  10. Relaunch the browser and go to brave://settings/help
  11. Brave did NOT get updated to latest public release version
  12. Page shows older version 1.39.86
ex1 ex2 ex3
image image image

cc: @brave/qa-team

@mherrmann
Copy link
Author

@MadhaviSeelam

Issue 1: Where did you see that error? I do see in the screenshot Ex1 that you have two copies of the updater installed: A copy just for your current Windows user and a copy for the entire machine. Which Case 1 are you referring to? There are multiple Case 1s mentioned in the comment you linked to.

Issue 2: The latest Brave version on the staging server is 1.36.39. Once you've received the latest updater from the staging server, you could delete UpdateDev\url again to try to obtain the latest Brave from prod.

@MadhaviSeelam
Copy link

MadhaviSeelam commented Jun 28, 2022

@mherrmann Issue 2: Thanks for the suggestion. Deleting UpdateDev\url triggered Updates.
One other question was I didn't see Brave Update button as per Update notifications section - brave/brave-core#11096 (comment).
Brave Update button showed up in simulation.

Steps:

1.39.96 1.36.39
image image

@MadhaviSeelam
Copy link

MadhaviSeelam commented Jun 28, 2022

@mherrmann Here are more detailed steps for Issue 1. The issue is scheduler doesn't run and Omaha updates are not happening in case of standalone silent installer only.

  1. Uninstall all brave versions (all channels Dev, Release, Beta and Nightly) via Control panel
  2. Uninstall existing Omaha version
  3. Install standalone silent installer (1.39.96) OR (1.36.39)
  4. Confirmed build is installed successfully, and version details are shown correctly in brave://settings/help
  5. Confirmed that the old Omaha updater 1.3.361.113 is shown in the registry as expected
  6. Go to brave://settings/help and wait for update and click on Relaunch and ensured brave is updated to the latest public beta version 1.41.82
  7. After upgrade, Omaha version still shows 1.3.361.113 as expected
  8. Configure your machine to pull updates from staging by setting the registry string value Computer\HKEY_CURRENT_USER\Software\BraveSoftware\UpdateDev\url to https://updates.brave.com/service/update2
  9. Kill all instances of BraveUpdate.exe, BraveCrashHandler.exe and BraveCrashHandler64.exe
  10. Delete the registry value Computer\HKEY_CURRENT_USER\Software\BraveSoftware\Update\LastChecked - if it exists
  11. Run BraveSoftwareUpdateTaskMachineUA from the Windows Task Scheduler.

Actual Results: When I try to run the scheduler, nothin happens and eventually I see this error The system cannot find the file specified in the line item for BraveSoftwareUpdateTaskMachineUA

Ex1 Ex2 Ex3
image image image

@mherrmann
Copy link
Author

mherrmann commented Jun 29, 2022

@MadhaviSeelam Issue 2: I think the Brave Update button only appears after some time. I wouldn't expect it to show up immediately.

Issue 1:

Omaha can be installed just for the current user, or for the entire machine. If it's installed for the current user only, then you get BraveSoftwareUpdateTaskUser... in the Task Scheduler, registry entries in HKEY_CURRENT_USER\... and Omaha's files in %LOCALAPPDATA%. On the other hand, if it's installed for the entire machine, then you get BraveSoftwareUpdateTaskMachine... in the Task Scheduler, registry entries in HKEY_LOCAL_MACHINE\... and Omaha's files in C:\Program Files (x86).

The steps you posted mention HKEY_CURRENT_USER - which would be for a per-user install of Omaha - but also BraveSoftwareUpdateTaskMachineUA - which is for a machine-wide install. My feeling is that the discrepancies you are experiencing come from the mix of the two. Furthermore, I believe the specific value ...\UpdateDev\url always needs to be set in HKEY_LOCAL_MACHINE.

I believe I would try to remove both the per-user and the per-machine install of Omaha from your system, then repeat any steps with either a machine- or user install. To make sure that all copies of Omaha were successfully uninstalled, you can check that there are no BraveSoftwareUpdate tasks of any kind in the Task Scheduler, there is no Update\Clients key for BraveSoftware in either HKEY_CURRENT_USER or HKEY_LOCAL_MACHINE, and no BraveUpdate.exe in either %LOCALAPPDATA% and C:\Program Files (x86).


Thanks for all your help @mherrmann.

Issue 1: I am still not getting correct updater version 1.3.361.131 when I ran BraveSoftwareUpdateTaskUser... in the scheduler. I've requested @GeetaSarvadnya to take another look as she is validating on Win 10 x64.

Issue 2: I have waited for few minutes for Brave Update button to show but will re-test by waiting a day (check tomorrow morning)


@mherrmann - I looked at your notes again and I missed this part I believe the specific value ...\UpdateDev\urlalways needs to be set inHKEY_LOCAL_MACHINE.. That did the trick. Got the new updater version `1.3.361.133. All good now.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jun 29, 2022

Verification PASSED on

Brave | 1.41.82 Chromium: 103.0.5060.66 (Official Build) beta (64-bit)
-- | --
Revision | 20b1569438a85e631d15e83eb355e3e326e5da6f-refs/branch-heads/5060@{#1066}
OS | Windows 10 Version 21H2 (Build 19044.1766)

Windows 10 x64

1. Verify installers and auto-updater work on a clean profile

Case 1: Verify the Omaha updater version when 1.41.x is installed_PASSED

Pre-requisites:
(Please note these steps are same as remove updater as described in the "Cleaning up after a test" in brave/brave-core#11096 but I have breakdown the steps into detailed)

  1. Uninstall all the brave version (all channels Dev, Release, Beta and Nightly) via Control panel
  2. Remove all the local profile folders from %LOCALAPPDATA%\BraveSoftware
  3. Go to C:\Program Files (x86)\BraveSoftware\update path and observe that Update folder is still available and updater version 1.3.361.131 is still shown
  4. Open RegEdit and navigate to Computer\HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\BraveSoftware\Update and ensure Omaha updater version is 1.3.361.131
  5. Open command prompt with Admin privileges and run the command "C:\Program Files (x86)\BraveSoftware\Update\BraveUpdate.exe" /uninstall
  6. Go to C:\Program Files (x86)\BraveSoftware path and observe that the update folder is removed
  7. Open RegEdit and navigate to Computer\HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\BraveSoftware\Update and ensure Omaha updater version 1.3.361.131 is removed from the registry
  8. If the registry key isn't empty in steps 6 and 7 then kill all instances of BraveUpdate.exe, BraveCrashHandler.exe, BraveCrashHandler64.exe in the Task Manager
  9. Steps 6 and 7 indicate that the Omaha updater is completely uninstalled

Steps:

  • Run the steps 1 to 7 from Pre-requisites
  • Download BraveBrowserStandaloneBetaSetup.exe and install the standalone binary 1.41.x with Admin rights and ensured that standalone installer installed successfully
  • Confirmed that the new Omaha updater 1.3.361.131 is shown in the registry as expected
  • Confirmed new Omaha updater version 1.3.361.131 is shown in C:\Program Files (x86)\BraveSoftware\Update
  • Uninstall the 1.41.x from control panel and remove the profile folder from the %LOCALAPPDATA%\BraveSoftware
  • Install the 1.41.x again and confirmed that the brave installed successfully
  • Go to brave://settings/help and wait for the update and and click on the Relaunch and confirmed that brave is upgraded to latest public version
Example Example Example Example
image image image image
Case 2: Download and install stub installer binary 1.41.x with Admin rights_PASSED
  • Uninstall 1.41.x from the control panel if it's installed
  • Remove local profile folders from %LOCALAPPDATA%\BraveSoftware
  • Install 1.41.x stub installer BraveBrowserBetaSetup.exe and ensured that brave is installed successfully and the latest public released beta version is fetched from the Omaha server as expected
    image
Case 3: Download and install standalone silent installer binary 1.41.x_PASSED
  • Uninstall 1.41.x from the control panel if it's installed
  • Remove local profile folders from %LOCALAPPDATA%\BraveSoftware
  • Install 1.41.x standalone silent installer BraveBrowserStandaloneSilentBetaSetup.exe and ensured that brave is installed in silent mode (Installer modal is NOT shown on the UI) and ensured that correct version details are shown brave://settings/help

2. Verify installers and auto-updater works on upgrade profile

Case 1:Verify the Omaha updater version in an upgraded profile (Install 1.40.86 ->upgrade to 1.41.x)_PASSED

Steps :

  1. Follow the pre-requisites steps from case 1 to uninstall the Omaha
  2. Install the BraveBrowserStandaloneBetaSetup.exe build version1.40.86 (build before the Omaha updater change 1.3.361.131)
  3. Confirmed build is installed successfully and version details are shown correctly in brave://settings/help
  4. Confirmed that the old Omaha updater 1.3.361.113 is shown in the registry as expected
  5. Confirmed old Omaha updater version 1.3.361.113 is shown in C:\Program Files (x86)\BraveSoftware\Update
  6. Go to brave://settings/help and wait for update and click on Relaunch and ensured brave is updated to the latest public beta version 1.41.x

1.40.86

Example Example Example Example
image image (1) image (2) image (3)

Followed the steps from "Background updates" in brave/brave-core#11096 - to verify the Omaha updates silently in the background and confirmed that updater got updated to latest version 1.3.361.131 (followed the steps from #22060 (comment) also)

Case 2: Install standalone installer 1.40.x and upgrade the profile to 1.41.x_PASSED
  • Install standalone beta installer 1.40.x
  • Go to brave://settings/help and wait for the update and click on Relaunch
  • Confirmed that brave is upgraded to 1.41.x public released version
Case 3: Install standalone installer 1.40.x and upgrade the profile to 1.41.x test channel_PASSED
  • Install 1.40.x standalone beta installer
  • Confirmed brave 1.40.x installed successfully
  • Install the test channel BraveBrowserBetaSetup-64-be-test
  • Confirmed that brave is upgraded to 1.41.x test channel
Case 4: Install standalone silent installer 1.40.x and upgrade the profile to 1.41.x_PASSED
  • Install 1.40.x standalone silent beta installer
  • Go to brave://settings/help and wait for the update and click on Relaunch
  • Confirmed that brave is upgraded to 1.41.x public released version

3. Verify installers and auto-updater work when the user declines the Admin rights in UAC

[Note : when brave is installed for the current user (without admin rights) the Brave-Browser-Beta folder gets created under the registry path Computer\HKEY_CURRENT_USER\SOFTWARE\BraveSoftware\ and Omaha new updater version is shown as expected (detailed testing for the current user is covered in https://github.com//issues/22179#issuecomment-1112647799]

Case 1: Verify standalone installer can be installed without admin rights and updater works_PASSED
  • Install 1.41.x beta standalone installer
  • Decline the Admin rights in UAC while installing the setup
  • Confirmed 1.41.x beta standalone installer is installed successfully
  • Go to brave://settings/help and wait for the update and click on Relaunch
  • Confirmed that the brave is upgraded to 1.41.x beta public released version
Case 2: Verify stub installer can be installed without admin rights_PASSED
  • Install 1.41.x beta stub installer
  • Decline the Admin rights in UAC while installing the setup
  • Confirmed 1.41.x public released beta version is installed

4. Verify re-install same installer version works

Case 1: Verify standalone installer can be installed twice and update works_PASSED
  • Install 1.41.x standalone installer twice
  • Ensured two brave windows are opened with the same version
  • Go to brave://settings/help and wait for the update and click on Relaunch
  • Confirmed that brave is updated to 1.41.x public released version
Case 2: Verify stub installer can be installed twice_PASSED
  • Install 1.41.x stub installer twice
  • Ensured two brave windows are opened with the same version
  • Go to brave://settings/help and confirmed that the 1.41.x public release version is shown
Case 3: Verify standalone silent installer can be installed twice and update works_PASSED
  • Install 1.41.x standalone silent installer twice
  • Go to brave://settings/help and wait for the update and click on Relaunch
  • Confirmed that brave is updated to 1.41.x public released version

5. Install quite older installers and check update works correctly

Case 1: Install 1.34.x and ensure upgrade works_PASSED
  • Install 1.34.x beta build
  • Go to brave://settings/help and wait for the update and click on Relaunch
  • Confirmed 1.41.x public released version is installed
1.34.x 1.41.x
image image
Case 2: Install 1.30.x and ensure upgrade works_PASSED
  • Install 1.30.x beta build
  • Go to brave://settings/help and wait for the update and click on Relaunch
  • Confirmed 1.41.x public released version is installed
1.30.x 1.41.x
image image
Case 3: Install 1.29.x and ensure upgrade works_PASSED
  • Install 1.29.x beta build
  • Go to brave://settings/help and wait for the update and click on Relaunch
  • Confirmed 1.41.x public released version is installed
1.29.x 1.41.x
image image
Case 4: Install 1.22.x and ensure upgrade works_PASSED
  • Install 1.22.x beta build
  • Go to brave://settings/help and wait for the update and click on Relaunch
  • Confirmed 1.41.x public released version is installed
1.22.x 1.41.x
image image
Case 5: Install 1.18.x and ensure upgrade works_PASSED
  • Install 1.18.x beta build
  • Go to brave://settings/help and wait for the update and click on Relaunch
  • Confirmed 1.41.x public released version is installed
1.18.x 1.41.x
image image

6. Verify that install brave works when the Internet is disconnected

Case 1: Verify standalone installer can be installed when the network is disconnected_PASSED
  • Install 1.41.x standalone installer
  • Confirmed standalone installer is installed successfully and version details are shown correctly
  • Go to brave://settings/help and ensured update is NOT shown which is expected as to pull the Omaha version network needs to be connected
Case 2: Verify standalone silent installer can be installed when the network is disconnected_PASSED
  • Install 1.41.x standalone silent installer
  • Confirmed standalone silent installer is installed successfully and version details are shown correctly
  • Go to brave://settings/help and ensured update is NOT shown which is expected as to pull the Omaha version network needs to be connected
Case 3: Verify stub installer can't be installed when the network is disconnected_PASSED
  • Try installing the stub installer
  • Unable to install the installer which is expected as to pull the Omaha version network needs to be connected

7. Verify installing a new binary by older binary from different installers (e.g one is standalone and the other is stub/silent)

Case 1: Install standalone installer 1.40.x and upgrade it by 1.41.x stub installer_PASSED
  • Clean profile 1.40.x standalone installer BraveBrowserStandaloneSetup.exe
  • Install the standalone installer and confirmed 1.40.x is installed successfully
  • Upgrade the profile by 1.41.x stub installer BraveBrowserBetaSetup.exe
  • Confirmed that the 1.41.x public releases version is installed successfully
Case 2: Install standalone silent installer 1.40.x and upgrade it by 1.41.x stub installer(decline Admin rights)_PASSED
  • Clean profile 1.40.x standalone installer BraveBrowserStandaloneSilentBetaSetup.exe
  • Install the standalone silent installer and confirmed 1.40.x is installed successfully
  • Upgrade the profile by 1.41.x stub installer BraveBrowserBetaSetup.exe while installing decline the Admin rights
  • Go to brave://settings/help and click on Relaunch
  • Confirmed that the 1.41.x public releases version is installed successfully
Case 3: Install standalone silent installer 1.40.x and then autoupgrade_PASSED
  • Clean profile 1.40.x standalone silent installer BraveBrowserStandaloneSilentBetaSetup.exe
  • Go to brave://settings/help and wait for the update and click on Relaunch
  • Confirmed that the 1.41.x public releases version is installed successfully
Case 4: Install standalone installer 1.40.x and then autoupgrade_PASSED
  • Clean profile 1.40.x standalone installer BraveBrowserStandaloneBetaSetup.exe
  • Go to brave://settings/help and wait for the update and click on Relaunch
  • Confirmed that the 1.41.x public releases version is installed successfully

@LaurenWags
Copy link
Member

LaurenWags commented Jul 6, 2022

Verified on Windows 10 x86 with various 1.41.x versions, primarily the most recent one:

Brave	1.41.91 Chromium: 103.0.5060.114 (Official Build) beta (32-bit) 
Revision	a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS	Windows 10 Version 21H2 (Build 19044.1806)
Pre-requisite steps (largely not used below as I use a fresh VM instead of cleaning up)

Pre-requisites:
(Please note these steps are same as remove updater as described in the "Cleaning up after a test" in brave/brave-core#11096 but I have breakdown the steps into detailed)

  1. Uninstall all the brave version (all channels Dev, Release, Beta and Nightly) via Control panel
  2. Remove all the local profile folders from %LOCALAPPDATA%\BraveSoftware
  3. Go to C:\Program Files (x86)\BraveSoftware\update path and observe that Update folder is still available and updater version 1.3.361.113 is still shown
  4. Open RegEdit and navigate to Computer\HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\BraveSoftware\Update and ensure Omaha updater version is 1.3.361.113
  5. Open command prompt with Admin privileges and run the command "C:\Program Files (x86)\BraveSoftware\Update\BraveUpdate.exe" /uninstall
  6. Go to C:\Program Files (x86)\BraveSoftware path and observe that the update folder is removed
  7. Open RegEdit and navigate to Computer\HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\BraveSoftware\Update and ensure Omaha updater version 1.3.361.113 is removed from the registry
  8. If the registry key isn't empty in steps 6 and 7 then kill all instances of BraveUpdate.exe, BraveCrashHandler.exe, BraveCrashHandler64.exe in the Task Manager
  9. Steps 6 and 7 indicate that the Omaha updater is completely uninstalled

Windows 10 x86

1. Verify installers and auto-updater work on a clean profile

Case 1: Verify the Omaha updater version when 1.41.x is installed - PASSED

Steps:

  1. Run the steps 1 to 7 from Pre-requisites above - N/A as I used a fresh VM with Brave never having been installed
  2. Download BraveBrowserStandaloneBetaSetup32.exe for 1.41.91 and install the standalone binary 1.41.x with Admin rights and ensured that standalone installer installed successfully
  3. Confirmed that the new Omaha updater 1.3.361.131 is shown in the registry as expected
  4. Confirmed new Omaha updater version 1.3.361.131 is shown in C:\Program Files (x86)\BraveSoftware\Update
  5. Uninstall the 1.41.x from control panel and remove the profile folder from the %LOCALAPPDATA%\BraveSoftware
  6. Install the 1.41.x again (installed 1.41.86 this time) and confirmed that the brave installed successfully
  7. Go to brave://settings/help and wait for the update and and click on the Relaunch and confirmed that brave is upgraded to latest public version
Step 3 Step 4 Step 6 Step 7
3 4 6 7

2. Verify installers and auto-updater works on upgrade profile

Case 1:Verify the Omaha updater version in an upgraded profile (Install 1.37.77 ->upgrade to 1.41.x) - PASSED

Steps :

  1. Follow the pre-requisites steps from case 1 to uninstall the Omaha - N/A as I used a fresh VM without Brave ever being installed
  2. Install the BraveBrowserStandaloneBetaSetup32.exe build version 1.37.77 (build before the Omaha updater change 1.3.361.131)
  3. Confirmed build is installed successfully and version details are shown correctly in brave://settings/help
  4. Confirmed that the old Omaha updater 1.3.361.111 is shown in the registry as expected
  5. Confirmed old Omaha updater version 1.3.361.111 is shown in C:\Program Files (x86)\BraveSoftware\Update
  6. Go to brave://settings/help and wait for update and click on Relaunch and ensured brave is updated to the latest public beta version 1.41.x

1.37.77

Step 4 Step 5 Step 6 Step 6
4 5 6a 6b

Worked with Geeta to understand and follow the steps from 1.) #22060 (comment) and then 2.) "Background updates" in brave/brave-core#11096 - to verify the Omaha updates silently in the background and confirmed that updater got updated to latest version 1.3.361.131.

Confirmed Omaha updater version updated from 1.3.361.111 --> 1.3.361.131

Example Example
after after2
Case 2: Download and install stub installer binary 1.41.x with Admin rights - PASSED
  • Uninstall 1.41.x from the control panel if it's installed - N/A as I'm using a fresh VM and Brave has never been installed
  • Remove local profile folders from %LOCALAPPDATA%\BraveSoftware - N/A as I'm using a fresh VM and Brave has never been installed
  • Install 1.41.x stub installer BraveBrowserBetaSetup32.exe and ensured that Brave is installed successfully and latest public released beta version is fetched from the Omaha server as expected
  • Install 1.40.x stub installer BraveBrowserSetup32.exe from brave.com and ensured that Brave is installed successfully and the latest public released versions is fetched from the Omaha server as expected.
. 1.41.x (Beta) 1.40.x (Release)
Brave 1.41.91 Chromium: 103.0.5060.114 (Official Build) beta (32-bit) 1.40.113 Chromium: 103.0.5060.114 (Official Build) (32-bit)
Revision a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124} 1.40.113 Chromium: 103.0.5060.114 (Official Build) (32-bit)
OS Windows 10 Version 21H2 (Build 19044.1806) Windows 10 Version 21H2 (Build 19044.1806)
Case 3: Download and install standalone silent installer binary 1.41.x - PASSED
  • Uninstall 1.41.x from the control panel if it's installed - N/A (fresh VM)
  • Remove local profile folders from %LOCALAPPDATA%\BraveSoftware - N/A (fresh VM)
  • Install 1.41.x standalone silent installer BraveBrowserStandaloneSilentBetaSetup32.exe and ensured that Brave is installed in silent mode (Installer modal is NOT shown on the UI) and ensured that correct version details are shown brave://settings/help
Brave	1.41.91 Chromium: 103.0.5060.114 (Official Build) beta (32-bit) 
Revision	a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS	Windows 10 Version 21H2 (Build 19044.1806)

3. Verify installers and auto-updater work when the user declines the Admin rights in UAC

Case 1: Verify standalone installer can be installed without admin rights and updater works - PASSED
  • Install 1.41.x beta standalone installer
  • Decline the Admin rights in UAC while installing the setup
  • Confirmed 1.41.x beta standalone installer is installed successfully
  • Go to brave://settings/help and wait for the update and click on Relaunch
  • Confirmed that the brave is upgraded to 1.41.x beta public released version

Installed 1.41.86 --> Updated to 1.41.91

Example Example Example Example Example
1 2 3 4 5

4. Verify re-install same installer version works

Case 1: Verify standalone installer can be installed twice and update works - PASSED
  • Install 1.41.x standalone installer twice
  • Ensured two brave windows are opened with the same version
  • Go to brave://settings/help and wait for the update and click on Relaunch
  • Confirmed that brave is updated to 1.41.x public released version
Example Example
A B

5. Install quite older installers and check update works correctly

Case 1: Install 1.30.x and ensure upgrade works - PASSED
  • Install 1.30.x beta build
  • Go to brave://settings/help and wait for update and click on Relaunch
  • Confirmed 1.41.x public released version is installed
1.30.x 1.41.x
A B

6. Verify that install brave works when the Internet is disconnected

Case 1: Verify standalone installer can be installed when the network is disconnected - PASSED
  • Disconnect network and Install 1.41.86 standalone installer
  • Confirmed standalone installer is installed successfully and version details are shown correctly
  • Go to brave://settings/help and ensured update is NOT shown which is expected as to pull the Omaha version network needs to be connected
  • Reconnect the network
  • Confirm upgrade is fetched
  • Confirm successful upgrade
Network disconnected Reconnect Network Upgrade successful
A B C

7. Verify installing a new binary by older binary from different installers (e.g one is standalone and the other is stub/silent)

Case 1: Install standalone installer 1.40.x and upgrade it by 1.41.x stub installer - PASSED
  • Disabled network
  • Clean profile 1.40.x standalone installer BraveBrowserStandaloneSetup32.exe
  • Install the standalone installer and confirmed 1.40.x is installed successfully
  • Close 1.40.x
  • Stop/remove all upgrade processes that are running via Task Manager
  • Reenable network
  • Upgrade the profile by 1.41.x stub installer BraveBrowserBetaSetup32.exe
  • Confirmed that the 1.41.x public releases version is installed successfully
1.40.x 1.40.x 1.41.x 1.41.x
1 2 3 4

@kjozwiak
Copy link
Member

kjozwiak commented Jul 12, 2022

Verification PASSED on Win 8.1 x64 using the following build(s):

Brave | 1.41.95 Chromium: 103.0.5060.114 (Official Build) (64-bit)
--- | ---
Revision | a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS | Windows 8.1 (Build 9600.20402)
Pre-requisite steps (largely not used below as I use a fresh VM instead of cleaning up)

Pre-requisites:
(Please note these steps are same as remove updater as described in the "Cleaning up after a test" in brave/brave-core#11096 but I have breakdown the steps into detailed)

  1. Uninstall all the brave version (all channels Dev, Release, Beta and Nightly) via Control panel
  2. Remove all the local profile folders from %LOCALAPPDATA%\BraveSoftware
  3. Go to C:\Program Files (x86)\BraveSoftware\update path and observe that Update folder is still available and updater version 1.3.361.113 is still shown
  4. Open RegEdit and navigate to Computer\HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\BraveSoftware\Update and ensure Omaha updater version is 1.3.361.113
  5. Open command prompt with Admin privileges and run the command "C:\Program Files (x86)\BraveSoftware\Update\BraveUpdate.exe" /uninstall
  6. Go to C:\Program Files (x86)\BraveSoftware path and observe that the update folder is removed
  7. Open RegEdit and navigate to Computer\HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\BraveSoftware\Update and ensure Omaha updater version 1.3.361.113 is removed from the registry
  8. If the registry key isn't empty in steps 6 and 7 then kill all instances of BraveUpdate.exe, BraveCrashHandler.exe, BraveCrashHandler64.exe in the Task Manager
  9. Steps 6 and 7 indicate that the Omaha updater is completely uninstalled

Windows 8.1 x64

1. Verify installers and auto-updater work on a clean profile

Case 1: Verify the Omaha updater version when 1.41.x is installed - PASSED

Steps:

  1. Run the steps 1 to 7 from Pre-requisites above - N/A as I used a fresh VM with Brave never having been installed
  2. Download BraveBrowserStandaloneBetaSetup.exe for 1.41.95 and install the standalone binary 1.41.x with Admin rights and ensured that standalone installer installed successfully
  3. Confirmed that the new Omaha updater 1.3.361.131 is shown in the registry as expected
  4. Confirmed new Omaha updater version 1.3.361.131 is shown in C:\Program Files (x86)\BraveSoftware\Update
  5. Uninstall the 1.41.x from control panel and remove the profile folder from the %LOCALAPPDATA%\BraveSoftware
  6. Install the 1.41.x again (installed 1.41.86 this time) and confirmed that the brave installed successfully
  7. Go to brave://settings/help and wait for the update and and click on the Relaunch and confirmed that brave is upgraded to latest public version
Step 3 Step 4 Step 6 Step 7
Screen Shot 2022-07-11 at 11 22 22 PM Screen Shot 2022-07-11 at 11 22 40 PM Screen Shot 2022-07-11 at 11 25 03 PM Screen Shot 2022-07-11 at 11 25 50 PM

2. Verify installers and auto-updater works on upgrade profile

Case 1:Verify the Omaha updater version in an upgraded profile (Install 1.37.77 ->upgrade to 1.41.x) - PASSED

Steps :

  1. Follow the pre-requisites steps from case 1 to uninstall the Omaha - N/A as I used a fresh VM without Brave ever being installed
  2. Install the BraveBrowserStandaloneBetaSetup.exe build version 1.37.77 (build before the Omaha updater change 1.3.361.131)
  3. Confirmed build is installed successfully and version details are shown correctly in brave://settings/help
  4. Confirmed that the old Omaha updater 1.3.361.111 is shown in the registry as expected
  5. Confirmed old Omaha updater version 1.3.361.111 is shown in C:\Program Files (x86)\BraveSoftware\Update
  6. Go to brave://settings/help and wait for update and click on Relaunch and ensured brave is updated to the latest public beta version 1.41.x

1.37.77

Step 4 Step 5 Step 6 Step 6
Screen Shot 2022-07-11 at 11 32 37 PM Screen Shot 2022-07-11 at 11 32 54 PM Screen Shot 2022-07-11 at 11 33 31 PM Screen Shot 2022-07-11 at 11 33 44 PM

Used the STR/Cases outlined via 1.) #22060 (comment) and then 2.) "Background updates" in brave/brave-core#11096 - to verify the Omaha updates silently in the background and confirmed that updater got updated to latest version 1.3.361.131.

Confirmed Omaha updater version updated from 1.3.361.111 --> 1.3.361.131

Example Example
Screen Shot 2022-07-12 at 12 06 23 AM Screen Shot 2022-07-12 at 12 06 08 AM
Case 2: Download and install stub installer binary 1.41.x with Admin rights - PASSED
  • Uninstall 1.41.x from the control panel if it's installed - N/A as I'm using a fresh VM and Brave has never been installed
  • Remove local profile folders from %LOCALAPPDATA%\BraveSoftware - N/A as I'm using a fresh VM and Brave has never been installed
  • Install 1.41.x stub installer BraveBrowserSetup-64-r-test.exe and ensured that Brave is installed successfully and latest public released beta version is fetched from the Omaha server as expected
  • Install 1.40.x stub installer BraveBrowserSetup.exe from brave.com and ensured that Brave is installed successfully and the latest public released versions is fetched from the Omaha server as expected.
Brave | 1.40.113 Chromium: 103.0.5060.114 (Official Build) (64-bit)
--- | ---
Revision | a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS | Windows 8.1 (Build 9600.20402)
Brave | 1.41.95 Chromium: 103.0.5060.114 (Official Build) (64-bit)
--- | ---
Revision | a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS | Windows 8.1 (Build 9600.20402)
Case 3: Download and install standalone silent installer binary 1.41.x - PASSED
  • Uninstall 1.41.x from the control panel if it's installed - N/A (fresh VM)
  • Remove local profile folders from %LOCALAPPDATA%\BraveSoftware - N/A (fresh VM)
  • Install 1.41.x standalone silent installer BraveBrowserStandaloneSilentBetaSetup.exe and ensured that Brave is installed in silent mode (Installer modal is NOT shown on the UI) and ensured that correct version details are shown brave://settings/help
Brave | 1.41.95 Chromium: 103.0.5060.114 (Official Build) (64-bit)
--- | ---
Revision | a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS | Windows 8.1 (Build 9600.20402)

3. Verify installers and auto-updater work when the user declines the Admin rights in UAC

Case 1: Verify standalone installer can be installed without admin rights and updater works - PASSED
  • Install 1.41.x beta standalone installer
  • Decline the Admin rights in UAC while installing the setup
  • Confirmed 1.41.x beta standalone installer is installed successfully
  • Go to brave://settings/help and wait for the update and click on Relaunch
  • Confirmed that the brave is upgraded to 1.41.x beta public released version

Installed 1.41.86 --> Updated to 1.41.91

Example Example Example Example Example
Screen Shot 2022-07-12 at 12 22 42 AM Screen Shot 2022-07-12 at 12 22 32 AM Screen Shot 2022-07-12 at 12 23 44 AM Screen Shot 2022-07-12 at 12 24 26 AM Screen Shot 2022-07-12 at 12 24 36 AM

4. Verify re-install same installer version works

Case 1: Verify standalone installer can be installed twice and update works - PASSED
  • Install 1.41.x standalone installer twice
  • Ensured two brave windows are opened with the same version
  • Go to brave://settings/help and wait for the update and click on Relaunch
  • Confirmed that brave is updated to 1.41.x public released version
Example Example
Screen Shot 2022-07-12 at 12 59 02 AM Screen Shot 2022-07-12 at 12 59 31 AM

5. Install quite older installers and check update works correctly

Case 1: Install 1.30.x and ensure upgrade works - PASSED
  • Install 1.30.x beta build
  • Go to brave://settings/help and wait for update and click on Relaunch
  • Confirmed 1.41.x public released version is installed
1.30.x 1.41.x
Screen Shot 2022-07-12 at 1 04 20 AM Screen Shot 2022-07-12 at 1 04 30 AM

6. Verify that install brave works when the Internet is disconnected

Case 1: Verify standalone installer can be installed when the network is disconnected - PASSED
  • Disconnect network and Install 1.41.86 standalone installer
  • Confirmed standalone installer is installed successfully and version details are shown correctly
  • Go to brave://settings/help and ensured update is NOT shown which is expected as to pull the Omaha version network needs to be connected
  • Reconnect the network
  • Confirm upgrade is fetched
  • Confirm successful upgrade
Network disconnected Network disconnected Reconnect Network Upgrade successful
Screen Shot 2022-07-12 at 1 10 26 AM Screen Shot 2022-07-12 at 1 10 36 AM Screen Shot 2022-07-12 at 1 11 29 AM Screen Shot 2022-07-12 at 1 11 37 AM

7. Verify installing a new binary by older binary from different installers (e.g one is standalone and the other is stub/silent)

Case 1: Install standalone installer 1.40.x and upgrade it by 1.41.x stub installer - PASSED
  • Disabled network
  • Clean profile 1.40.x standalone installer BraveBrowserStandaloneSetup.exe
  • Install the standalone installer and confirmed 1.40.x is installed successfully
  • Close 1.40.x
  • Stop/remove all upgrade processes that are running via Task Manager
  • Reenable network
  • Upgrade the profile by 1.41.x stub installer BraveBrowserBetaSetup.exe
  • Confirmed that the 1.41.x public releases version is installed successfully
1.40.x 1.40.x 1.41.x 1.41.x
Screen Shot 2022-07-12 at 1 19 10 AM Screen Shot 2022-07-12 at 1 19 42 AM Screen Shot 2022-07-12 at 1 22 31 AM Screen Shot 2022-07-12 at 1 22 37 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants