Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove P2A protobuf reporting #23146

Closed
rillian opened this issue May 30, 2022 · 2 comments · Fixed by brave/brave-core#14394
Closed

Remove P2A protobuf reporting #23146

rillian opened this issue May 30, 2022 · 2 comments · Fixed by brave/brave-core#14394
Assignees
@rillian
Labels
features/P3A OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.44.x - Release

Comments

@rillian
Copy link

rillian commented May 30, 2022

Description

With #22079 we started sending P2A reports to a new json-format endpoint. Once we're confident the new reports are being correctly ingested we should stop sending the old protobuf-format reports and can remove the associated generation code.
@rillian rillian added OS/Android Fixes related to Android browser functionality OS/Desktop labels May 30, 2022
@rillian rillian self-assigned this May 30, 2022
@rillian rillian mentioned this issue May 30, 2022
Merged
25 tasks
@rillian rillian removed the OS/Android Fixes related to Android browser functionality label Jul 11, 2022
@rillian
Copy link
Author

rillian commented Jul 28, 2022

We're seeing good match with the json data channel, so this issue can go ahead.

rillian added a commit to brave/brave-core that referenced this issue Jul 29, 2022
@rillian
P3A: Stop sending P2A reports in protobuf format.
af2f6af 
Since the p2a-json reporting channel is working well, stop
sending the old protobuf format. The browser should now only
report json-format P2A and P3A messages.

Fixes brave/brave-browser#23146
This was referenced Jul 29, 2022
Merged
Open
@brave-builds brave-builds added this to the 1.44.x - Nightly milestone Jul 29, 2022
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 12, 2022 •
edited
Loading

Verification PASSED on

Brave | 1.44.79 Chromium: 105.0.5195.102 (Official Build) beta (64-bit)
-- | --
Revision | 4c16f5ffcc2da70ee2600d5db77bed423ac03a5a-refs/branch-heads/5195_55@{#4}
OS | Windows 10 Version 21H2 (Build 19044.1889)

https://p3a-json.brave.com/

Example Example
image image (1)

https://p2a-json.brave.com/

Example Example
image image

@kjozwiak kjozwiak mentioned this issue Sep 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rillian rillian

Labels
features/P3A OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.44.x - Release
Development

Successfully merging a pull request may close this issue.

Remove P3A protobuf implementation brave/brave-core
4 participants
@rillian @LaurenWags @GeetaSarvadnya @brave-builds