Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Lotus link clickable under private key info #23531

Closed
srirambv opened this issue Jun 17, 2022 · 2 comments · Fixed by brave/brave-core#13839
Closed

Make Lotus link clickable under private key info #23531

srirambv opened this issue Jun 17, 2022 · 2 comments · Fixed by brave/brave-core#13839
Assignees

Comments

@srirambv
Copy link
Contributor

Description

Make Lotus link clickable under private key info

Steps to Reproduce

  1. Create a Filecoin account
  2. Go to Accounts and select Filecoin account
  3. Select Edit and switch to Private Key
  4. Info text has a link to support document that is not clickable

Actual result:

image

Expected result:

Support links should be clickable

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.42.1 Chromium: 103.0.5060.42 (Official Build) nightly (64-bit)
Revision de0d840bf9439c31bd86bf74f065c31fdf9b208d-refs/branch-heads/5060@{#667}
OS Windows 11 Version 21H2 (Build 22000.739)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @cypt4 @yrliou @jamesmudgett

@kjozwiak
Copy link
Member

The above will require 1.41.76 or higher for 1.40.x verification 👍

@srirambv
Copy link
Contributor Author

Brave 1.41.82 Chromium: 103.0.5060.66 (Official Build) beta (64-bit)
Revision 20b1569438a85e631d15e83eb355e3e326e5da6f-refs/branch-heads/5060@{#1066}
OS ☑️ Linux ☑️ Windows 11 Version 21H2
(Build 22000.708)
☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from
  • Verified Lotus support link now shows as Learn more and is clickable
23531-Linux.mp4
23531-Windows.mp4
23531-macOS.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants