Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imported pinned sites do not display favicons when they become Tips #2355

Closed
LaurenWags opened this issue Dec 4, 2018 · 3 comments · Fixed by brave/brave-core#1020
Closed

Comments

@LaurenWags
Copy link
Member

Description

If you have pinned sites and they are converted to recurring tips, favicons are not displaying.
Note - per discussion in Slack with @NejcZdovc , media publishers will not display favicons but sites should be.

Steps to Reproduce

  1. Have a muon profile with Payments enabled and at least a couple pinned sites set up.
  2. Close muon. Verify no profile exists for release b-c.
  3. Launch b-c with --upgrade-from-muon flag.
  4. Data is imported.
  5. Navigate to Rewards page.

Actual result:

No favicons for sites:
screen shot 2018-12-04 at 11 39 43 am

Expected result:

Sites (except media publishers) should have favicons.

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.57.15 Chromium: 71.0.3578.75 (Official Build) (64-bit)
Revision 06ef00b5279f93f8e0c1e73acedd49d7dcc09767-refs/branch-heads/3578@{#836}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? n/a

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@LaurenWags
Copy link
Member Author

LaurenWags commented Dec 5, 2018

Still not seeing favicons for imported tips:
screen shot 2018-12-05 at 10 21 17 am
Using

Brave 0.57.16 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Mac OS X

cc @NejcZdovc @bsclifton @rebron @kjozwiak

@LaurenWags
Copy link
Member Author

Update - need to visit the sites in Tips panel and then refresh brave://rewards to see the favicons.
screen shot 2018-12-05 at 10 33 23 am

@LaurenWags
Copy link
Member Author

LaurenWags commented Dec 5, 2018

Verified passed with

Brave 0.57.16 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Mac OS X

Verification Passed on

Brave 0.57.17 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Windows 7

image

Verification Passed on

Brave 0.57.17 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Linux

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment