Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grant notification shows up too often (follow up to #1798) #2454

Closed
srirambv opened this issue Dec 11, 2018 · 9 comments · Fixed by brave/brave-core#1132
Closed

Grant notification shows up too often (follow up to #1798) #2454

srirambv opened this issue Dec 11, 2018 · 9 comments · Fixed by brave/brave-core#1132

Comments

@srirambv
Copy link
Contributor

Description

Follow up to #1798. Grant notfication shows up every single time the BR panel button is clicked. This is annoying even while testing. There should be a time out before the notification is shown next.

Steps to Reproduce

  1. Install 0.58.11 and enable rewards
  2. Click on BR panel in URL bar, grant notification is shown
  3. Dismiss notification by clicking ok button and close the panel
  4. Click the BR panel again
  5. And then
    img

Actual result:

https://youtu.be/UYDJNt4FPso

Expected result:

Should not show every time the panel is opened

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta(64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Linux

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    Yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

cc: @NejcZdovc @brave/legacy_qa

@srirambv srirambv added feature/rewards priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/Yes release-notes/exclude QA/Test-Plan-Specified labels Dec 11, 2018
@srirambv srirambv added this to the 1.x Backlog milestone Dec 11, 2018
@LaurenWags
Copy link
Member

Reproduces on macOS

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta(64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Mac OS X

@kjozwiak
Copy link
Member

kjozwiak commented Dec 11, 2018

Reproducible on Win 10 x64 VM as well. Affecting all platforms. Used the following build to reproduce the issue:

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Windows

@kjozwiak
Copy link
Member

Moving to 0.58.x after a quick discussion with @davidtemkin and @NejcZdovc. This might end up annoying folks. The general rule that we take with notifications is that users should only be seeing it once and shouldn't be prompted the same notification over and over.

@kjozwiak kjozwiak modified the milestones: 1.x Backlog, 0.58.x - Beta Dec 12, 2018
@kjozwiak
Copy link
Member

notification

@mandar-brave mandar-brave added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Dec 12, 2018
@mandar-brave
Copy link

mandar-brave commented Dec 12, 2018

@NejcZdovc moving it to P2 based on user feedback and above conversation. We can cap it to once daily if easier (and possible).

cc @davidtemkin @rebron

@NejcZdovc
Copy link
Contributor

@mandar-brave it's already set to daily. There is just an additional check on the panel. So the easiest thing to do is just remove check from the panel and that is it

@davidtemkin
Copy link

@NejcZdovc logic should be that user is notified once per grant; red dot only appears once for that grant.

However, the check still needs to be there, right? we do want to show the notification if a previously unseen grant is available when user clicks (i.e., the browser hasn't done the daily check since the new grant went live). But only once for one grant, never bring back notification for the same grant.

@bbondy
Copy link
Member

bbondy commented Dec 18, 2018

Please use project boards to indicate priority, we only use milestones for tracking closed issues.

@bbondy bbondy modified the milestones: 0.58.x - Release, 1.x Backlog Dec 18, 2018
NejcZdovc added a commit to brave/brave-core that referenced this issue Dec 20, 2018
@NejcZdovc NejcZdovc modified the milestones: 1.x Backlog, 0.60.x - Dev Dec 20, 2018
@NejcZdovc NejcZdovc modified the milestones: 0.60.x - Dev, 0.59.x - Beta Dec 22, 2018
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 24, 2018

Verification passed on

Brave 0.59.12 Chromium: 72.0.3626.17 (Official Build) beta (64-bit)
Revision 08d2140079f8db14c9eb885a803d231b1a30e817-refs/branch-heads/3626@{#315}
OS Windows

Verification passed on

Brave 0.59.12 Chromium: 72.0.3626.17 (Official Build) beta (64-bit)
Revision 08d2140079f8db14c9eb885a803d231b1a30e817-refs/branch-heads/3626@{#315}
OS Linux

Verification PASSED on macOS 10.14.2 x64 using the following build:

Brave 0.59.14 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants