Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Aurora modal text #24923

Closed
muliswilliam opened this issue Aug 24, 2022 · 2 comments · Fixed by brave/brave-core#14798
Closed

Update Aurora modal text #24923

muliswilliam opened this issue Aug 24, 2022 · 2 comments · Fixed by brave/brave-core#14798
Assignees
@muliswilliam
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.44.x - Release

Comments

@muliswilliam
Copy link

muliswilliam commented Aug 24, 2022 •
edited
Loading

Update Aurora Modal tex as outlined in this comment.
@muliswilliam muliswilliam self-assigned this Aug 24, 2022
@muliswilliam muliswilliam mentioned this issue Aug 24, 2022
Merged
25 tasks
@brave-builds brave-builds added this to the 1.45.x - Nightly milestone Aug 31, 2022
@brave-builds brave-builds mentioned this issue Sep 2, 2022
Merged
7 tasks
@kjozwiak
Copy link
Member

kjozwiak commented Sep 7, 2022

The above requires 1.44.78 or higher for 1.44.x verification 👍

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.44.86 Chromium: 105.0.5195.127 (Official Build) beta (64-bit)
Revision 912488396852bf658ab32465980c0b93a3c27a83-refs/branch-heads/5195@{#1109}
OS Linux
  • Verified steps from PR
  • Verified Bridge to Aurora modal is shown every time user clicks on it
  • Verified Learn more about using Rainbow Bridge opens https://doc.aurora.dev/bridge/bridge-overview/
  • Verified Learn more about mitigating risk on Rainbow Bridge opens https://rainbowbridge.app/approvals
  • Verified when user checks Do not show this again it doesn't show the prompt after that
24923-Linux.mp4

Verification passed on

Brave 1.44.86 Chromium: 105.0.5195.127 (Official Build) beta (64-bit)
Revision 912488396852bf658ab32465980c0b93a3c27a83-refs/branch-heads/5195@{#1109}
OS Windows 11 Version 21H2 (Build 22000.795)
  • Verified steps from PR
  • Verified Bridge to Aurora modal is shown every time user clicks on it
  • Verified Learn more about using Rainbow Bridge opens https://doc.aurora.dev/bridge/bridge-overview/
  • Verified Learn more about mitigating risk on Rainbow Bridge opens https://rainbowbridge.app/approvals
  • Verified when user checks Do not show this again it doesn't show the prompt after that
24923-Windows.mp4

Verification passed on

Brave 1.44.86 Chromium: 105.0.5195.127 (Official Build) beta (arm64)
Revision 912488396852bf658ab32465980c0b93a3c27a83-refs/branch-heads/5195@{#1109}
OS macOS Version 12.4 (Build 21F79)
  • Verified steps from PR
  • Verified Bridge to Aurora modal is shown every time user clicks on it
  • Verified Learn more about using Rainbow Bridge opens https://doc.aurora.dev/bridge/bridge-overview/
  • Verified Learn more about mitigating risk on Rainbow Bridge opens https://rainbowbridge.app/approvals
  • Verified when user checks Do not show this again it doesn't show the prompt after that
224923-macOS.mov

@kjozwiak kjozwiak mentioned this issue Sep 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muliswilliam muliswilliam

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.44.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): Update aurora modal text brave/brave-core
4 participants
@kjozwiak @srirambv @brave-builds @muliswilliam