-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(wallet): Update aurora modal text #14798
Conversation
..._wallet_ui/components/desktop/popup-modals/bridge-to-aurora-modal/bridge-to-aurora-modal.tsx
Outdated
Show resolved
Hide resolved
d58abd8
to
27be3cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@muliswilliam — discussing in Slack thread with @Pavneet-Sing @jamesmudgett @nuo-xu. I believe they might ping about some updated copy for that modal. |
A Storybook has been deployed to preview UI for the latest push |
The UX and UI of the aurora dialog needs to be updated for desktop
|
5621e2d
to
20ea4c9
Compare
@rmcfadden3 I have updated the UI. |
20ea4c9
to
7d6d3c0
Compare
907cc73
to
eef59da
Compare
A Storybook has been deployed to preview UI for the latest push |
eef59da
to
75db07e
Compare
A Storybook has been deployed to preview UI for the latest push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@muliswilliam — the text of the modal looks good. One design nit: looks like uneven spacing between the top of the CTA button and the bottom of it. Should this button be vertically centered between the "Don't show this again" box and the two strings of hyperlinked text?
Verification passed on
14798.mp4 |
This PR updates aurora modal text and minor style changes. The text is from this comment
Resolves brave/brave-browser#24923
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Screen.Recording.2022-08-26.at.12.09.59.mov