Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): Update aurora modal text #14798

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

muliswilliam
Copy link
Contributor

@muliswilliam muliswilliam commented Aug 24, 2022

This PR updates aurora modal text and minor style changes. The text is from this comment

Resolves brave/brave-browser#24923

Submitter Checklist:

  • I confirm that no security/privacy review is needed
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Screen.Recording.2022-08-26.at.12.09.59.mov

@muliswilliam muliswilliam requested review from a team as code owners August 24, 2022 14:51
@github-actions github-actions bot added CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/storybook-url Deploy storybook and provide a unique URL for each build labels Aug 24, 2022
Copy link
Contributor

@Douglashdaniel Douglashdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rmcfadden3
Copy link

@muliswilliam — discussing in Slack thread with @Pavneet-Sing @jamesmudgett @nuo-xu. I believe they might ping about some updated copy for that modal.

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@Pavneet-Sing
Copy link

The UX and UI of the aurora dialog needs to be updated for desktop

@muliswilliam
Copy link
Contributor Author

@rmcfadden3 I have updated the UI.

@muliswilliam muliswilliam requested a review from a team as a code owner August 26, 2022 09:41
@muliswilliam muliswilliam force-pushed the fix-update-aurora-modal-text branch 3 times, most recently from 907cc73 to eef59da Compare August 29, 2022 07:26
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

package-lock.json Outdated Show resolved Hide resolved
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link

@rmcfadden3 rmcfadden3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@muliswilliam — the text of the modal looks good. One design nit: looks like uneven spacing between the top of the CTA button and the bottom of it. Should this button be vertically centered between the "Don't show this again" box and the two strings of hyperlinked text?

@muliswilliam muliswilliam merged commit b42a1dd into master Aug 31, 2022
@muliswilliam muliswilliam deleted the fix-update-aurora-modal-text branch August 31, 2022 08:36
@github-actions github-actions bot added this to the 1.45.x - Nightly milestone Aug 31, 2022
@muliswilliam muliswilliam restored the fix-update-aurora-modal-text branch September 2, 2022 06:19
brave-builds pushed a commit that referenced this pull request Sep 2, 2022
@muliswilliam muliswilliam deleted the fix-update-aurora-modal-text branch September 2, 2022 07:05
@srirambv
Copy link
Contributor

srirambv commented Sep 2, 2022

Verification passed on

Brave 1.45.22 Chromium: 105.0.5195.68 (Official Build) nightly (64-bit)
Revision ad13e82529051bac6a0e65f455e6d7a1e5fd7938-refs/branch-heads/5195@{#903}
OS Linux
  • Verified steps from PR
  • Verified Bridge to Aurora modal is shown everytime user clicks on it
  • Verified Learn more about using Rainbow Bridge opens https://doc.aurora.dev/bridge/bridge-overview/
  • Verified Learn more about mitigating risk on Rainbow Bridge opens https://rainbowbridge.app/approvals`
  • Verified when user checks Do not show this again it doesn't show the prompt after that
14798.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Aurora modal text
7 participants