Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ads are not blocked when --enable-features is used on production #26889

Closed
btlechowski opened this issue Nov 21, 2022 · 3 comments · Fixed by brave/brave-core#17717
Closed

Ads are not blocked when --enable-features is used on production #26889

btlechowski opened this issue Nov 21, 2022 · 3 comments · Fixed by brave/brave-core#17717

Comments

@btlechowski
Copy link

We should block ads when --enable-features is used on production. This is a regression.

Steps to Reproduce

  1. Clean profile
  2. Run Brave with
--enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6,"*/bat_ads/*"=6 --enable-features="UserActivity:threshold/0.0"
  1. Enable rewards and ads
  2. view an ad

Actual result:

able to view an ad

[7930:7930:1121/064756.104224:VERBOSE1:eligible_notification_ads_v1.cc(36)] Get eligible notification ads:
[7930:7930:1121/064756.110671:VERBOSE1:eligible_notification_ads_v1.cc(165)] Get eligible ads for untargeted segment
[7930:7930:1121/064756.138216:VERBOSE2:priority.h(35)] 2 ads with a priority of 1 in bucket 1
[7930:7930:1121/064756.138973:VERBOSE3:priority.h(44)] 1 ads with a priority of 5 in bucket 2
[7930:7930:1121/064756.139409:VERBOSE1:eligible_notification_ads_v1.cc(188)] 2 eligible ads out of 3 ads for untargeted segment
[7930:7930:1121/064756.139858:VERBOSE1:notification_ad.cc(135)] Opportunity arose to serve a notification ad
[7930:7930:1121/064756.140501:VERBOSE1:notification_ad_serving.cc(124)] Found 2 eligible ads
[7930:7930:1121/064756.140914:VERBOSE1:notification_ad_serving.cc(192)] Served notification ad:
  placementId: 76e5edb9-9c6d-4727-b238-4babfb6ab465
  creativeInstanceId: 5c6986a1-2a8e-482a-8371-52b57bc66e1b
  creativeSetId: dc19fef8-bc51-4748-938b-c7fcd4d50285
  campaignId: cee80b23-38ab-4104-a192-084a753704bb
  advertiserId: 602b6c48-d465-4530-a78f-4488ab88815d
  segment: untargeted
  title: Ledger Family Pack
  body: Get your family into crypto with 3 of our hardware wallets
  targetUrl: https://shop.ledger.com/products/ledger-nano-s-3pack?r=0ba5d7199327

Expected result:

unable to view an ad

[12332:12332:1120/155412.731078:VERBOSE2:permission_rule_util.cc(25)] --enable-features command-line arg is not supported
[12332:12332:1120/155412.731349:VERBOSE1:notification_ad_serving.cc(117)] Notification ad not served: Not allowed due to permission rules

Reproduces how often:

100% repro rate

Brave version (brave://version info)

Brave 1.46.117 Chromium: 107.0.5304.110 (Official Build) beta (64-bit)
Revision 2a558545ab7e6fb8177002bf44d4fc1717cb2998-refs/branch-heads/5304@{#1202}
OS Ubuntu 18.04 LTS

cc @jsecretan @tmancey @aseren

@tmancey
Copy link
Contributor

tmancey commented Nov 22, 2022

This is a change in Chromium, and I am investigating a fix.

@btlechowski
Copy link
Author

Still reproducible

Brave 1.49.120 Chromium: 111.0.5563.64 (Official Build) (64-bit)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS Ubuntu 18.04
[2388:2388:0308/191159.238579:VERBOSE1:notification_ad_serving.cc(131)] Found 1 eligible ads
[2388:2388:0308/191159.238732:VERBOSE1:notification_ad_serving.cc(196)] Served notification ad:
  placementId: 889ee58a-ea54-4bf4-9884-b1c3e09384af
  creativeInstanceId: c80153f6-cf22-41c0-8c2c-24c1f9a23c96
  creativeSetId: 58c1dcd9-24a4-4886-bf5d-4235c3074110
  campaignId: 5c00bdb5-a8b2-4290-b51d-96e5db2da195
  advertiserId: 602b6c48-d465-4530-a78f-4488ab88815d
  segment: untargeted
  title: Ledger Nano S Plus
  body: The world’s most popular hardware wallet
  targetUrl: https://shop.ledger.com/products/ledger-nano-s-plus?r=0ba5d7199327

@btlechowski
Copy link
Author

Verification passed on

Brave 1.51.80 Chromium: 112.0.5615.49 (Official Build) beta (64-bit)
Revision bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS Ubuntu 18.04 LTS

Verified the test plan from brave/brave-core#17717

@rebron rebron changed the title ads are not blocked when --enable-features is used on production Ads are not blocked when --enable-features is used on production Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants