Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore deleted sites #936

Closed
NejcZdovc opened this issue Sep 3, 2018 · 3 comments · Fixed by brave/brave-core#434
Closed

Restore deleted sites #936

NejcZdovc opened this issue Sep 3, 2018 · 3 comments · Fixed by brave/brave-core#434

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Sep 3, 2018

User can delete sites and recover them in the panel. In this issue we will implement button to restore all publishers, that will be shown in see all sites for auto contribute.

Button text: Restore <X> manually excluded sites

@NejcZdovc
Copy link
Contributor Author

blocked on #967

@jenn-rhim
Copy link

Button text should be 'Restore All Excluded Sites': no need to mention 'manually' as we don't allow auto-excluded sites to be restored nor has the user been exposed to the notion of 'auto-exclusion'. Hence unnecessary cognitive noise.

If we could, adding this in front of the button would be nice:
Total Excluded Sites: xx

@srirambv
Copy link
Contributor

srirambv commented Oct 10, 2018

Verification Passed on

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta (64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Linux
  • Verified excluded sites can be restored back by clicking on Restore all button

Verification passed on

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) (64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Windows 7

Used test plan from brave/brave-core#434

Verified passed with

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta(64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Mac OS X

Used test plan from brave/brave-core#434

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment