Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto contribution fails for Gemini #29089

Closed
LaurenWags opened this issue Mar 15, 2023 · 5 comments · Fixed by brave/brave-core#17644
Closed

Auto contribution fails for Gemini #29089

LaurenWags opened this issue Mar 15, 2023 · 5 comments · Fixed by brave/brave-core#17644
Assignees
@husobee @szilardszaloki
Labels
feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass-macOS QA/Yes release-notes/exclude
Milestone
1.50.x - Release

Comments

@LaurenWags
Copy link
Member

Description

Auto contribution for Gemini fails.

Caused by #24189.

cc @Miyayes @szilardszaloki

Steps to Reproduce

Set up auto contribution to occur while connected to Gemini.

Actual result:

AC fails

[15787:259:0315/085404.244323:INFO:contribution.cc(669)] Contribution failed after 3 retries

No message in UI:

Screen Shot 2023-03-15 at 8 55 38 AM

Expected result:

AC should not fail

Reproduces how often:

easily

Brave version (brave://version info)

1.50.91

Version/Channel Information:

  • Can you reproduce this issue with the current release? no, does not reproduce on 1.49.x
  • Can you reproduce this issue with the beta channel? 1.50.x yes
  • Can you reproduce this issue with the nightly channel? 1.51.x unsure but likely

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Mar 15, 2023 •
edited
Loading

Reproduced the issue on Windows 10 x64 - Bravebeta 1.50.90

[14712:17096:0315/205420.554:VERBOSE1:contribution_ac.cc(32)] Starting auto contribution
[14712:17096:0315/205420.554:VERBOSE5:ledger_impl.cc(117)]
[ REQUEST ]
> URL: https://api.sandbox.gemini.com/v1/balances
> Method: POST
[14712:17096:0315/205420.570:VERBOSE1:publisher.cc(507)] Publisher list is empty
[14712:17096:0315/205420.570:VERBOSE1:contribution_ac.cc(56)] AC list is empty
[14712:17096:0315/205420.570:VERBOSE1:contribution.cc(721)] Retrying contribution (fb06d3d8-b52b-4ad4-b2c5-3253108df6b4) on step STEP_START
[14712:17096:0315/205420.586:VERBOSE1:contribution.cc(721)] Retrying contribution (4f6ceb10-7987-492b-9cfd-5b89797e6c70) on step STEP_START
[14712:17096:0315/205420.586:VERBOSE5:ledger_impl.cc(117)]
[ REQUEST ]
> URL: https://api.sandbox.gemini.com/v1/payments/pay
> Method: POST
> Content Type: application/json; charset=utf-8
[14712:17096:0315/205420.601:VERBOSE5:ledger_impl.cc(117)]
[ REQUEST ]
> URL: https://api.sandbox.gemini.com/v1/payments/pay
> Method: POST
> Content Type: application/json; charset=utf-8
[14712:17096:0315/205420.601:VERBOSE5:ledger_impl.cc(117)]
[ REQUEST ]
> URL: https://api.sandbox.gemini.com/v1/payments/pay
> Method: POST
> Content Type: application/json; charset=utf-8
[14712:17096:0315/205420.601:VERBOSE5:ledger_impl.cc(117)]
[ REQUEST ]
> URL: https://api.sandbox.gemini.com/v1/payments/pay
> Method: POST
> Content Type: application/json; charset=utf-8
[14712:17096:0315/205421.923:VERBOSE6:logging_util.cc(134)]
[ RESPONSE - OnRequest ]
> Url: https://api.sandbox.gemini.com/v1/balances
> Result: Success
> HTTP Code: 200
> Body: [{"amount":"100000.00","available":"100000.00","availableForWithdrawal":"100000.00","currency":"USD","type":"exchange"},{"amount":"20000","available":"20000","availableForWithdrawal":"20000","currency":"LTC","type":"exchange"},{"amount":"20000","available":"20000","availableForWithdrawal":"20000","currency":"ETH","type":"exchange"},{"amount":"20000","available":"20000","availableForWithdrawal":"20000","currency":"ZEC","type":"exchange"},{"amount":"20000","available":"20000","availableForWithdrawal":"20000","currency":"BCH","type":"exchange"},{"amount":"1963.675","available":"1963.675","availableForWithdrawal":"1963.675","currency":"BAT","type":"exchange"},{"amount":"1000","available":"1000","availableForWithdrawal":"1000","currency":"BTC","type":"exchange"}]
[14712:17096:0315/205421.923:VERBOSE9:logging_util.cc(135)]
[ RESPONSE HEADERS ]
> Url: https://api.sandbox.gemini.com/v1/balances

> Header content-length: 768
> Header content-type: application/json
> Header date: Wed, 15 Mar 2023 15:24:15 GMT
> Header server: nginx
> Header vary: Origin
[14712:17096:0315/205422.005:VERBOSE6:logging_util.cc(134)]
[ RESPONSE - OnResponse ]
> Url: https://api.sandbox.gemini.com/v1/payments/pay
> Result: Success
> HTTP Code: 200
> Body: {"amount":0.05,"currency":"BAT","destination":"622b9018-f26a-44bf-9a45-3bf3bf3c95e9","result":"OK","status":"Pending","tx_ref":"ab6b2943-af23-44a5-9c38-0ca723646797"}
[14712:17096:0315/205422.005:VERBOSE9:logging_util.cc(135)]
[ RESPONSE HEADERS ]
> Url: https://api.sandbox.gemini.com/v1/payments/pay

> Header content-length: 166
> Header content-type: application/json
> Header date: Wed, 15 Mar 2023 15:24:15 GMT
> Header server: nginx
> Header vary: Origin
[14712:17096:0315/205422.005:INFO:gemini.cc(174)] Transaction fee failed, retrying

image

@szilardszaloki
Copy link
Contributor

Above transactions need to be retried because of the settlement time, but that doesn't seem to be A-C-related. That said, Gemini A-C is indeed broken at the moment - we're working on a fix on both client and server side!

@Miyayes Miyayes added the priority/P2 A bad problem. We might uplift this to the next planned release. label Mar 16, 2023
@szilardszaloki szilardszaloki mentioned this issue Mar 16, 2023
Merged
25 tasks
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Mar 17, 2023
Closed
@szilardszaloki szilardszaloki added release-notes/exclude OS/Android Fixes related to Android browser functionality labels Mar 17, 2023
@brave-builds brave-builds added this to the 1.51.x - Nightly milestone Mar 17, 2023
@szilardszaloki szilardszaloki mentioned this issue Mar 20, 2023
Merged
7 tasks
@kjozwiak
Copy link
Member

The above requires 1.50.103 or higher for 1.50.x verification.

@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 27, 2023
@LaurenWags
Copy link
Member Author

LaurenWags commented Mar 27, 2023 •
edited
Loading

Verified with

Brave | 1.50.107 Chromium: 112.0.5615.39 (Official Build) beta (x86_64)
-- | --
Revision | a0e7b9718a92bcd1cf33b7c95316caff3fc20714-refs/branch-heads/5615@{#753}
OS | macOS Version 12.6.4 (Build 21G526)

Encountered #29391 while testing.

Gemini - 3 Auto Contribution checks - PASSED
Auto Contribution 1 - PASSED

Performed an auto contribution using Gemini but did not specify retry-interval for this attempt as it is not used in production (only used by QA to speed up testing).

Command line used:

/Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr --vmodule="*/variations/*"=9,"*/bat-native-ledger/*"=9,"*/brave_rewards/*"=9,"*/bat-native-ads/*"=9,"*/bat-native-confirmations/*"=9,"*/brave_ads/*"=9,"*/brave_user_model/*"=9,"*/bat_ads/*"=9 --rewards=staging=true,debug=true,reconcile-interval=6
  1. Clean profile using 1.50.x and above command line
  2. Close and relaunch to pull griffin
  3. Join Rewards and connect Gemini staging account
  4. Added verified and non-verified sites to AC list, updated monthly budget amount if desired
  5. Waited for AC to occur
  6. Watched logs and waited for AC to complete
Auto Contribution List brave://rewards-internals AC Completed
AC List 1 Screen Shot 2023-03-28 at 4 04 09 PM Screen Shot 2023-03-28 at 4 04 24 PM
Auto Contribution 2 - PASSED

Performed an auto contribution using Gemini but did not specify retry-interval for this attempt as it is not used in production (only used by QA to speed up testing).

Command line used:

/Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr --vmodule="*/variations/*"=9,"*/bat-native-ledger/*"=9,"*/brave_rewards/*"=9,"*/bat-native-ads/*"=9,"*/bat-native-confirmations/*"=9,"*/brave_ads/*"=9,"*/brave_user_model/*"=9,"*/bat_ads/*"=9 --rewards=staging=true,debug=true,reconcile-interval=4
  1. Clean profile using 1.50.x and above command line
  2. Close and relaunch to pull griffin
  3. Join Rewards and connect Gemini staging account
  4. Added verified and non-verified sites to AC list, updated monthly budget amount if desired
  5. Waited for AC to occur
  6. Watched logs and waited for AC to complete
Auto Contribution List brave://rewards-internals AC Completed
Screen Shot 2023-03-28 at 4 09 00 PM Screen Shot 2023-03-28 at 4 21 52 PM Screen Shot 2023-03-28 at 4 22 02 PM
Auto Contribution 3 - PASSED

Performed an auto contribution using Gemini but did not specify retry-interval for this attempt as I encountered #29391.

Command line used:

/Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr --vmodule="*/variations/*"=9,"*/bat-native-ledger/*"=9,"*/brave_rewards/*"=9,"*/bat-native-ads/*"=9,"*/bat-native-confirmations/*"=9,"*/brave_ads/*"=9,"*/brave_user_model/*"=9,"*/bat_ads/*"=9 --rewards=staging=true,debug=true,reconcile-interval=5
  1. Clean profile using 1.50.x and above command line
  2. Close and relaunch to pull griffin
  3. Join Rewards and connect Gemini staging account
  4. Added verified and non-verified sites to AC list, updated monthly budget amount if desired
  5. Waited for AC to occur
  6. Watched logs and waited for AC to complete
Auto Contribution List brave://rewards-internals AC Completed
Screen Shot 2023-03-29 at 3 24 32 PM Screen Shot 2023-03-29 at 3 49 40 PM Screen Shot 2023-03-29 at 3 50 02 PM
Uphold - 3 Auto Contribution checks - PASSED
Auto Contribution 1 - PASSED

Performed an auto contribution using Uphold but did not specify retry-interval for this attempt as it is not used in production (only used by QA to speed up testing).

Command line used:

/Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr --vmodule="*/variations/*"=9,"*/bat-native-ledger/*"=9,"*/brave_rewards/*"=9,"*/bat-native-ads/*"=9,"*/bat-native-confirmations/*"=9,"*/brave_ads/*"=9,"*/brave_user_model/*"=9,"*/bat_ads/*"=9 --rewards=staging=true,debug=true,reconcile-interval=6
  1. Clean profile using 1.50.x and above command line
  2. Close and relaunch to pull griffin
  3. Join Rewards and connect Uphold staging account
  4. Added verified and non-verified sites to AC list, updated monthly budget amount if desired
  5. Waited for AC to occur
  6. Watched logs and waited for AC to complete
Auto Contribution List brave://rewards-internals AC Completed
Screen Shot 2023-03-29 at 4 01 31 PM Screen Shot 2023-03-29 at 4 09 18 PM Screen Shot 2023-03-29 at 4 09 26 PM
Auto Contribution 2 - PASSED

Performed an auto contribution using Uphold but did not specify retry-interval for this attempt as it is not used in production (only used by QA to speed up testing).

Command line used:

/Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr --vmodule="*/variations/*"=9,"*/bat-native-ledger/*"=9,"*/brave_rewards/*"=9,"*/bat-native-ads/*"=9,"*/bat-native-confirmations/*"=9,"*/brave_ads/*"=9,"*/brave_user_model/*"=9,"*/bat_ads/*"=9 --rewards=staging=true,debug=true,reconcile-interval=4
  1. Clean profile using 1.50.x and above command line
  2. Close and relaunch to pull griffin
  3. Join Rewards and connect Uphold staging account
  4. Added verified and non-verified sites to AC list, updated monthly budget amount if desired
  5. Waited for AC to occur
  6. Watched logs and waited for AC to complete
Auto Contribution List brave://rewards-internals AC Completed
Screen Shot 2023-03-29 at 4 12 59 PM Screen Shot 2023-03-29 at 4 24 44 PM Screen Shot 2023-03-29 at 4 24 52 PM
Auto Contribution 3 - PASSED

Performed an auto contribution using Uphold but did not specify retry-interval for this attempt as I encountered #29391.

Command line used:

/Applications/Brave\ Browser\ Beta.app/Contents/MacOS/Brave\ Browser\ Beta --args --enable-logging=stderr --vmodule="*/variations/*"=9,"*/bat-native-ledger/*"=9,"*/brave_rewards/*"=9,"*/bat-native-ads/*"=9,"*/bat-native-confirmations/*"=9,"*/brave_ads/*"=9,"*/brave_user_model/*"=9,"*/bat_ads/*"=9 --rewards=staging=true,debug=true,reconcile-interval=5
  1. Clean profile using 1.50.x and above command line
  2. Close and relaunch to pull griffin
  3. Join Rewards and connect Uphold staging account
  4. Added verified and non-verified sites to AC list, updated monthly budget amount if desired
  5. Waited for AC to occur
  6. Watched logs and waited for AC to complete
Auto Contribution List brave://rewards-internals AC Completed
Screen Shot 2023-03-29 at 4 29 52 PM Screen Shot 2023-03-29 at 4 35 07 PM Screen Shot 2023-03-29 at 4 35 16 PM

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Mar 29, 2023 •
edited
Loading

Verification PASSED on Vivo x70 Pro version 12 running Bravemonoarm64.apk_1.50.108

Gemini

Gemini Auto Contribution 1 - PASSED
  1. Clean profile using 1.50.x
  2. Enable the staging flags via QA preferences
  3. Join Rewards and connect Gemini staging account
  4. Added verified and non-verified sites to AC list, updated monthly budget amount if desired
  5. Waited for AC to occur
  6. Watched logs and waited for AC to complete
Auto Contribution List brave://rewards-internals AC Completed Rewards summary
Screenshot_20230329_181819 Screenshot_20230428_184223 Screenshot_20230428_184153 Screenshot_20230428_184148
Gemini Auto Contribution 2 - PASSED
  1. Clean profile using 1.50.x
  2. Enable the staging flags via QA preferences
  3. Join Rewards and connect Gemini staging account
  4. Added verified and non-verified sites to AC list, updated monthly budget amount if desired
  5. Waited for AC to occur
  6. Watched logs and waited for AC to complete
Auto Contribution List brave://rewards-internals AC Completed Rewards summary
Screenshot_20230329_200514 Screenshot_20230428_202719 Screenshot_20230428_202710 Screenshot_20230428_202701
Gemini Auto Contribution 3 - PASSED
  1. Clean profile using 1.50.x
  2. Enable the staging flags via QA preferences
  3. Join Rewards and connect Gemini staging account
  4. Added verified and non-verified sites to AC list, updated monthly budget amount if desired
  5. Waited for AC to occur
  6. Watched logs and waited for AC to complete
Auto Contribution List brave://rewards-internals AC Completed Rewards summary
Screenshot_20230329_203859 Screenshot_20230428_205154 Screenshot_20230428_205117 Screenshot_20230428_205203

Uphold

Uphold Auto Contribution 1 - PASSED
  1. Clean profile using 1.50.x
  2. Enable the staging flags via QA preferences
  3. Join Rewards and connect Gemini staging account
  4. Added verified and non-verified sites to AC list, updated monthly budget amount if desired
  5. Waited for AC to occur
  6. Watched logs and waited for AC to complete
Auto Contribution List brave://rewards-internals AC Completed Rewards summary
Screenshot_20230329-205718_Brave Screenshot_20230428-211116_Brave Screenshot_20230428-211056_Brave Screenshot_20230428-211047_Brave
Uphold Auto Contribution 2 - PASSED
  1. Clean profile using 1.50.x
  2. Enable the staging flags via QA preferences
  3. Join Rewards and connect Gemini staging account
  4. Added verified and non-verified sites to AC list, updated monthly budget amount if desired
  5. Waited for AC to occur
  6. Watched logs and waited for AC to complete
Auto Contribution List brave://rewards-internals AC Completed Rewards summary
Screenshot_20230428-213527_Brave Screenshot_20230428-214030_Brave Screenshot_20230428-214011_Brave Screenshot_20230428-214003_Brave
Uphold Auto Contribution 3 - PASSED
  1. Clean profile using 1.50.x
  2. Enable the staging flags via QA preferences
  3. Join Rewards and connect Gemini staging account
  4. Added verified and non-verified sites to AC list, updated monthly budget amount if desired
  5. Waited for AC to occur
  6. Watched logs and waited for AC to complete
Auto Contribution List brave://rewards-internals AC Completed Rewards summary
Screenshot_20230329-214724_Brave Screenshot_20230428-215837_Brave Screenshot_20230428-215825_Brave Screenshot_20230428-215820_Brave

@GeetaSarvadnya GeetaSarvadnya added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@husobee husobee

@szilardszaloki szilardszaloki

Labels
feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass-macOS QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.50.x - Release
Development

Successfully merging a pull request may close this issue.

Only create a SKU transaction if there doesn't already exist one. brave/brave-core
7 participants
@kjozwiak @husobee @szilardszaloki @Miyayes @LaurenWags @GeetaSarvadnya @brave-builds