add flag for QA that speeds up processing of Auto Contribution list (previously "retry-interval" flag was used) #29391
Labels
dev-experience
feature/rewards
OS/Desktop
priority/P4
Planned work. We expect to get to it "soon".
QA/Yes
release-notes/exclude
Description
Starting in 1.50.x, the
retry-interval
flag (if specified) is used to determine the interval at which the transaction status is fetched from the custodian as well as determine the interval at which sites from auto contribution list are processed for votes/BAT dispersal. In 1.49.x this flag used to only determine the interval at which sites in the AC list were processed for votes/BAT dispersal.So while
retry-interval
flag does the same thing in 1.50.x (interval at which sites in AC list are processed), now that it also is being used to determine the interval to fetch transaction status, it can cause AC to fail prematurely.The
retry-interval
flag was primarily used by QA to speed up auto contribution testing (see #10238) so it would be nice to get a flag to do this again.Steps to Reproduce
--args --enable-logging=stderr --vmodule="*/bat-native-ledger/*"=9,"*/brave_rewards/*"=9,"*/bat-native-ads/*"=9,"*/bat-native-confirmations/*"=9,"*/brave_ads/*"=9,"*/brave_user_model/*"=9 --rewards=staging=true,debug=true,reconcile-interval=5,retry-interval=30
retry-interval
set in command line), browser attempts to fetch txn status from Gemini and txn is still pendingIt should be noted, that the browser is behaving correctly in AC failing as it only attempts 5x, but since
retry-interval
is being used for two things (1 (new) - interval for fetching transaction status from custodian and 2 (existing) interval at which the sites in AC list are processed) this is what is causing a problem/clash.Actual result:
In logs:
brave://rewards-internals:
Expected result:
a flag (can be separate from
retry-interval
) that does whatretry-interval
did previously, when it was initially implementedReproduces how often:
easily
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
cc @szilardszaloki @Miyayes
The text was updated successfully, but these errors were encountered: