Disable Copy Clean link hotkeys for OSX

[spylogsster]

Disable feature kBraveCopyCleanLinkByDefault on osx by default

[LaurenWags]

@brave/qa-team added QA/Test-All-Platforms since we should confirm the following:

• disabled by default on macOS
• enabled by default on Windows and Linux

See #29177 verification notes for for examples.

[kjozwiak]

The above requires 1.49.131 or higher for 1.49.x verification 👍

[LaurenWags]

Verified with

Brave | 1.49.131 Chromium: 111.0.5563.116 (Official Build) (arm64)
-- | --
Revision | ade86b9472831e26d87fd569e04b404be01e1e2b-refs/branch-heads/5563@{#1209}
OS | macOS Version 12.6.3 (Build 21G419)

Using 1.49.131, confirmed default for brave://flags/#brave-copy-clean-link-by-default was disabled:

Case A: Ran through appropriate cases on https://fmarier.github.io/brave-testing/copy-clean-link.html to confirm functionality still works with the keyboard shortcut disabled. (spot check of "Copy clean link" functionality)

Case B: Ran through the below steps to confirm expected locations of "Copy clean link" option and confirm that keyboard shortcut (Cmd + C on macOS) is not used for "Copy clean link":

0. Confirmed value of "Default" for brave://flags/#brave-copy-clean-link-by-default
1. Visited https://dev-pages.bravesoftware.com/clean-urls/?brave_testing1=foo&brave_testing2=bar&brave_testing3=keep&&;b&d&utm_content=removethis&e=&f=g&=end
2. Clicked the URL bar and confirmed "Copy clean link" available from macOS app menu and it does NOT have the cmd + C keyboard shortcut (⌘C) listed next to it, this is listed next to "Copy" as expected
3. Right-clicked the URL and confirmed "Copy clean link" is in the context menu
4. Confirmed "Copy clean link" is displayed in the share menu from URL bar
5. Used "Cmd + C" while the URL bar is in focus to copy the URL
6. Opened a new tab and pasted the copied URL
7. Confirmed link pasted is the original URL with all parameters: https://dev-pages.bravesoftware.com/clean-urls/?brave_testing1=foo&brave_testing2=bar&brave_testing3=keep&&;b&d&utm_content=removethis&e=&f=g&=end
8. Opened a new tab and visited https://twitter.com/LBC/status/1577628501364146176?s=20&t=fpVMBMSfgI_pNGQxxpV6bw
9. Used "Cmd + C" while the URL bar is in focus to copy the URL
10. Opened a new tab and pasted the copied link
11. Confirmed link pasted is the original URL with all parameters https://twitter.com/LBC/status/1577628501364146176?s=20&t=fpVMBMSfgI_pNGQxxpV6bw

Step 0	Step 2	Step 3	Step 4	Step 7	Step 8	Step 11

[stephendonner]

Verification PASSED using

Brave	1.49.131 Chromium: 111.0.5563.116 (Official Build) (x86_64)
Revision	ade86b9472831e26d87fd569e04b404be01e1e2b-refs/branch-heads/5563@{#1209}
OS	macOS Version 11.7.4 (Build 20G1120)

Case A: Ran through appropriate cases on https://fmarier.github.io/brave-testing/copy-clean-link.html to confirm functionality still works with the keyboard shortcut disabled. (spot check of "Copy clean link" functionality)

Case B: Ran through the below steps to confirm expected locations of "Copy clean link" option and confirm that keyboard shortcut (Command + C on macOS) is not used for "Copy clean link":

0. Confirmed value of Default for brave://flags/#brave-copy-clean-link-by-default
1. Visited https://dev-pages.bravesoftware.com/clean-urls/?brave_testing1=foo&brave_testing2=bar&brave_testing3=keep&&;b&d&utm_content=removethis&e=&f=g&=end
2. Clicked the URL and confirmed Copy clean link available from macOS app menu and it does NOT have the "command+c" keyboard shortcut next to it
3. Right-clicked the URL bar and confirmed Copy clean link is in the context menu
4. Confirmed "Copy clean link" is displayed in the share menu from URL bar
5. Used "Command + C" while the URL bar is in focus to copy the URL
6. Opened a new tab and pasted the copied URL
7. Confirmed link pasted is the original URL with all parameters: https://dev-pages.bravesoftware.com/clean-urls/?brave_testing1=foo&brave_testing2=bar&brave_testing3=keep&&;b&d&utm_content=removethis&e=&f=g&=end
8. Opened a new tab and visited https://twitter.com/LBC/status/1577628501364146176?s=20&t=fpVMBMSfgI_pNGQxxpV6bw
9. Used "Command + C" while the URL bar is in focus to copy the URL
10. Opened a new tab and pasted the copied link
11. Confirmed link pasted is the original URL with all parameters https://twitter.com/LBC/status/1577628501364146176?s=20&t=fpVMBMSfgI_pNGQxxpV6bw

Step 0	Step 2	Step 3	Step 4	Step 7	Step 8	Step 11

[GeetaSarvadnya]

Verification PASSED on

Brave | 1.49.132 Chromium: 111.0.5563.147 (Official Build) (64-bit)
-- | --
Revision | 029fd65a4dd711d1078468ed2206999cec86066b-refs/branch-heads/5563@{#1239}
OS | Windows 10 Version 21H2 (Build 19044.2728)

Verified the comments from #29303 (comment) and ensured Copy clean link is enabled by default on Windows

Default - PASSED

Ran through the below steps to confirm expected locations of "Copy clean link" option from context menu, share menu, and keyboard shortcut (Ctrl + C on Windows):

0. Confirmed value of Default for brave://flags/#brave-copy-clean-link-by-default
1. Visited https://dev-pages.bravesoftware.com/clean-urls/?brave_testing1=foo&brave_testing2=bar&brave_testing3=keep&&;b&d&utm_content=removethis&e=&f=g&=end
2. Right-clicked the URL and confirmed "Copy clean link" with Ctrl +C as the shortcut in the context menu
3. Confirmed "Copy clean link" is displayed in the share menu from URL bar
4. Used "Ctrl + C" while the URL bar is in focus to copy the URL
5. Opened a new tab and pasted the copied URL
6. Confirmed link is https://dev-pages.bravesoftware.com/clean-urls/?brave_testing3=keep&&;b&d&e=&f=g&=end as per the original issue verification from "Copy clean URL" feature #23315
7. Opened a new tab and visited https://twitter.com/LBC/status/1577628501364146176?s=20&t=fpVMBMSfgI_pNGQxxpV6bw
8. Used "Ctrl + C" while the URL bar is in focus to copy the URL
9. Opened a new tab and pasted the copied link
10. Confirmed link pasted is https://twitter.com/LBC/status/1577628501364146176 as per the original issue verification from "Copy clean URL" feature #23315

Step 0	Step 2	Step 3	Step 6	Step 7	Step 10

Disabled - PASSED

Case A: Ran through appropriate cases on https://fmarier.github.io/brave-testing/copy-clean-link.html to confirm functionality still works with the keyboard shortcut disabled. (spot check of "Copy clean link" functionality)

Case B: Ran through the below steps to confirm expected locations of "Copy clean link" option and confirm that keyboard shortcut (Ctrl + C on Windows) is not used for "Copy clean link":

0. Confirmed value of Disabled for brave://flags/#brave-copy-clean-link-by-default
1. Visited https://dev-pages.bravesoftware.com/clean-urls/?brave_testing1=foo&brave_testing2=bar&brave_testing3=keep&&;b&d&utm_content=removethis&e=&f=g&=end
2. Right-clicked the URL and confirmed "Copy clean link" is in the context menu
3. Confirmed "Copy clean link" is displayed in the share menu from URL bar
4. Used "Ctrl + C" while the URL bar is in focus to copy the URL
5. Opened a new tab and pasted the copied URL
6. Confirmed link pasted is the original URL with all parameters: https://dev-pages.bravesoftware.com/clean-urls/?brave_testing1=foo&brave_testing2=bar&brave_testing3=keep&&;b&d&utm_content=removethis&e=&f=g&=end
7. Opened a new tab and visited https://twitter.com/LBC/status/1577628501364146176?s=20&t=fpVMBMSfgI_pNGQxxpV6bw
8. Used "Ctrl + C" while the URL bar is in focus to copy the URL
9. Opened a new tab and pasted the copied link
10. Confirmed link pasted is the original URL with all parameters https://twitter.com/LBC/status/1577628501364146176?s=20&t=fpVMBMSfgI_pNGQxxpV6bw

Step 0	Step 2	Step 3	Step 6	Step 7	Step 10

[btlechowski]

Verification passed on

Brave	1.49.128 Chromium: 111.0.5563.110 (Official Build) (64-bit)
Revision	3da375c9e9e5ad9b556af5df708a6e6c01d8cfb1-refs/branch-heads/5563@{#1202}
OS	Ubuntu 18.04 LTS

Default - PASSED

Ran through the below steps to confirm expected locations of "Copy clean link" option from, context menu, share menu, and keyboard shortcut:

0. Confirmed value of "Default" for brave://flags/#brave-copy-clean-link-by-default
1. Visited https://dev-pages.bravesoftware.com/clean-urls/?brave_testing1=foo&brave_testing2=bar&brave_testing3=keep&&;b&d&utm_content=removethis&e=&f=g&=end
2. Right-clicked the URL and confirmed "Copy clean link" is in the context menu
3. Confirmed "Copy clean link" is displayed in the share menu from URL bar
4. Used "Control + C" while the URL bar is in focus to copy the URL
5. Opened a new tab and pasted the copied URL
6. Confirmed link is https://dev-pages.bravesoftware.com/clean-urls/?brave_testing3=keep&&;b&d&e=&f=g&=end as per the original issue verification from "Copy clean URL" feature #23315
7. Opened a new tab and visited https://twitter.com/LBC/status/1577628501364146176?s=20&t=fpVMBMSfgI_pNGQxxpV6bw
8. Used "Control + C" while the URL bar is in focus to copy the URL
9. Opened a new tab and pasted the copied link
10. Confirmed link pasted is https://twitter.com/LBC/status/1577628501364146176 as per the original issue verification from "Copy clean URL" feature #23315

Disabled - PASSED

Case A: Ran through appropriate cases on https://fmarier.github.io/brave-testing/copy-clean-link.html to confirm functionality still works with the keyboard shortcut disabled. (spot check of "Copy clean link" functionality)

Case B: Ran through the below steps to confirm expected locations of "Copy clean link" option and confirm that keyboard shortcut is not used for "Copy clean link":

0. Confirmed value of "Disabled" for brave://flags/#brave-copy-clean-link-by-default
1. Visited https://dev-pages.bravesoftware.com/clean-urls/?brave_testing1=foo&brave_testing2=bar&brave_testing3=keep&&;b&d&utm_content=removethis&e=&f=g&=end
2. Right-clicked the URL and confirmed "Copy clean link" is in the context menu
3. Confirmed "Copy clean link" is displayed in the share menu from URL bar
4. Used "control + C" while the URL bar is in focus to copy the URL
5. Opened a new tab and pasted the copied URL
6. Confirmed link pasted is the original URL with all parameters: https://dev-pages.bravesoftware.com/clean-urls/?brave_testing1=foo&brave_testing2=bar&brave_testing3=keep&&;b&d&utm_content=removethis&e=&f=g&=end
7. Opened a new tab and visited https://twitter.com/LBC/status/1577628501364146176?s=20&t=fpVMBMSfgI_pNGQxxpV6bw
8. Used "control + C" while the URL bar is in focus to copy the URL
9. Opened a new tab and pasted the copied link
10. Confirmed link pasted is the original URL with all parameters https://twitter.com/LBC/status/1577628501364146176?s=20&t=fpVMBMSfgI_pNGQxxpV6bw