Use consistent naming for "fingerprinting" / "device recognition"

[agentofuser]

Test plan

See brave/brave-core#2149

Description

Global shield settings has a dropdown for "Fingerprinting protection," whereas per-site shield settings features a "device recognition" dropdown. I guess these refer to the same thing, but it is not obvious. It would be better to use consistent wording for this feature.

Steps to Reproduce

1. Open brave://settings
2. Search for "shield"
3. Note label saying "Fingerprinting protection"
4. Open brave.com
5. Click Brave shield icon
6. Note dropdown with string "Device recognition"

Actual result:

Global shield settings use "Fingerprinting", domain-specific shield settings use "device recognition."

Expected result:

UI should use "device recognition" everywhere consistently.

Reproduces how often:

Always

Brave version (brave://version info)

Brave | 0.60.15 Chromium: 72.0.3626.53 (Official Build) dev(64-bit)
Revision | 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS | Mac OS X

Reproducible on current release:

• Does it reproduce on brave-browser dev/beta builds?
  Yes

Website problems only:

• Does the issue resolve itself when disabling Brave Shields? N/A
• Is the issue reproducible on the latest version of Chrome? N/A

[srirambv]

cc: @karenkliu @bradleyrichter

[karenkliu]

^^^ It should be "device recognition" everywhere.

[agentofuser]

Isn't this a bit inaccurate though? If a laptop is used by multiple people who each have their own user profile, fingerprinting could detect who the current user is by looking at installed extensions and other user-specific settings, thereby inferring more information than just which device is being used.

[karenkliu]

@agentofuser Yes - the label "device recognition" can be misleading, but we know that "fingerprinting" is even more confusing to non-tech-savvy users than the former. Also, this group of users typically one have 1 profile per device.

This Github issue is about label consistency; the question of whether or not there is a better term than "device recognition" still requires further user research. I'm in agreement that we might still be able to come up with something better - something that is understandable to power users and the typical casual user.

[agentofuser]

Good point. I agree.

[srirambv]

Verification passed on

Brave	0.68.113 Chromium: 76.0.3809.62 (Official Build) beta (64-bit)
Revision	7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS	Linux

• Verified global shields settings has shields info and naming convention as mentioned in test plan
  
• Verified Shields has the same naming convention as global shields settings
  

Verified passed with

Brave	0.68.114 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision	111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS	Mac OS X

• Verified test plan from Use same labels on Shields global settings and panel brave-core#2149

Verification passed on

Brave	0.68.119 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision	111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS	Windows 10 OS Version 1803 (Build 17134.523)

• Verified test plan from Use same labels on Shields global settings and panel brave-core#2149

• Verified global shields settings has shields info and naming convention as mentioned in the test plan

• Verified Shields has the same naming convention as global shields settings