Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "Device recognition" label to "Fingerprint" #7949

Closed
bsclifton opened this issue Jan 28, 2020 · 9 comments · Fixed by brave/brave-core#4574 or brave/brave-core#5140
Closed

Change "Device recognition" label to "Fingerprint" #7949

bsclifton opened this issue Jan 28, 2020 · 9 comments · Fixed by brave/brave-core#4574 or brave/brave-core#5140
Assignees
Labels
feature/shields The overall Shields feature in Brave. needs-text-change This change requires some careful wording. OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include

Comments

@bsclifton
Copy link
Member

bsclifton commented Jan 28, 2020

Test plan

See brave/brave-core#4574

Description

The term "Fingerprinting" is becoming more mainstream. We'd like to change all references for Device recognition to Fingerprint

As an example:
Cross-site device recognition blocked => Cross-site fingerprint blocked

Let's confirm all uses with @karenkliu, @tomlowenthal, @diracdeltas, and others before closing ticket

Miscellaneous Information:

Original issue where we changed things to device recognition: #3027

@bsclifton bsclifton added feature/shields The overall Shields feature in Brave. needs-text-change This change requires some careful wording. labels Jan 28, 2020
@bsclifton bsclifton added the priority/P4 Planned work. We expect to get to it "soon". label Jan 28, 2020
@bsclifton
Copy link
Member Author

@cezaraugusto is this something you'd be able to look at? 😄

@cezaraugusto cezaraugusto self-assigned this Jan 28, 2020
cezaraugusto added a commit to brave/brave-core that referenced this issue Feb 10, 2020
Close brave/brave-browser#7949

Areas changed by this commit are Shields settings and Shields panel
@pes10k
Copy link
Contributor

pes10k commented Feb 10, 2020

Fingerprint is a super overloaded term, even for the very very small number of folks who know web privacy terms.

I think “device fingerprinting” is better than fingerprinting, but I also think we should probably just get rid of this setting all together, as we move to farbling (i.e. fingerprinting protections we have high confidence will not break things)

@bsclifton bsclifton added this to the 1.6.x - Nightly milestone Feb 18, 2020
@bbondy bbondy modified the milestones: 1.6.x - Beta, 1.7.x - Dev Mar 10, 2020
jonathanKingston pushed a commit to jonathanKingston/brave-core that referenced this issue Mar 11, 2020
Close brave/brave-browser#7949

Areas changed by this commit are Shields settings and Shields panel
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Mar 19, 2020

Verification passed on

Brave 1.7.67 Chromium: 80.0.3987.149 (Official Build) beta (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Shield panel:
image

brave://settings/shields
image

@karenkliu
Copy link

@GeetaSarvadnya @bsclifton It should be "fingerprinting" not "fingerprinting attempts", so the options should be this:

image

@cezaraugusto
Copy link
Contributor

Milestone updated per brave/brave-core#5140 addressing extra feedback per #7949 (comment)

@LaurenWags
Copy link
Member

Clearing QA Pass-Win64 label as this needs to be rechecked due to changes and landing in a new milestone.

@LaurenWags
Copy link
Member

@karenkliu can you take a look at this one please? It looks like attempts was removed from brave://settings/shields:
Screen Shot 2020-04-21 at 1 20 59 PM

but still exists in two of the options on the panel (it's in the middle of the strings) Is this ok? afaik there are changes coming to Fingerprinting and its labels - not sure when that is though.

Screen Shot 2020-04-21 at 1 25 20 PM

@karenkliu
Copy link

@LaurenWags "Attempts" need to be removed from all the fingerprinting options. I already addressed this in the comment here #7949 (comment)

The options should be this for both Shields panel and brave://settings/shields:
image

@LaurenWags
Copy link
Member

LaurenWags commented Apr 22, 2020

Verified passed with

Brave 1.8.82 Chromium: 81.0.4044.113 (Official Build) dev (64-bit)
Revision e3225dafb0475864a1812a374d73a92e391635ac-refs/branch-heads/4044@{#936}
OS macOS Version 10.14.6 (Build 18G3020)

brave://settings/shields:
Screen Shot 2020-04-22 at 3 04 39 PM

panel:
Screen Shot 2020-04-22 at 3 05 09 PM

Verification passed on

Brave 1.8.82 Chromium: 81.0.4044.113 (Official Build) dev (64-bit)
Revision e3225dafb0475864a1812a374d73a92e391635ac-refs/branch-heads/4044@{#936}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Clean profile:
BR panel:
image

brave://settings/shields
image

Upgrade Profile

Upgraded 1.7.x to 1.8.x and verified that the Global fingerprint setting changed from Only block cross-site Fingerprints to Block cross-site Fingerprints

Verification passed on

Brave 1.8.82 Chromium: 81.0.4044.113 (Official Build) dev (64-bit)
Revision e3225dafb0475864a1812a374d73a92e391635ac-refs/branch-heads/4044@{#936}
OS Ubuntu 18.04 LTS

image
image

@rebron rebron changed the title Reword Device recognition as Fingerprint Change Device recognition label to Fingerprint Apr 29, 2020
@rebron rebron changed the title Change Device recognition label to Fingerprint Change "Device recognition" label to "Fingerprint" Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment