Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling is too aggressive with tab groups, can scroll to have an empty panel #30627

Closed
rebron opened this issue May 26, 2023 · 4 comments · Fixed by brave/brave-core#18669
Closed
Assignees
Labels

Comments

@rebron
Copy link
Collaborator

rebron commented May 26, 2023

Description

With vertical tabs enabled and with a group with lots of tabs, can get into a state (by collapsing the tabs group) where scrolling doesn't stop and can appear to have an empty vertical tabs panel.

It seems like when tab groups are collapsed, it's scrolling as if tabs groups is expanded.

Steps to Reproduce

  1. Enable vertical tabs.
  2. Create a tab group with 20+ tabs in that group.
  3. Collapse tab group and scroll. Notice you can make the vertical tabs panel appear empty.

Actual result:

Screenshot 2023-05-26 at 2 06 32 PM Screenshot 2023-05-26 at 2 07 02 PM

Expected result:

Tab scroll should stop.

Reproduces how often:

Easily.

Brave version (brave://version info)

1.53.66

Version/Channel Information:

  • Can you reproduce this issue with the current release? (didn't check but likely)
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. feature/vertical-tabs release-notes/include QA/Yes labels May 26, 2023
@rebron rebron changed the title Scrolling is too aggressive, shows empty panel Scrolling is too aggressive with tab groups, can scroll to have an empty panel May 26, 2023
@sangwoo108
Copy link

On Mac, it doesn't seem to reproducible but on Windows it does.

@sangwoo108
Copy link

sangwoo108 commented May 29, 2023

@rebron Can you reproduce this on Nightly too? NVM, I was able to reproduce it.

@brave-builds brave-builds added this to the 1.54.x - Nightly milestone May 30, 2023
@rebron rebron added priority/P2 A bad problem. We might uplift this to the next planned release. and removed OS/Windows priority/P3 The next thing for us to work on. It'll ride the trains. labels May 30, 2023
@kjozwiak
Copy link
Member

The above requires 1.53.101 or higher for 1.53.x verification 👍

@MadhaviSeelam MadhaviSeelam added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jun 22, 2023
@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.53.102 Chromium: 114.0.5735.133 (Official Build) (64-bit)
-- | --
Revision | fbfa2ce68d01b2201d8c667c2e73f648a61c4f4a-refs/branch-heads/5735@{#1270}
OS | Windows 11 Version 22H2 (Build 22621.1848)

Reproduced using original STR from the description in #30627 (comment) in 1.53.66 Chromium: 114.0.5735.35
However, this is not reproducible in current release 1.52.126 Chromium: 114.0.5735.133 (Official Build) (64-bit)

tabs.mp4

Confirmed no empty vertical tab panel is shown when tab group is collapsed and tab scroll is not available

2023-06-22_10h17_58.mp4

@MadhaviSeelam MadhaviSeelam removed the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants