Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disconnecting status spins when switching servers in the VPN panel #31036

Closed
MadhaviSeelam opened this issue Jun 14, 2023 · 3 comments
Closed

Disconnecting status spins when switching servers in the VPN panel #31036

MadhaviSeelam opened this issue Jun 14, 2023 · 3 comments
Assignees
@simonhong
Labels
bug closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. feature/vpn OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Test-Plan-Specified QA/Yes

Comments

@MadhaviSeelam
Copy link

MadhaviSeelam commented Jun 14, 2023 •
edited
Loading

Description

Found this issue while testing #30792
When switching regions, sometimes, there isn't a clean Disconnect before Connecting to selected new region. Disconnecting.... message spins >5 minutes in the VPN panel. Logs show other than Disconnecting message.
@GeetaSarvadnya was able to reproduce the issue 3 times and noted on #30792 that "VPN connected to the 10th region and VPN icon turned to green color, tap on the VPN panel opens up the panel and which shows the 10th region instead of 11th region"
I was able to reproduce it as well but was intermittent. (reproduced twice out of 5 times)

Steps to Reproduce

  1. installed 1. 52.122
  2. launched Brave using brave.exe --vmodule=vpn=2 --enable-logging=stderr
  3. purchased, configured, and connected to Brave VPN
  4. switched connected regions as shown in the screencast and logs

Actual result:

Disconnecting... status spins in the VPN panel
Logs show GetConnectionState: Disconnecting message
Previous operation is in-progress message shown when disconnected VPN via OS/settings.

disconnect.spins.mp4

Expected result:

Should be a clean disconnect

Reproduces how often:

Some times

Brave version (brave://version info)

Brave | 1.52.125 Chromium: 114.0.5735.110 (Official Build) (64-bit)
-- | --
Revision | 1c828682b85bbc70230a48f5e345489ec447373e-refs/branch-heads/5735_90@{#13}
OS | Windows 11 Version 22H2 (Build 22621.1702)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@bsclifton @rebron
@simonhong simonhong self-assigned this Jun 14, 2023
@simonhong
Copy link
Member

For comparison, pasted normal situation log.
Connected to Germany first and changed region to Italy.

[32804:16016:0614/110640.687:VERBOSE2:brave_vpn_os_connection_api_base.cc(149)] Connect : start connecting!
[32804:16016:0614/110640.687:VERBOSE2:brave_vpn_os_connection_api_base.cc(333)] UpdateAndNotifyConnectionStateChange : changing from DISCONNECTED to CONNECTING
[32804:16016:0614/110640.687:VERBOSE2:brave_vpn_service.cc(133)] OnConnectionStateChanged CONNECTING
[32804:16016:0614/110640.687:VERBOSE2:brave_vpn_os_connection_api_base.cc(370)] FetchHostnamesForRegion
[32804:16016:0614/110648.490:VERBOSE2:brave_vpn_os_connection_api_base.cc(392)] OnFetchHostnames
[32804:16016:0614/110648.490:VERBOSE2:brave_vpn_os_connection_api_base.cc(430)] ParseAndCacheHostnames : Picked frankfurt-10.sgw.guardianapp.com, Frankfurt, Germany, 0, 0
[32804:16016:0614/110648.490:VERBOSE2:brave_vpn_os_connection_api_base.cc(440)] ParseAndCacheHostnames : request profile credential:production
[32804:16016:0614/110649.364:VERBOSE2:brave_vpn_os_connection_api_base.cc(462)] OnGetProfileCredentials : received profile credential
[32804:16016:0614/110650.249:VERBOSE2:brave_vpn_os_connection_api_base.cc(226)] OnCreated
[32804:16016:0614/110652.101:VERBOSE2:brave_vpn_os_connection_api_base.cc(249)] OnConnected
[32804:16016:0614/110652.101:VERBOSE2:brave_vpn_os_connection_api_base.cc(333)] UpdateAndNotifyConnectionStateChange : changing from CONNECTING to CONNECTED
[32804:16016:0614/110652.101:VERBOSE2:brave_vpn_service.cc(133)] OnConnectionStateChanged CONNECTED
[32804:16016:0614/110654.489:VERBOSE2:brave_vpn_os_connection_api_base.cc(302)] OnNetworkChanged : 6
[32804:16016:0614/110654.489:VERBOSE2:brave_vpn_os_connection_api_base.cc(302)] OnNetworkChanged : 0
[32804:16016:0614/110654.489:VERBOSE2:brave_vpn_os_connection_api_base.cc(249)] OnConnected
[32804:16016:0614/110654.489:VERBOSE2:brave_vpn_os_connection_api_base.cc(249)] OnConnected
[32804:16016:0614/110656.670:VERBOSE2:brave_vpn_service.cc(256)] SetSelectedRegion : Italy
[32804:16016:0614/110656.670:VERBOSE2:brave_vpn_os_connection_api_base.cc(217)] ResetConnectionInfo
[32804:16016:0614/110656.670:VERBOSE2:brave_vpn_os_connection_api_base.cc(183)] Disconnect : start disconnecting!
[32804:16016:0614/110656.670:VERBOSE2:brave_vpn_os_connection_api_base.cc(333)] UpdateAndNotifyConnectionStateChange : changing from CONNECTED to DISCONNECTING
[32804:16016:0614/110656.670:VERBOSE2:brave_vpn_service.cc(133)] OnConnectionStateChanged DISCONNECTING
[32804:16016:0614/110656.870:VERBOSE2:brave_vpn_os_connection_api_base.cc(333)] UpdateAndNotifyConnectionStateChange : changing from DISCONNECTING to DISCONNECTED
[32804:16016:0614/110656.870:VERBOSE2:brave_vpn_service.cc(133)] OnConnectionStateChanged DISCONNECTED
[32804:16016:0614/110656.870:VERBOSE2:brave_vpn_os_connection_api_base.cc(149)] Connect : start connecting!
[32804:16016:0614/110656.870:VERBOSE2:brave_vpn_os_connection_api_base.cc(333)] UpdateAndNotifyConnectionStateChange : changing from DISCONNECTED to CONNECTING
[32804:16016:0614/110656.870:VERBOSE2:brave_vpn_service.cc(133)] OnConnectionStateChanged CONNECTING
[32804:16016:0614/110656.870:VERBOSE2:brave_vpn_os_connection_api_base.cc(370)] FetchHostnamesForRegion
[32804:16016:0614/110656.870:VERBOSE2:brave_vpn_os_connection_api_base.cc(321)] UpdateAndNotifyConnectionStateChange: Ignore disconnected state while connecting
[32804:16016:0614/110656.870:VERBOSE2:brave_vpn_os_connection_api_base.cc(321)] UpdateAndNotifyConnectionStateChange: Ignore disconnected state while connecting
[32804:16016:0614/110658.320:VERBOSE2:brave_vpn_os_connection_api_base.cc(302)] OnNetworkChanged : 6
[32804:16016:0614/110658.320:VERBOSE2:brave_vpn_os_connection_api_base.cc(302)] OnNetworkChanged : 1
[32804:16016:0614/110658.320:VERBOSE2:brave_vpn_os_connection_api_base.cc(321)] UpdateAndNotifyConnectionStateChange: Ignore disconnected state while connecting
[32804:16016:0614/110658.320:VERBOSE2:brave_vpn_os_connection_api_base.cc(321)] UpdateAndNotifyConnectionStateChange: Ignore disconnected state while connecting
[32804:16016:0614/110720.488:VERBOSE2:brave_vpn_os_connection_api_base.cc(392)] OnFetchHostnames
[32804:16016:0614/110720.488:VERBOSE2:brave_vpn_os_connection_api_base.cc(430)] ParseAndCacheHostnames : Picked milan-1.sgw.guardianapp.com, Milan, Italy, 0, 0
[32804:16016:0614/110720.488:VERBOSE2:brave_vpn_os_connection_api_base.cc(440)] ParseAndCacheHostnames : request profile credential:production
[32804:16016:0614/110722.129:VERBOSE2:brave_vpn_os_connection_api_base.cc(462)] OnGetProfileCredentials : received profile credential
[32804:16016:0614/110723.093:VERBOSE2:brave_vpn_os_connection_api_base.cc(226)] OnCreated
[32804:16016:0614/110726.394:VERBOSE2:brave_vpn_os_connection_api_base.cc(302)] OnNetworkChanged : 6
[32804:16016:0614/110726.394:VERBOSE2:brave_vpn_os_connection_api_base.cc(302)] OnNetworkChanged : 0
[32804:16016:0614/110726.394:VERBOSE2:brave_vpn_os_connection_api_base.cc(249)] OnConnected
[32804:16016:0614/110726.394:VERBOSE2:brave_vpn_os_connection_api_base.cc(333)] UpdateAndNotifyConnectionStateChange : changing from CONNECTING to CONNECTED
[32804:16016:0614/110726.394:VERBOSE2:brave_vpn_service.cc(133)] OnConnectionStateChanged CONNECTED
[32804:16016:0614/110726.403:VERBOSE2:brave_vpn_os_connection_api_base.cc(249)] OnConnected

@simonhong
Copy link
Member

simonhong commented Jun 14, 2023 •
edited
Loading

As os vpn entry is still in connected state, it seems disconnected msg is not arrived after changing to brazil?

@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jun 15, 2023
@mattmcalister mattmcalister added the closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. label Apr 22, 2024
@mattmcalister
Copy link

Unable to reproduce. Closing as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
bug closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. feature/vpn OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Test-Plan-Specified QA/Yes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mattmcalister @rebron @simonhong @MadhaviSeelam