Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update swaps to include 0x fee #31855

Closed
HEagle18 opened this issue Jul 25, 2023 · 0 comments · Fixed by brave/brave-core#19834
Closed

Update swaps to include 0x fee #31855

HEagle18 opened this issue Jul 25, 2023 · 0 comments · Fixed by brave/brave-core#19834
Assignees
Labels
feature/web3/wallet/swap front-end-change This task is a front end task and doesn't need any C++ changes OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release.

Comments

@HEagle18
Copy link

Description

0x just updated us that they will be charging 15bps on evm swaps on select pairs. This will only apply to the free tier which brave is currently on. Documentation on new field to reflecrt pricing is here https://0x.org/docs/0x-swap-api/api-references/get-swap-v1-quote#:~:text=fee%20type%20below.-,zeroExFee,-Related%20to%20fees

https://docs.google.com/document/d/1lWAglSlKg-ruByIiL7Xe2jF9O9UDC0orcYDz7FD6x_8/edit for more info on their plans

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Desktop Brave version:

Android Device details:

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@HEagle18 HEagle18 added OS/Android Fixes related to Android browser functionality OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes feature/web3/wallet/swap labels Jul 25, 2023
@HEagle18 HEagle18 added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jul 28, 2023
@onyb onyb closed this as completed Oct 27, 2023
@onyb onyb added this to the 1.59.x - Release milestone Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet/swap front-end-change This task is a front end task and doesn't need any C++ changes OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants