Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wallet): introduce swap protocol fees #19834

Merged
merged 5 commits into from
Aug 24, 2023
Merged

feat(wallet): introduce swap protocol fees #19834

merged 5 commits into from
Aug 24, 2023

Conversation

onyb
Copy link
Member

@onyb onyb commented Aug 23, 2023 •
edited
Loading

Includes some refactoring to allow dynamic computation of fees, offer discounts, etc., in the near future.

Resolves brave/brave-browser#32464
Resolves brave/brave-browser#31855

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

MATIC-USDC (Polygon) MATIC-SUSHI (Polygon) SOL-USDC (Solana) SOL-CMFI (Solana)

@onyb onyb requested a review from a team as a code owner August 23, 2023 05:41
@onyb onyb self-assigned this Aug 23, 2023
@onyb onyb requested review from a team as code owners August 23, 2023 05:41
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet feature/web3/wallet/core labels Aug 23, 2023
onyb
onyb commented Aug 23, 2023
View reviewed changes
components/brave_wallet/browser/swap_service.cc Outdated
Comment on lines 107 to 108
auto protocol_fee_pct = percentage_fee.value() * 0;
auto brave_fee_pct = percentage_fee.value() * 1;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two lines will be changed to the following in future:

auto protocol_fee_pct = percentage_fee.value() * 0.2;
auto brave_fee_pct = percentage_fee.value() * 0.8;

@onyb onyb requested a review from supermassive August 23, 2023 09:34
@supermassive
Copy link
Collaborator

wallet core LGTM

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

StephenHeaps
StephenHeaps approved these changes Aug 23, 2023
View reviewed changes
Copy link
Collaborator

@StephenHeaps StephenHeaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iOS++
Opened brave/brave-ios#7924 for iOS front-end.

@onyb onyb enabled auto-merge (squash) August 23, 2023 19:00
@onyb onyb requested a review from josheleonard August 23, 2023 19:00
josheleonard
josheleonard approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@josheleonard josheleonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

mkarolin
mkarolin approved these changes Aug 24, 2023
View reviewed changes
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strings++

@onyb onyb merged commit 4eebdd1 into master Aug 24, 2023
6 checks passed
@onyb onyb deleted the f/wallet/swap-fees branch August 24, 2023 04:28
@github-actions github-actions bot added this to the 1.59.x - Nightly milestone Aug 24, 2023
@srirambv srirambv mentioned this pull request Sep 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@supermassive supermassive supermassive approved these changes

@StephenHeaps StephenHeaps StephenHeaps approved these changes

@josheleonard josheleonard josheleonard approved these changes

@mkarolin mkarolin mkarolin approved these changes

Assignees

@onyb onyb

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet/core feature/web3/wallet
Projects
None yet
Milestone
1.59.x - Release
Development

Successfully merging this pull request may close these issues.

Add mojo method to return swap protocol fees Update swaps to include 0x fee
6 participants
@onyb @supermassive @brave-builds @StephenHeaps @josheleonard @mkarolin