Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

welcome screen: support dark mode #3911

Closed
rebron opened this issue Mar 27, 2019 · 3 comments · Fixed by brave/brave-core#2909
Closed

welcome screen: support dark mode #3911

rebron opened this issue Mar 27, 2019 · 3 comments · Fixed by brave/brave-core#2909
Assignees
@imptrx @rossmoody
Labels
about-pages/welcome design A design change, especially one which needs input from the design team priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
0.69.x - Release

Comments

@rebron
Copy link
Collaborator

rebron commented Mar 27, 2019

Welcome screens should support dark theme when set by OS preference.

Description

Placeholder for dark theme screenshots of Welcome Tour.
@rebron rebron mentioned this issue Mar 27, 2019
Closed
@rebron rebron added the design A design change, especially one which needs input from the design team label Mar 27, 2019
@rebron rebron added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Mar 29, 2019
@cndouglas cndouglas mentioned this issue Apr 4, 2019
Open
5 tasks
@rossmoody
Copy link
Contributor

Welcome Light
Welcome Dark

@rossmoody rossmoody self-assigned this May 31, 2019
@rossmoody rossmoody mentioned this issue May 31, 2019
Merged
@bsclifton bsclifton mentioned this issue Jul 23, 2019
Merged
32 tasks
@imptrx imptrx self-assigned this Jul 25, 2019
@imptrx
Copy link

imptrx commented Jul 25, 2019

Test Plan:

  1. Ensure OS is dark mode enabled; ensure theme is set to System theme (default) on welcome or Same as ____OS in settings page
  2. Change system OS, welcome page should change accordingly
  3. All welcome screens should be dark mode enabled

@imptrx imptrx added this to the 0.70.x - Nightly milestone Jul 25, 2019
imptrx added a commit to brave/brave-core that referenced this issue Jul 26, 2019
@imptrx
⬆️ Update brave-ui SHA: closes brave/brave-browser#3911; closes brave…
1e83a67 
…/brave-browser#4657; closes brave/brave-browser#4992
@srirambv srirambv mentioned this issue Jul 30, 2019
Closed
@btlechowski
Copy link

btlechowski commented Sep 20, 2019 •
edited by kjozwiak
Loading

Verification passed on

Brave 0.69.128 Chromium: 77.0.3865.75 (Official Build) (64-bit)
Revision 201e747d032611c5f2785cae06e894cf85be7f8a-refs/branch-heads/3865@{#776}
OS Ubuntu 18.04 LTS

Verification passed on

Brave 0.69.128 Chromium: 77.0.3865.75 (Official Build) (64-bit)
Revision 201e747d032611c5f2785cae06e894cf85be7f8a-refs/branch-heads/3865@{#776}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Verification PASSED on macOS 10.14.6 x64 using the following build:

Brave 0.69.129 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.14.6 (Build 18G95)

This was referenced Sep 23, 2019
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@imptrx imptrx

@rossmoody rossmoody

Labels
about-pages/welcome design A design change, especially one which needs input from the design team priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.69.x - Release
Development

Successfully merging a pull request may close this issue.

Allow theme change during Welcome onboarding brave/brave-core
7 participants
@kjozwiak @rebron @imptrx @LaurenWags @rossmoody @btlechowski @GeetaSarvadnya