Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move internals out of ui folder #4003

Closed
NejcZdovc opened this issue Apr 4, 2019 · 1 comment · Fixed by brave/brave-core#3462
Closed

Move internals out of ui folder #4003

NejcZdovc opened this issue Apr 4, 2019 · 1 comment · Fixed by brave/brave-core#3462

Comments

@NejcZdovc
Copy link
Contributor

Currently in we have internals folder inside components/brave_rewards/resources/ui folder, which actually represents rewards settings page. So we have page inside the page where this pages are different. We should split them and move internals in this folder components/brave_rewards/resources

@NejcZdovc NejcZdovc self-assigned this Apr 4, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Apr 4, 2019
@NejcZdovc NejcZdovc added the priority/P3 The next thing for us to work on. It'll ride the trains. label May 22, 2019
@NejcZdovc NejcZdovc removed their assignment Sep 3, 2019
@NejcZdovc NejcZdovc self-assigned this Sep 18, 2019
@NejcZdovc NejcZdovc added this to the 0.72.x - Nightly milestone Sep 18, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Sep 18, 2019
@btlechowski
Copy link

btlechowski commented Oct 14, 2019

Verification passed on

Brave 0.71.93 Chromium: 77.0.3865.90 (Official Build) dev (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#3462

Verified brave://rewards page
image
Verified rewards banner
image
Verified brave://rewards-internals page
image

Verified on clean profile and upgrade from 0.70.x

Verification passed on

Brave 0.71.94 Chromium: 77.0.3865.90 (Official Build) dev (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Verified passed with

Brave 0.71.103 Chromium: 78.0.3904.70 (Official Build) beta (64-bit)
Revision edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS macOS Version 10.13.6 (Build 17G5019)
  • Verified test plan from Reorganize resources in rewards folder brave-core#3462
  • Confirmed brave://rewards and brave://rewards-internals pages load
  • Confirmed tip banners load for Verified, Connected, and Unverified publishers (custom and default banners:
    Verified publisher:

Screen Shot 2019-10-25 at 2 41 33 PM

Unverified publisher:

Screen Shot 2019-10-25 at 2 42 03 PM

Connected publisher:

Screen Shot 2019-10-25 at 2 42 25 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment