Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brave://history shows incorrect bookmark icon #4110

Closed
LaurenWags opened this issue Apr 15, 2019 · 2 comments
Closed

brave://history shows incorrect bookmark icon #4110

LaurenWags opened this issue Apr 15, 2019 · 2 comments
Assignees
Labels
closed/duplicate Issue has already been reported

Comments

@LaurenWags
Copy link
Member

Description

When viewing your history on brave://history, if you've visited a bookmarked site, the brave://history page shows the star icon next to the visited page, not our bookmark icon.

Steps to Reproduce

  1. Have some sites bookmarked.
  2. Visit at least one.
  3. View brave://history.

Actual result:

Star icon shows next to the bookmarked page visited, not our bookmark icon.

Screen Shot 2019-04-15 at 4 58 04 PM

Expected result:

Our bookmark icon is shown.

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.62.51 Chromium: 73.0.3683.103 (Official Build) (64-bit)
Revision e82a658d8159cabbd4938c1660f9bb00b4a82a23-refs/branch-heads/3683@{#902}
OS Mac OS X
Brave 0.63.41 Chromium: 74.0.3729.61 (Official Build) beta(64-bit)
Revision 5df2c8936783bd7575987e45d72a92fcf528496b-refs/branch-heads/3729@{#645}
OS Mac OS X

Reproducible on current release:

yes, reproduces on current release 0.62.51

  • Does it reproduce on brave-browser dev/beta builds? yes, reproduced on beta 0.63.41

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Additional Information

@LaurenWags LaurenWags added feature/history about-pages/rebrand Rebranding work on top of Chrome's Polymer-powered pages QA/Yes QA/Test-Plan-Specified labels Apr 15, 2019
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Apr 23, 2019
@karenkliu
Copy link

karenkliu commented Dec 13, 2019

Here's the icon!
fill-bookmarked.zip

It should look like this:
history bookmarked site

@srirambv
Copy link
Contributor

Closing in favour of #6013 as it also has discussion about bookmark folders.

@srirambv srirambv added closed/duplicate Issue has already been reported and removed QA/Test-Plan-Specified QA/Yes about-pages/rebrand Rebranding work on top of Chrome's Polymer-powered pages feature/history priority/P3 The next thing for us to work on. It'll ride the trains. labels Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported
Projects
None yet
Development

No branches or pull requests

4 participants