-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
History uses Chromium bookmark icon (star) for bookmark entries #6013
Comments
@srirambv can you be more specific about what is wrong? When I look at the picture shown, it looks good to me (shows picture of Brave icon). |
@bsclifton the icon on right is chromium star we replaced the bookmark icon with our custom icon which should be used. |
@srirambv I don't see the star? This is what my bookmarks looks like: The bigger issue for me is we should be using our own bookmarks folder icon: It replaces the Chrome bookmarks folder icon in the browser toolbar and on chrome://bookmarks/ Please use our Brave folder icon: |
@karenkliu need to check the entry in history( |
oh got it - okay, you're saying it should look like this? Here you go: |
Looks like the fix would be creating a patch on this file in the chromium source. If theres some documentation on how you create your chromium patches/how to validate and test them I can give it a shot |
Hi @darrylbutcher - our wiki has some good information about getting setup: We do have a specific section about patching too: This might be as easy as creating a new file under |
@karenkliu you need to have the site bookmarked for it to show |
@bsclifton The sites in the above screenshot are all bookmarked? 🤷 |
Description
History uses Chromium bookmark icon for bookmark entries
Steps to Reproduce
Actual result:
Expected result:
Use Brave branding icons everywhere
Reproduces how often:
Easy
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
The text was updated successfully, but these errors were encountered: