Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shields stats is clickable even when count is 0 #419

Closed
srirambv opened this issue Jun 25, 2018 · 3 comments · Fixed by brave/brave-extension#42
Closed

Shields stats is clickable even when count is 0 #419

srirambv opened this issue Jun 25, 2018 · 3 comments · Fixed by brave/brave-extension#42
Assignees
@cezaraugusto
Labels
browser-laptop-parity bug feature/shields The overall Shields feature in Brave. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Milestone
0.55.x - Release ...

Comments

@srirambv
Copy link
Contributor

Description

Shields stats is clickable even when count is 0

Steps to Reproduce

  1. Visit wikipedia.org in a new tab
  2. Ensure shields shows badge as 0
  3. Open shields, you can click on all shields stats even though it shows 0

Actual result:

Shields stats is clickable even when count is 0

Expected result:

Stats in shields should not be clickable when there is nothing blocked

Reproduces how often:

100%

Brave version (about:brave info)

80614db

Additional Information

#202
@srirambv srirambv added bug feature/shields The overall Shields feature in Brave. browser-laptop-parity labels Jun 25, 2018
@srirambv srirambv added this to the Backlog milestone Jun 25, 2018
cezaraugusto added a commit to brave/brave-extension that referenced this issue Jul 2, 2018
@cezaraugusto
do not allow showing resources blocked if there's none
33e4d05 
fix brave/brave-browser#419
@cezaraugusto cezaraugusto mentioned this issue Jul 2, 2018
Merged
@bbondy bbondy modified the milestones: Backlog, Releasable builds Jul 3, 2018
@bbondy bbondy added the QA/Yes label Aug 18, 2018
@GeetaSarvadnya
Copy link

Issue is still reproduced on

Brave 0.54.2 Chromium: 69.0.3497.42 (Official Build) dev (64-bit)
Revision 9c4613c66dfeb2b76ef6dd4b15884c15db3b4969-refs/branch-heads/3497@{#655}
OS Windows
JavaScript V8 6.9.427.14
Flash 30.0.0.154

@cezaraugusto
Copy link
Contributor

after convo with @srirambv I'm closing this in favor of #875. Thanks @GeetaSarvadnya

@cezaraugusto cezaraugusto mentioned this issue Sep 3, 2018
Closed
@btlechowski
Copy link

btlechowski commented Sep 21, 2018 •
edited by kjozwiak
Loading

Verification passed on

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows 7

Stats are not clickable, but cursor changes. Issue reported in #875

Verification Passed on

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Mac OS X

@bbondy bbondy added the QA/Yes label Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cezaraugusto cezaraugusto

Labels
browser-laptop-parity bug feature/shields The overall Shields feature in Brave. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

do not allow showing resources blocked if there's none brave/brave-extension
6 participants
@bbondy @kjozwiak @cezaraugusto @srirambv @btlechowski @GeetaSarvadnya