Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocked items lists multiple time on page reload #420

Closed
srirambv opened this issue Jun 25, 2018 · 1 comment · Fixed by brave/brave-extension#43
Closed

Blocked items lists multiple time on page reload #420

srirambv opened this issue Jun 25, 2018 · 1 comment · Fixed by brave/brave-extension#43
Assignees
@cezaraugusto
Labels
bug feature/shields The overall Shields feature in Brave. priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Milestone
0.55.x - Release ...

Comments

@srirambv
Copy link
Contributor

Description

Blocked items lists multiple time on page reload

Steps to Reproduce

  1. Open google.com in a new tab
  2. Ensure shields shows 2 blocked items
  3. Reload page and click on blocked items in shields
  4. Lists the same entry again
  5. Repeat step 3 few more times
  6. Lists the same entry the number of times the page is reloaded but blocked count remains same

Actual result:
Reload page causes the blocked items to relist

Expected result:
Blocked items should not relist on page reload

Reproduces how often:
100%

Brave Version

about:brave info:
80614db
@srirambv srirambv added bug feature/shields The overall Shields feature in Brave. priority/P4 Planned work. We expect to get to it "soon". labels Jun 25, 2018
@srirambv srirambv added this to the Backlog milestone Jun 25, 2018
@srirambv srirambv modified the milestones: Backlog, Releasable builds Jun 25, 2018
cezaraugusto added a commit to brave/brave-extension that referenced this issue Jul 2, 2018
@cezaraugusto
do now allow duplicated items for resources blocked
1ecc712 
fix brave/brave-browser#420
@cezaraugusto cezaraugusto mentioned this issue Jul 2, 2018
Merged
cezaraugusto added a commit to brave/brave-extension that referenced this issue Jul 4, 2018
@cezaraugusto
do now allow duplicated items for resources blocked
52bd2ce 
fix brave/brave-browser#420
cezaraugusto added a commit to brave/brave-extension that referenced this issue Jul 4, 2018
@cezaraugusto
do now allow duplicated items for resources blocked
6a3c50d 
fix brave/brave-browser#420
@bbondy bbondy added the QA/Yes label Aug 18, 2018
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Aug 28, 2018 •
edited by LaurenWags
Loading

Verified on:

Brave 0.54.2 Chromium: 69.0.3497.42 (Official Build) dev (64-bit)
Revision 9c4613c66dfeb2b76ef6dd4b15884c15db3b4969-refs/branch-heads/3497@{#655}
OS Windows

Verification Passed on

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux

Verified passed with:

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Mac OS X

@bbondy bbondy added the QA/Yes label Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cezaraugusto cezaraugusto

Labels
bug feature/shields The overall Shields feature in Brave. priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

do now allow duplicated items for resources blocked brave/brave-extension
5 participants
@bbondy @cezaraugusto @srirambv @LaurenWags @GeetaSarvadnya