Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to disable dark theme,Downloaded file name is not readable #4272

Closed
Ashutosh-Kukreti opened this issue Apr 30, 2019 · 3 comments · Fixed by brave/brave-core#2352
Closed
Assignees
Labels
OS/Windows priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/include

Comments

@Ashutosh-Kukreti
Copy link

Ashutosh-Kukreti commented Apr 30, 2019

Description

Please add an option to disable the dark theme,nothing is visible on the download bar.Please refer to the screenshot.

Steps to Reproduce

  1. Set brave theme type to light and os theme type to dark
  2. Download any pdf or receipt from any site.

Actual result:

download

Expected result:

It should be displayed clearly

Reproduces how often:

Everytime I download a receipt of payment

Brave version (brave://version info)

Version 0.63.48 Chromium: 74.0.3729.108 (Official Build) (64-bit)

Version/Channel Information:

I don not know

  • Can you reproduce this issue with the current release?Yes
  • Can you reproduce this issue with the beta channel?not tried
  • Can you reproduce this issue with the dev channel?not tried
  • Can you reproduce this issue with the nightly channel?not tried

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards?No
  • Is the issue reproducible on the latest version of Chrome? No

Miscellaneous Information:

My theme is set to light in the settings but everything is dark.

@Ashutosh-Kukreti
Copy link
Author

This will apply dark theme to the whole browser,

But that’s not what I want,
I want windows in dark mode and brave with light theme.This does not fixed my problem so there is no point in closing this issue,please fix the light theme in settings

@simonhong
Copy link
Member

simonhong commented May 10, 2019

Hi @Ashutosh-Kukreti ,
With this brave/brave-core#2352, you can use light theme as a whole brave browser theme if you select light option regardless of windows theme.

@btlechowski
Copy link

btlechowski commented Jun 12, 2019

Verification passed on

Brave 0.66.87 Chromium: 75.0.3770.80 (Official Build) beta (64-bit)
Revision 9a9aa15057b6b2cc0909bdcf638c0b65ecd516f2-refs/branch-heads/3770@{#948}
OS Windows 10 OS Version 1809 (Build 17763.379)

Verified test plan from brave/brave-core#2352 and from the description.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Windows priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants