-
Notifications
You must be signed in to change notification settings - Fork 870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use brave theme type as a system dark mode on Windows #2352
Use brave theme type as a system dark mode on Windows #2352
Conversation
1623b95
to
e5c820b
Compare
security test is failed on Builder. |
e5c820b
to
bf60812
Compare
Kindly ping.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works really nicely 🎨
Before merging, re-running PR builder due to previous time-out failure... |
@petemill Yup, will rebase again! thanks for review |
bf60812
to
96bca73
Compare
@simonhong most recent failure is possibly:
|
@petemill Hmm, no lint error on local.. Lint gave invalid suggestion. seems lint bug.. |
96bca73
to
064abe7
Compare
Aligning base UI theme(ex, context menu) with brave theme was not implemented on Windows because Windows doesn't support per-application theme. Whereas, MacOS support it. So, when user set dark or light, it is set as a application theme. To solve this on Windows, NativeThemeWin::SystemDarkModeEnabled() checks whether dark mode enabling is overridden or not. Overridden value is set by client(BraveThemeService).
064abe7
to
2c1bc58
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exciting!
Aligning base UI theme(ex, context menu) with brave theme was not
implemented on Windows because Windows doesn't support per-application
theme. Whereas, MacOS support it. So, when user set dark or light, it is
set as a application theme.
To solve this on Windows, NativeThemeWin::SystemDarkModeEnabled() checks
whether dark mode enabling is overridden or not.
Overridden value is set by client(BraveThemeService).
Fix brave/brave-browser#4056
Fix brave/brave-browser#4272
Fix brave/brave-browser#3804
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security
) onnpm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Other manual tests are described in related issues.
yarn test brave_browser_tests --filter=BraveThemeServiceTest.SystemThemeChangeTest
Reviewer Checklist:
After-merge Checklist:
changes has landed on.