Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace chromium's product_logo_name for branding #447

Closed
yrliou opened this issue Jun 29, 2018 · 1 comment
Closed

Replace chromium's product_logo_name for branding #447

yrliou opened this issue Jun 29, 2018 · 1 comment

Comments

@yrliou
Copy link
Member

yrliou commented Jun 29, 2018

Right now we're using chromium's product_logo_name images in src/brave/app/theme/default_[100|200]_percent/brave, so we'll see chromium's logo in these cases.
For example,
image

@srirambv
Copy link
Contributor

srirambv commented Sep 24, 2018

Verification Passed on

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux

image

Verification PASSED on

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Mac OS X
  • Verified via chrome://settings -> Manage other people
  • Verified via User Icon -> Manage People

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants