Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update product_logo and product_log_name images #204

Merged
merged 1 commit into from
Jun 29, 2018
Merged

Conversation

yrliou
Copy link
Member

@yrliou yrliou commented Jun 29, 2018

Fix brave/brave-browser#447
Thanks @rossmoody for providing these images.

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.

Test Plan:

Open chrome://settings and click Manage other people, brave's logo should be shown in the new dialog instead of chromium's logo.
screen shot 2018-06-28 at 5 18 09 pm

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions

@yrliou yrliou self-assigned this Jun 29, 2018
Copy link
Contributor

@AlexeyBarabash AlexeyBarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@yrliou yrliou merged commit 480cd73 into master Jun 29, 2018
@yrliou yrliou deleted the update_product_logos branch June 29, 2018 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants