Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alert dialog box will not change color when switched to Light mode #4815

Closed
btlechowski opened this issue Jun 12, 2019 · 2 comments
Closed
Assignees
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. feature/user-interface All UI related priority/P4 Planned work. We expect to get to it "soon". QA/Test-Plan-Specified QA/Yes

Comments

@btlechowski
Copy link

Follow up to brave/brave-core#2352

Steps to Reproduce

  1. Clean install
  2. Launch Browser
  3. Change Brave colors to Dark under brave://settings/appearance
  4. Open https://www.w3schools.com/jsref/tryit.asp?filename=tryjsref_alert and click Try it (leave alert dialog open)
  5. Change Brave colors to Light under brave://settings/appearance
  6. Check alert dialog from 4.

Important: Closing the dialog and opening it again will show proper color
Note: Light-Dark theme switch works OK

Actual result:

Alert dialog did not change the color.
Alert dialog remains Dark themed

image

Expected result:

Alert dialog is Light themed

image

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 0.66.87 Chromium: 75.0.3770.80 (Official Build) beta (64-bit)
Revision 9a9aa15057b6b2cc0909bdcf638c0b65ecd516f2-refs/branch-heads/3770@{#948}
OS Windows 7 Service Pack 1 (Build 7601.24465)

cc @brave/legacy_qa @simonhong

@kjozwiak
Copy link
Member

Reproduced on macOS 10.14.5 x64 using the following build:

Brave 0.68.60 Chromium: 75.0.3770.90 (Official Build) nightly(64-bit)
Revision a6dcaf7e3ec6f70a194cc25e8149475c6590e025-refs/branch-heads/3770@{#1003}
OS Mac OS X

Screen Shot 2019-06-19 at 10 39 59 AM

@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Jun 21, 2019
@rebron
Copy link
Collaborator

rebron commented Jul 11, 2022

Closing as stale. This looks fixed in 1.40.113 on Windows 11 and macOS.
@btlechowski Can you reopen if still an issue?

@rebron rebron closed this as completed Jul 11, 2022
@rebron rebron added the closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. label Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. feature/user-interface All UI related priority/P4 Planned work. We expect to get to it "soon". QA/Test-Plan-Specified QA/Yes
Projects
None yet
Development

No branches or pull requests

4 participants