Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tor control switch in the extensions area of settings #4904

Closed
tildelowengrimm opened this issue Jun 13, 2019 · 4 comments
Closed

Tor control switch in the extensions area of settings #4904

tildelowengrimm opened this issue Jun 13, 2019 · 4 comments
Labels
feature/settings feature/tor priority/P3 The next thing for us to work on. It'll ride the trains.

Comments

@tildelowengrimm
Copy link
Contributor

This poor soul accidentally opened a private window with Tor when they only meant to open a regular private window, and were hounded by grumpy sysadmins for their error. https://www.reddit.com/r/brave_browser/comments/bxncmt/so_long_guys_back_to_firefox_im_afraid/

We could let people avoid this mistake by adding a toggle in the extensions area of settings to disable Tor. Not a security feature, just a convenience feature if you know that you definitely never want Brave to use Tor.

@tildelowengrimm tildelowengrimm added feature/tor priority/P4 Planned work. We expect to get to it "soon". feature/settings labels Jun 13, 2019
@brianddk
Copy link

@tomlowenthal , Thank you, yes I am that unfortunate soul. I'm on my sysadmin's "watch list" and I had to purge Brave from my network instances until I can be assured they won't "beacon" again in the future.

More than willing to compile a DLL, or hack a flag or registry setting to disable Tor. Other users might want something a bit more accessible.

@BrendanEich
Copy link
Member

I have DMs from folks who want this. If easy, we should knock it out, for adoption upside. Thanks.

@tildelowengrimm tildelowengrimm added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P4 Planned work. We expect to get to it "soon". labels Jun 26, 2019
@riastradh-brave
Copy link
Contributor

riastradh-brave commented Jul 25, 2019

Entails:

  • settings switch, for one-off users
  • admin policy, for IT departments to issue if they want
  • removing / greying out menu items -- note this requires browser restart to take effect
  • prevent downloading the tor component
  • maybe delete the component if the switch is flipped

@eddiedunn
Copy link

It would be great to see some form of this implemented.

tmancey pushed a commit that referenced this issue Apr 9, 2020
…android_1.7.x

Turn off haptics for Brave Ads notifications on Android (uplift to 1.7.x)
@bbondy bbondy added this to the Closed / Invalid milestone Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/settings feature/tor priority/P3 The next thing for us to work on. It'll ride the trains.
Projects
None yet
Development

No branches or pull requests

6 participants