Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitter metadata needs to be generalized for other media publishers #4907

Closed
jasonrsadler opened this issue Jun 14, 2019 · 1 comment · Fixed by brave/brave-core#2723
Closed

Comments

@jasonrsadler
Copy link

jasonrsadler commented Jun 14, 2019

Description

twitterMetaData for Brave Rewards needs to be generalized so that it can be used for other media publishers (Reddit, GitHub)

No issue to reproduce as this is a dev concern as follow up to brave/brave-core#2665

@jasonrsadler jasonrsadler self-assigned this Jun 14, 2019
@NejcZdovc NejcZdovc added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Jun 17, 2019
jasonrsadler pushed a commit to brave/brave-core that referenced this issue Jun 22, 2019
jasonrsadler pushed a commit to brave/brave-core that referenced this issue Jun 25, 2019
@kjozwiak kjozwiak added this to the 0.69.x - Nightly milestone Jul 23, 2019
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 24, 2019

Verification passed on

Brave 0.69.128 Chromium: 77.0.3865.75 (Official Build) (64-bit)
Revision 201e747d032611c5f2785cae06e894cf85be7f8a-refs/branch-heads/3865@{#776}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Verification passed on

Brave 0.69.128 Chromium: 77.0.3865.75 (Official Build) (64-bit)
Revision 201e747d032611c5f2785cae06e894cf85be7f8a-refs/branch-heads/3865@{#776}
OS Ubuntu 18.04 LTS

Verified brave/brave-core#2665 and brave/brave-core#2195

Reddit tip disabled
image

Reddit tip enabled
image

Banner
image

Twitter tipping disabled
image

Twitter tipping enabled
image

Banner
image

Verified passed with

Brave 0.69.130 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.13.6 (Build 17G5019)

Screen Shot 2019-10-01 at 11 18 37 AM

* inline tip banner for connected publisher:

Screen Shot 2019-10-01 at 11 18 56 AM

* inline tip banner for unverified publisher:

Screen Shot 2019-10-01 at 11 19 16 AM

* tweet about a tip:

Screen Shot 2019-10-01 at 11 27 06 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants