Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Customize" text to NTP dashboard settings icon to make it more discoverable #4930

Closed
karenkliu opened this issue Jun 14, 2019 · 3 comments · Fixed by brave/brave-core#5103

Comments

@karenkliu
Copy link

karenkliu commented Jun 14, 2019

Description

Currently, the icons in the bottom right of the Dashboard look like this:

Screen Shot 2020-03-26 at 5 22 03 PM

Additionally we're heard feedback about them:

...look the same, but do very different things - one unintrusively pops up a toggle, the others load whole different pages. Can we make it intuitive that 3 of them are links to different pages, and 1 of them will lead to a menu? Perhaps by putting an arrow on that button.

Designs

Text paired with images improves comprehension by up to 89%. Add the text "Customize" next to the dashboard settings icons to make the settings more discoverable:

customize dashboard icon

Update the title of the panel to say "Customize Dashboard" to make the connection with "Customize" button text.

customize dashboard panel title

@karenkliu
Copy link
Author

@rossmoody I remember a long time ago you wrote out a guide for how to get new icons into our Design System. I wasn't able to find this doc in our repos - what's the best process to get icon assets over to the dev?

@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Sep 23, 2019
@karenkliu
Copy link
Author

Closing this issue as it's out of date - we have a new design for these icons on the NTP.

@karenkliu karenkliu reopened this Mar 27, 2020
@karenkliu karenkliu changed the title update NTP icons to differentiate Dashboard settings icon from others Add "Customize" text to NTP dashboard settings icon to make it more discoverable Mar 27, 2020
@cezaraugusto cezaraugusto self-assigned this Mar 30, 2020
@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P4 Planned work. We expect to get to it "soon". labels Mar 30, 2020
@rebron rebron removed their assignment Mar 30, 2020
cezaraugusto added a commit to brave/brave-core that referenced this issue Apr 1, 2020
@cezaraugusto cezaraugusto added this to the 1.8.x - Nightly milestone Apr 2, 2020
@LaurenWags
Copy link
Member

LaurenWags commented Apr 10, 2020

Verified passed with

Brave 1.8.71 Chromium: 81.0.4044.92 (Official Build) dev (64-bit)
Revision e98e6f21168a55e7ba57202f56323911cd9d31d1-refs/branch-heads/4044@{#883}
OS macOS Version 10.14.6 (Build 18G3020)
  • Verified for clean and upgrade profiles:

Screen Shot 2020-04-10 at 10 11 59 AM

Verification passed on

Brave 1.8.72 Chromium: 81.0.4044.92 (Official Build) dev (64-bit)
Revision e98e6f21168a55e7ba57202f56323911cd9d31d1-refs/branch-heads/4044@{#883}
OS Ubuntu 18.04 LTS
  • Verified for clean and upgrade profiles:

image

Verification passed on

Brave 1.8.77 Chromium: 81.0.4044.92 (Official Build) dev (64-bit)
Revision e98e6f21168a55e7ba57202f56323911cd9d31d1-refs/branch-heads/4044@{#883}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified for clean and upgrade profiles:

Light mode:
image

Dark mode:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants