Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brave://wallet should appear as a Brave secure page (if possible) #5109

Closed
bbondy opened this issue Jul 3, 2019 · 2 comments
Closed

brave://wallet should appear as a Brave secure page (if possible) #5109

bbondy opened this issue Jul 3, 2019 · 2 comments
Assignees
@bbondy
Labels
feature/ethereum-remote-client QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
0.69.x - Release

Comments

@bbondy
Copy link
Member

bbondy commented Jul 3, 2019

No description provided.

@bbondy bbondy added the feature/web3/wallet Integrating Ethereum+ wallet support label Jul 3, 2019
@bbondy
Copy link
Member Author

bbondy commented Jul 15, 2019

This is working as long as you use brave://wallet to load the extension. So closing it.

@bbondy bbondy closed this as completed Jul 15, 2019
@bbondy bbondy self-assigned this Aug 14, 2019
@bbondy bbondy added this to the 0.70.x - Dev milestone Aug 14, 2019
This was referenced Sep 23, 2019
Closed
Closed
Closed
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 23, 2019 •
edited by kjozwiak
Loading

Verification passed on

Brave 0.69.128 Chromium: 77.0.3865.75 (Official Build) (64-bit)
Revision 201e747d032611c5f2785cae06e894cf85be7f8a-refs/branch-heads/3865@{#776}
OS Windows 10 OS Version 1803 (Build 17134.1006)

image

image

image

Verification passed on

Brave 0.69.128 Chromium: 77.0.3865.75 (Official Build) (64-bit)
Revision 201e747d032611c5f2785cae06e894cf85be7f8a-refs/branch-heads/3865@{#776}
OS Ubuntu 18.04 LTS

image

Verification PASSED on macOS 10.14.6 x64 using the following build:

Brave 0.69.129 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.14.6 (Build 18G95)

Screen Shot 2019-09-26 at 3 23 06 PM

Screen Shot 2019-09-26 at 3 23 29 PM

Screen Shot 2019-09-26 at 3 25 13 PM

tmancey pushed a commit that referenced this issue Apr 9, 2020
@brave-browser-releases
Uplift of #5109 (squashed) to beta
76c32d6
@srirambv srirambv added feature/ethereum-remote-client and removed feature/web3/wallet Integrating Ethereum+ wallet support labels Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbondy bbondy

Labels
feature/ethereum-remote-client QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.69.x - Release
Development

No branches or pull requests
5 participants
@bbondy @kjozwiak @srirambv @btlechowski @GeetaSarvadnya