Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto install ethereum-remote-client and add for usage on first access of brave://wallet #5118

Closed
bbondy opened this issue Jul 3, 2019 · 1 comment · Fixed by brave/brave-core#2833

Comments

@bbondy
Copy link
Member

bbondy commented Jul 3, 2019

task manager should not show the process until you load brave://wallet.
The extension dir should not exist until after first load of the wallet: ~/Library/Application\ Support/BraveSoftware/Brave-Browser-Development/odbfpeeihdkbihmopkbjmoonfanlbfcl

@kjozwiak
Copy link
Member

kjozwiak commented Sep 26, 2019

Verification PASSED on macOS 10.14.6 x64 using the following build:

Brave 0.69.129 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.14.6 (Build 18G95)
  • ensured that launching brave for the first time doesn't have the Extensions: Crypto Wallets process running via the Task Manager
  • ensured that odbfpeeihdkbihmopkbjmoonfanlbfcl isn't being created in a new profile unless opening brave://wallet for the first time
  • ensured that once brave://wallet is opened, the Extensions: Crypto Wallets process is visible via the Task Manager

Screen Shot 2019-09-26 at 3 51 22 PM

Screen Shot 2019-09-26 at 6 11 36 PM

Verification passed on

Brave 0.69.129 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • ensured that launching brave for the first time doesn't have the Extensions: Crypto Wallets process running via the Task Manager
  • ensured that odbfpeeihdkbihmopkbjmoonfanlbfcl isn't being created in a new profile unless opening brave://wallet for the first time
  • ensured that once brave://wallet is opened, the Extensions: Crypto Wallets process is visible via the Task Manager

image

image

Verification passed on

Brave 0.69.129 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Ubuntu 18.04 LTS
  • ensured that launching brave for the first time doesn't have the Extensions: Crypto Wallets process running via the Task Manager
    image

  • ensured that odbfpeeihdkbihmopkbjmoonfanlbfcl isn't being created in a new profile unless opening brave://wallet for the first time

  • ensured that once brave://wallet is opened, the Extensions: Crypto Wallets process is visible via the Task Manager
    image

tmancey pushed a commit that referenced this issue Apr 9, 2020
…crash_1.7.x

Fixed crash on home button click after custom tabs (uplift to 1.7.x)
@srirambv srirambv added feature/ethereum-remote-client and removed feature/web3/wallet Integrating Ethereum+ wallet support labels Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment