Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fingerprint Protection and Block Phishing shields settings are not saved on a domain #52

Closed
srirambv opened this issue Jan 15, 2018 · 3 comments

Comments

@srirambv
Copy link
Contributor

Fingerprint Protection and Block Phishing shields settings are not saved on a domain

STR

  1. Open any page
  2. Enable Fingeprint Protection and Block Phishing switch. page doesn't reload with the settings being saved for that page
@srirambv srirambv added bug feature/shields The overall Shields feature in Brave. labels Jan 15, 2018
cezaraugusto pushed a commit that referenced this issue May 15, 2018
@bbondy
Copy link
Member

bbondy commented Jun 6, 2018

I think this is probably working now, could you verify @srirambv ?

@srirambv
Copy link
Contributor Author

srirambv commented Jun 6, 2018

Yes this is fixed for FP.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Aug 28, 2018

Verified on:

Brave 0.54.2 Chromium: 69.0.3497.42 (Official Build) dev (64-bit)
Revision 9c4613c66dfeb2b76ef6dd4b15884c15db3b4969-refs/branch-heads/3497@{#655}
OS Windows

Verification Passed on

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants